<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:EN-IN;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.diff-banner-path
{mso-style-name:diff-banner-path;}
span.diff-banner-file
{mso-style-name:diff-banner-file;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-IN" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hello Vedant,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">> could you share some of the use cases for this feature? > What were the pros/cons of any alternatives you considered (e.g. the %m/%c modes)?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">We are taking coverage of shared libraries (i.e. Linux .so) and dumping coverage into files corresponding to SO’s filename.<o:p></o:p></p>
<p class="MsoNormal">With this proposed patch, will get coverage as below for sample code (pls refer
<span class="diff-banner-path">compiler-rt/test/profile/Linux/</span><span class="diff-banner-file">instrprof-shared-nProfraws.test)</span>:<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:36.0pt">libhi.so -> will dump into libhi.so.profraw<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:36.0pt">libhello.so -> will dump into libhellp.so.profraw<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:36.0pt">main.out -> will dump into main.out.profraw<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regarding ‘%m or %c: (from <a href="https://clang.llvm.org/docs/SourceBasedCodeCoverage.html">
https://clang.llvm.org/docs/SourceBasedCodeCoverage.html</a>): %m is expands instrumented binary’s signature (and with “%Nm” dumps into poll of N profraws) and %c seems very different from proposed “%n”.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Basically with proposed patch (i.e. using “%n”) one can get one-to-one mapping of Shared Library and generated .profraw.<o:p></o:p></p>
<p class="MsoNormal">This makes backtracking and instrumenting final-binary based on feedback easy.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please let me know in case of further queries or any changes in proposed patch.<o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-IN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-IN">Thank you.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-IN">-Hiral<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="mso-fareast-language:EN-IN">From:</span></b><span lang="EN-US" style="mso-fareast-language:EN-IN"> cfe-dev <cfe-dev-bounces@lists.llvm.org>
<b>On Behalf Of </b>Oza, Hiral via cfe-dev<br>
<b>Sent:</b> Wednesday, 22 September, 2021 18:56<br>
<b>To:</b> cfe-dev@lists.llvm.org; llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Subject:</b> [cfe-dev] compiler-rt RFE to support creating profraw for each Shared Library<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0" align="left" width="200" style="width:150.0pt;background:#0067C5">
<tbody>
<tr>
<td nowrap="" style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" style="mso-element:frame;mso-element-frame-hspace:2.25pt;mso-element-wrap:around;mso-element-anchor-vertical:paragraph;mso-element-anchor-horizontal:column;mso-height-rule:exactly">
<b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:yellow;mso-fareast-language:EN-IN">NetApp Security WARNING</span></b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:yellow;mso-fareast-language:EN-IN">: This is an external
email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
</span><span style="mso-fareast-language:EN-IN"><o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="color:black;mso-fareast-language:EN-IN"><br>
<br>
</span><span style="mso-fareast-language:EN-IN"><o:p></o:p></span></p>
<div>
<p class="MsoNormal">Greetings!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review our patch compiler-rt RFE patch here -- <a href="https://reviews.llvm.org/D110232">
https://reviews.llvm.org/D110232</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This patch is about creating profraw for each Shared Library.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><patch_info><o:p></o:p></p>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">SBCC RFE: Support SBCC for Shared Library<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">SBCC RFE: Support SBCC for Shared Library<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Using '%n' format parameter for profile name templates, to insert the full<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">path of the current shared object into profile file names.<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Internally using a linked list to gather all profile dumping functions<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">(there is one defined in each shared object) so they can be invoked with a<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">single function call. Ensure the resulting directory paths are created<o:p></o:p></span></pre>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">prior to dumping.<o:p></o:p></span></pre>
<p class="MsoNormal"></patch_info><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you in advance for your kind review.<o:p></o:p></p>
<p class="MsoNormal">-Hiral<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>