<div dir="ltr">+1, for the blame list.<br><div><br></div><div>BTW. "<span class="gmail-il">Unexpected</span> <span class="gmail-il">PDB</span>" is some kind of infrequent windows bot flakiness (or pre-existing bug in the linker) and can be resolved by clean build. This is not caused by the patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 13 Jul 2021 at 23:29, David Blaikie via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I'd certainly +1 that, if it's possible.<br>
<br>
On Tue, Jul 13, 2021 at 11:11 PM Dmitry Vyukov via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> I noticed for the following notification I was the only person in CC.<br>
> But the commit was updated and committed by another person. I am an<br>
> author of the commit, but committer is different.<br>
> I think it may be useful to include committers into the blame list as<br>
> well. What do you think?<br>
><br>
><br>
> On Wed, 14 Jul 2021 at 08:01, <<a href="mailto:llvm.buildmaster@lab.llvm.org" target="_blank">llvm.buildmaster@lab.llvm.org</a>> wrote:<br>
> ><br>
> > The Buildbot has detected a failed build on builder sanitizer-windows while building compiler-rt.<br>
> ><br>
> > Full details are available at:<br>
> > <a href="https://lab.llvm.org/buildbot#builders/127/builds/13871" rel="noreferrer" target="_blank">https://lab.llvm.org/buildbot#builders/127/builds/13871</a><br>
> ><br>
> > Worker for this Build: sanitizer-windows<br>
> > Blamelist:<br>
> > Dmitry Vyukov <<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>><br>
> ><br>
> > BUILD FAILED: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py ...'<br>
> ><br>
> > Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py ...'<br>
> > python ../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py --jobs=16<br>
> > in dir C:\b\slave\sanitizer-windows\build (timeout 1200 secs)<br>
> > watching logfiles {}<br>
> > argv: ['python', '../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py', '--jobs=16']<br>
> > environment:<br>
> > ALLUSERSPROFILE=C:\ProgramData<br>
> > APPDATA=C:\Users\buildbot\AppData\Roaming<br>
> > BUILDBOT_BLAMELIST=[]<br>
> > BUILDBOT_BRANCH=main<br>
> > BUILDBOT_BUILDERNAME=sanitizer-windows<br>
> > BUILDBOT_BUILDNUMBER=13871<br>
> > BUILDBOT_CLOBBER=<br>
> > BUILDBOT_GOT_REVISION=dfd9808b6cea59ff075498ee7e6e57f2b5b3a798<br>
> > BUILDBOT_REVISION=dfd9808b6cea59ff075498ee7e6e57f2b5b3a798<br>
> > BUILDBOT_SCHEDULER=main:clang,compiler-rt,lld,llvm<br>
> > CLINK_DIR=C:\Program Files (x86)\clink\0.4.8<br>
> > COMMONPROGRAMFILES=C:\Program Files (x86)\Common Files<br>
> > COMMONPROGRAMFILES(X86)=C:\Program Files (x86)\Common Files<br>
> > COMMONPROGRAMW6432=C:\Program Files\Common Files<br>
> > COMPUTERNAME=WINDOWS-ASAN3<br>
> > COMSPEC=C:\windows\system32\cmd.exe<br>
> > FP_NO_HOST_CHECK=NO<br>
> > LOCALAPPDATA=C:\Users\buildbot\AppData\Local<br>
> > NUMBER_OF_PROCESSORS=16<br>
> > OS=Windows_NT<br>
> > PATH=C:\Program Files\CMake\bin\;C:\Python39\;C:\Python39\Scripts;C:\windows\system32;C:\windows;C:\windows\System32\Wbem;C:\windows\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files\Google\Compute Engine\sysprep\;C:\Program Files\Google\Compute Engine\metadata_scripts\;C:\Program Files\TortoiseSVN\bin;C:\gnuwin32\bin;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files\Git\cmd<br>
> > PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC<br>
> > PROCESSOR_ARCHITECTURE=x86<br>
> > PROCESSOR_ARCHITEW6432=AMD64<br>
> > PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 63 Stepping 0, GenuineIntel<br>
> > PROCESSOR_LEVEL=6<br>
> > PROCESSOR_REVISION=3f00<br>
> > PROGRAMDATA=C:\ProgramData<br>
> > PROGRAMFILES=C:\Program Files (x86)<br>
> > PROGRAMFILES(X86)=C:\Program Files (x86)<br>
> > PROGRAMW6432=C:\Program Files<br>
> > PSMODULEPATH=%ProgramFiles(x86)%\WindowsPowerShell\Modules;C:\windows\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\platform\GoogleCloudPowerShell<br>
> > PUBLIC=C:\Users\Public<br>
> > PWD=C:\b\slave\sanitizer-windows\build<br>
> > SYSTEMDRIVE=C:<br>
> > SYSTEMROOT=C:\windows<br>
> > TEMP=C:\Users\buildbot\AppData\Local\Temp<br>
> > TERM=dumb<br>
> > TMP=C:\Users\buildbot\AppData\Local\Temp<br>
> > USERDOMAIN=WINDOWS-ASAN3<br>
> > USERNAME=buildbot<br>
> > USERPROFILE=C:\Users\buildbot<br>
> > VS140COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\<br>
> > WINDIR=C:\windows<br>
> > using PTY: False<br>
> > Step 8 (stage 1 check) failure: stage 1 check (failure)<br>
> > ...<br>
> > [110/114] Running Fuzzer unit tests<br>
> > -- Testing: 55 tests, 16 workers --<br>
> > Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..<br>
> ><br>
> > Testing Time: 0.45s<br>
> > Passed: 55<br>
> > [111/114] Running the AddressSanitizer tests with dynamic runtime<br>
> > llvm-lit.py: C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\<a href="http://lit.cfg.py:139" rel="noreferrer" target="_blank">lit.cfg.py:139</a>: warning: %shared_libasan substitution not set but dynamic ASan is available.<br>
> > -- Testing: 634 tests, 16 workers --<br>
> > Testing: 0.. 10.. 20.<br>
> > FAIL: AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/recalloc_sanity.cpp (34 of 634)<br>
> > ******************** TEST 'AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/recalloc_sanity.cpp' FAILED ********************<br>
> > Script:<br>
> > --<br>
> > : 'RUN: at line 1'; C:/b/slave/sanitizer-windows/build/stage1/./bin/clang-cl.exe -fsanitize=address -Wno-deprecated-declarations -WX -D_HAS_EXCEPTIONS=0 -Zi -MD C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe<br>
> > : 'RUN: at line 2'; C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe 2>&1 | FileCheck C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp<br>
> > : 'RUN: at line 3'; C:/b/slave/sanitizer-windows/build/stage1/./bin/clang-cl.exe -Wno-deprecated-declarations -WX -D_HAS_EXCEPTIONS=0 -Zi C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe<br>
> > : 'RUN: at line 4'; C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe 2>&1 | FileCheck C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp<br>
> > --<br>
> > Exit Code: 1318<br>
> ><br>
> > Command Output (stdout):<br>
> > --<br>
> > $ ":" "RUN: at line 1"<br>
> > $ "C:/b/slave/sanitizer-windows/build/stage1/./bin/clang-cl.exe" "-fsanitize=address" "-Wno-deprecated-declarations" "-WX" "-D_HAS_EXCEPTIONS=0" "-Zi" "-MD" "C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp" "-o" "C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe"<br>
> > # command output:<br>
> > LINK : fatal error LNK1318: Unexpected PDB error; FORMAT (11) ''<br>
> ><br>
> ><br>
> > # command stderr:<br>
> > clang-cl: error: linker command failed with exit code 1318 (use -v to see invocation)<br>
> ><br>
> ><br>
> > error: command failed with exit status: 1318<br>
> ><br>
> > --<br>
> ><br>
> > ********************<br>
> > Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..<br>
> > ********************<br>
> > Failed Tests (1):<br>
> > AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/recalloc_sanity.cpp<br>
> ><br>
> ><br>
> > Testing Time: 68.84s<br>
> > Unsupported : 231<br>
> > Passed : 384<br>
> > Expectedly Failed: 18<br>
> > Failed : 1<br>
> ><br>
> > Sincerely,<br>
> > LLVM Buildbot<br>
> ><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>