<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Adrian,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I'm not opposed to adding something like this into the llvm-reduce (ReduceMetadata) utility, and I think it will be a better way.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<a id="OWAAM393350" class="_1OtrSZdhKXVv3UhaivrdJ4 mention ms-bgc-nlr ms-fcl-b" href="mailto:jeremy.morse@sony.com">@Jeremy Morse</a> has mentioned that someone from SONY is working on something like this -- I am happy with that and I just want to avoid redundant
work.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Djordje</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Adrian Prantl <aprantl@apple.com><br>
<b>Sent:</b> Friday, June 4, 2021 7:42 PM<br>
<b>To:</b> Djordje Todorovic <Djordje.Todorovic@syrmia.com><br>
<b>Cc:</b> llvm-dev@lists.llvm.org <llvm-dev@lists.llvm.org>; Jeremy Morse <jeremy.morse@sony.com>; Petar Jovanovic <petar.jovanovic@syrmia.com>; asowda@cisco.com <asowda@cisco.com>; ibaev@cisco.com <ibaev@cisco.com><br>
<b>Subject:</b> Re: RFC: Reducing metadata in LLVM tests</font>
<div> </div>
</div>
<div class="" style="word-wrap:break-word; line-break:after-white-space">
<div class="">Hi Djordje,</div>
<div class=""><br class="">
</div>
I think something like this would be super useful. Can you explain how it differs from the metadata reduction in bugpoint and to what degree the two share (or could share) code?
<div class=""><br class="">
</div>
<div class="">-- adrian<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Jun 4, 2021, at 7:06 AM, Djordje Todorovic <<a href="mailto:djordje.todorovic@syrmia.com" class="">djordje.todorovic@syrmia.com</a>> wrote:</div>
<br class="x_Apple-interchange-newline">
<div class="">
<div class="" style="font-style:normal; font-variant-caps:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt">
Hi,</div>
<div class="" style="font-style:normal; font-variant-caps:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt">
<br class="">
</div>
<div class="" style="font-style:normal; font-variant-caps:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt">
We are seeing that the LLVM test suite grows every day, so there is always a need for reducing the new tests as well as the old ones. There are tools designed to do that, e.g. [0] and [1]. When an IR (or MIR) test contains Debug Info, the LLVM DI Metadata makes
the test obviously longer. Not all of these metadata are always necessary for the test, so reviewers frequently ask patch submitters for a reduced test case in terms of DI Metadata by recommending some tricks described in [2]. The [2] is just a small proposal
for a utility tool that will save us some time (when fully implemented) during making the patches as well as when doing code reviews -- any thoughts on this?
<div class=""><br class="">
</div>
<div class="">[0]<span class="x_Apple-converted-space"> </span><a href="https://llvm.org/docs/CommandGuide/bugpoint.html" class="">https://llvm.org/docs/CommandGuide/bugpoint.html</a></div>
<div class="">[1]<span class="x_Apple-converted-space"> </span><a href="https://blog.regehr.org/archives/2109" class="">https://blog.regehr.org/archives/2109</a></div>
<div class="">[2]<span class="x_Apple-converted-space"> </span><a href="https://github.com/djolertrk/llvm-metadataburn" class="">https://github.com/djolertrk/llvm-metadataburn</a></div>
<div class=""><br class="">
</div>
<div class="">Best regards,</div>
Djordje</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</body>
</html>