<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 10, 2021 at 4:58 AM Manuel Klimek <<a href="mailto:klimek@google.com">klimek@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>I think any user with admin access and LLVM github access can go into phab's "Auth" app, and edit the github auth provider with a new App ID and secret, right?</div></div></blockquote><div><br></div><div>Yes, but that would require everyone to re-authorize the new application on GitHub, while if you transfer the application on GitHub side, it'll become part of the LLVM organization with the existing token and (I think) it will "keep the lights on".</div><div><br></div><div>-- </div><div>Mehdi</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 8, 2021 at 5:36 AM Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On 5/7/21 6:01 PM, Mehdi AMINI wrote:<br>
> <br>
> <br>
> On Fri, May 7, 2021 at 3:29 PM Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a> <mailto:<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>>> wrote:<br>
> <br>
> On 5/7/21 8:56 AM, Mehdi AMINI wrote:<br>
> ><br>
> ><br>
> > On Fri, May 7, 2021 at 8:45 AM Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a> <mailto:<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>> <mailto:<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a> <mailto:<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>>>> wrote:<br>
> ><br>
> > On 5/6/21 8:37 PM, Mehdi AMINI wrote:<br>
> > > Hi,<br>
> > ><br>
> > > GitHub allows to "transfer ownership" for such applications, we should likely transfer this to the LLVM account ideally. I don't know who can coordinate this with Manuel, maybe Tom or Mike?<br>
> > ><br>
> ><br>
> > Is phabricator actually using r4nt's github account or is<br>
> > r4nt just part of the description of our phabricator instance?<br>
> ><br>
> ><br>
> > The oAuth application is owned by r4nt's GitHub account I believe: <a href="https://docs.github.com/en/developers/apps/authorizing-oauth-apps" rel="noreferrer" target="_blank">https://docs.github.com/en/developers/apps/authorizing-oauth-apps</a> <<a href="https://docs.github.com/en/developers/apps/authorizing-oauth-apps" rel="noreferrer" target="_blank">https://docs.github.com/en/developers/apps/authorizing-oauth-apps</a>> <<a href="https://docs.github.com/en/developers/apps/authorizing-oauth-apps" rel="noreferrer" target="_blank">https://docs.github.com/en/developers/apps/authorizing-oauth-apps</a> <<a href="https://docs.github.com/en/developers/apps/authorizing-oauth-apps" rel="noreferrer" target="_blank">https://docs.github.com/en/developers/apps/authorizing-oauth-apps</a>>><br>
> ><br>
> > Phab does not reference r4nt, it just has the token for the oAuth application. When a user wants to login on Phab for the first time, they are redirected to GitHub itself to "grant permission" to r4nt to log them in on Phab (this is the message in the original email in this thread).<br>
> ><br>
> <br>
> OK, that make sense. Where is the OAuth app phabricator is using?<br>
> Is it on GitHub somewhere? I don't see anything in r4nt's repositories<br>
> that looks like an OAuth app.<br>
> <br>
> <br>
> This isn't public like a repo, each user can manage their own in <a href="https://github.com/settings/developers" rel="noreferrer" target="_blank">https://github.com/settings/developers</a> <<a href="https://github.com/settings/developers" rel="noreferrer" target="_blank">https://github.com/settings/developers</a>><br>
> <br>
<br>
Ok, I'll try to coordinate this with Manuel.<br>
<br>
-Tom<br>
<br>
> -- <br>
> Mehdi<br>
> <br>
> <br>
> <br>
> -Tom<br>
> <br>
> > --<br>
> > Mehdi<br>
> ><br>
> ><br>
> > -Tom<br>
> ><br>
> > > --<br>
> > > Mehdi<br>
> > ><br>
> > ><br>
> > > On Thu, May 6, 2021 at 7:39 PM Geoffrey Martin-Noble via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>>>> wrote:<br>
> > ><br>
> > > r4nt is the github username of +Manuel Klimek <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a> <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>> <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a> <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>>>>, who I'm guessing set up the integration<br>
> > ><br>
> > > On Thu, May 6, 2021 at 7:12 PM Jon Chesterfield via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>>>> wrote:<br>
> > ><br>
> > > A colleague just went to sign up to llvm reviews using a github account. From https:/<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">reviews.llvm.org/login/?next=</a> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a>> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a>>> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a>> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a> <<a href="http://reviews.llvm.org/login/?next=" rel="noreferrer" target="_blank">http://reviews.llvm.org/login/?next=</a>>>> which looks normal, goes to a page saying:<br>
> > ><br>
> > > Authorize LLVM Reviews<br>
> > > LLVM Reviews by r4nt<br>
> > > wants to access your $username account<br>
> > ><br>
> > > Green button saying `Authorize r4nt`<br>
> > ><br>
> > > So, who's r4nt, and is this expected behaviour?<br>
> > ><br>
> > > Cheers<br>
> > > _______________________________________________<br>
> > > LLVM Developers mailing list<br>
> > > <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>>><br>
> > > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>>> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>>>><br>
> > ><br>
> > > _______________________________________________<br>
> > > LLVM Developers mailing list<br>
> > > <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>>><br>
> > > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>>> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a> <<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>>>><br>
> > ><br>
> ><br>
> <br>
<br>
</blockquote></div></div>
</blockquote></div></div>