<div dir="ltr">That is fine with me if you want to make that change.<br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><br></div><div>-- Caroline<br><a href="mailto:cmtice@google.com" target="_blank">cmtice@google.com</a><br></div></div></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 29, 2021 at 3:30 AM Djordje Todorovic <<a href="mailto:Djordje.Todorovic@syrmia.com">Djordje.Todorovic@syrmia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Hi Caroline,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Thanks for your response.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="margin:0px;font-size:15px;background-color:rgb(255,255,255)">>When I wrote D58849 I wasn't sure if all
the inlined functions would have abstract origins or not; that was one of the things I wanted to check on.</span><br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="margin:0px;font-size:15px;background-color:rgb(255,255,255)"><br>
</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="margin:0px;font-size:15px;background-color:rgb(255,255,255)">OK, as Paul mentioned in the previous mail,
it might be better if we calculated the <span style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:16px;background-color:rgb(255,255,255);display:inline">
"#inlined functions without abstract origin"</span>.</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="margin:0px;font-size:15px;background-color:rgb(255,255,255)"><br>
</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="margin:0px;font-size:15px;background-color:rgb(255,255,255)">Thanks,</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="margin:0px;font-size:15px;background-color:rgb(255,255,255)">Djordje</span></div>
<div id="gmail-m_5805687468063181267appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_5805687468063181267divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Caroline Tice <<a href="mailto:cmtice@google.com" target="_blank">cmtice@google.com</a>><br>
<b>Sent:</b> Wednesday, April 28, 2021 6:36 PM<br>
<b>To:</b> Djordje Todorovic <<a href="mailto:Djordje.Todorovic@syrmia.com" target="_blank">Djordje.Todorovic@syrmia.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>; <a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a> <<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>>; <a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a> <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>>; <a href="mailto:asowda@cisco.com" target="_blank">asowda@cisco.com</a> <<a href="mailto:asowda@cisco.com" target="_blank">asowda@cisco.com</a>><br>
<b>Subject:</b> Re: [llvm-dev] llvm-dwarfdump stats for inlined functions</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div dir="ltr"><br clear="all">
<div>
<div dir="ltr">
<div dir="ltr">
<div>
<div dir="ltr">
<div><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div>
<div dir="ltr">On Wed, Apr 28, 2021 at 4:11 AM Djordje Todorovic <<a href="mailto:Djordje.Todorovic@syrmia.com" target="_blank">Djordje.Todorovic@syrmia.com</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>Hi,<u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span><u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>As discussed on the <a href="https://reviews.llvm.org/D101025" target="_blank">
https://reviews.llvm.org/D101025</a>, we have noticed that there are two different stat categories for inlined functions when using `llvm-dwarfdump –statistics`:<u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif;text-indent:0.5in">
<span># inlined functions<u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif;text-indent:0.5in">
<span># inlined functions with abstract origin<u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>and it was introduced after the </span><b><span lang="EN-GB" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:rgb(70,76,92);background:rgb(236,238,244)">D58849</span>.
</b><span>We were wondering if there is a particular motivation of doing so.</span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span><u></u> </span></p>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>When I wrote D58849 I wasn't sure if all the inlined functions would have abstract origins or not; that was one of the things I wanted to check on.</div>
<div><br>
</div>
<div>-- Caroline</div>
<div><a href="mailto:cmtice@google.com" target="_blank">cmtice@google.com</a></div>
<div> </div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span><u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>Having an inlined_subroutine DIE with no abstract_origin attribute does not have so many benefits, so it might be better if we have an assertion/error (e.g., in the AsmPrinter) when we face such situation (or just to avoid dumping it into the final DWARF).</span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span><u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>Any thoughts?<u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span><u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>Best regards,<u></u> <u></u></span></p>
<p style="margin:0in 0in 8pt;line-height:107%;font-size:11pt;font-family:Calibri,sans-serif">
<span>Djordje<u></u> <u></u></span></p>
<br>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div>