<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>JFYI, our copy of phabricator carries a bunch of custom patches
for email integration. It's an area we put a lot of effort into
in the past. The case I pointed to below just happens to be one
in the long tail where that integration didn't catch the response.</p>
<p>Philip<br>
</p>
<div class="moz-cite-prefix">On 4/23/21 8:22 AM, Christian Kühnel
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAOP=PUtHy-R=NE9EJnQqPPJ0bVGFcB-=peitsVDAQ4WOfLcTCQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">Thx Philip,
<div><br>
</div>
<div>for sharing this. That helped me better understand how
people are interacting with the mailing lists!</div>
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p>It's not uncommon to have email responses to phab
emails that don't make it into the web interface. A
recent example is D99976.</p>
</div>
</blockquote>
<div>
<div dir="ltr">
<div>I missed those when scanning the lists! I was looking
for a code review that *started* on the mailing list,
but that assumption was wrong. </div>
<div><br>
</div>
<div>So it looks like the information we have on the
mailing list and in Phabricator is diverging, as those
emails do not get parsed back into Phabricator. Which is
unfortunate as folks not following the llvm-commits
mailing lists (like me) will then not see discussions
happening there.</div>
<div><br>
</div>
<div>However I do understand that it's sometimes more
convenient to reply via email client than via
Phabricator. It looks like Phabricator would actually <a
href="https://secure.phabricator.com/book/phabricator/article/configuring_inbound_email/"
moz-do-not-send="true">support this</a>. Not sure how
difficult it would be to set that up.</div>
</div>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p>There's also a bunch of post commit discussion which
happens entirely in email. Check any of the commit
threads with responses in the last week. There are
many.</p>
</div>
</blockquote>
<div>Same here: I missed the replies to commit messages.
Here's one <a
href="https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20210419/906894.html"
moz-do-not-send="true">example</a> in case someone else is
interested.</div>
<div><br>
</div>
<div>Discussions about commits could also happen on
Phabricator. You can also reply to commits there, e.g. <a
href="https://reviews.llvm.org/rG2f67267a93c87261414a4aa4c6cb9d20a489a0df"
moz-do-not-send="true">https://reviews.llvm.org/rG2f67267a93c87261414a4aa4c6cb9d20a489a0df</a>
But again I understand it is more convenient to do that via
an email client.</div>
<div><br>
</div>
<div>My conclusions:</div>
<div>
<ol>
<li>Code reviews don't usually <b style="">*start*</b> on
the mailing list.</li>
<li>Folks do use the mailing lists to reply to commit and
review emails, so we still need those. </li>
<li>For the future we might want to look into parsing
these replies back into Phabricator to get a consistent
view there. Not sure how hard that would be to set up.</li>
</ol>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Best,</div>
<div>Christian</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<blockquote type="cite"> </blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
</body>
</html>