<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>If you want to propose this, please move it to a top level thread
for visibility. <br>
</p>
<p>(My thoughts inline to help you refine your proposal.)<br>
</p>
<div class="moz-cite-prefix">On 4/23/21 9:55 AM, Krzysztof Parzyszek
via llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:DM5PR02MB26031EA32745838AF2A56BDBDD459@DM5PR02MB2603.namprd02.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}div.WordSection1
{page:WordSection1;}ol
{margin-bottom:0in;}ul
{margin-bottom:0in;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">I think we should phase-out email reviews
in favor of doing it directly via Phabricator.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">My reasons:<o:p></o:p></p>
<ol style="margin-top:0in" type="1" start="1">
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1">Phabricator
allows for both pre- and post-commit reviews. You can
“raise concern” with any commit, including those that did
not have a pre-commit review on phab.<o:p></o:p></li>
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1">The
email-phabricator integration is still deficient despite a
lot of effort having been put into it. Moreover, it’s not
likely that it will ever be fully functional.<o:p></o:p></li>
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1">Email
communication is “fragile”. This one is based more on my
personal experience, but even simply following a discussion
on llvm-dev has been difficult. I now have to use Outlook
(corporate reasons…) and Outlook fails at keeping email
threads together. Replies to the same tread are scattered
into a mini-forest instead staying as a single tree. There
are issues with every email client formatting the replies
differently: top-post mixed with bottom-post mixed with
inline text, with people quoting 500 lines of text only to
insert a single-line response, and so on, and so forth.
Some of it is due to my use of Outlook, some of it is
independent from it. This “infinite flexibility” of email
structure is the reason why I doubt that the Phabricator
integration will ever work.</li>
</ol>
</div>
</blockquote>
Phabricator is also fragile unfortunately. I find phabricators
inline discussions to be very hard to follow for anything which
becomes involved. As such, I tend to default to phab, but quickly
move to email if discussion gets complicated.<br>
<blockquote type="cite"
cite="mid:DM5PR02MB26031EA32745838AF2A56BDBDD459@DM5PR02MB2603.namprd02.prod.outlook.com">
<div class="WordSection1"><br>
<ol style="margin-top:0in" type="1" start="1">
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1">Phabricator’s
interface makes every review look the same, is readable, and
doesn’t make it easy to unintentionally clutter it with
junk.<o:p></o:p></li>
</ol>
</div>
</blockquote>
<p>As someone with vision restrictions, please be careful about this
line of argument. One of the major advantages of email is that I
can use my own client at whatever zoom/scale I want. Phab "sorta
works" from an accessibility perspective, but frankly is inferior
to plain old email. I frequently end up reading phabricator
emails, and then replying through the web interface. <br>
</p>
<p>I'm just point this out because I find that visual appear is
often rated much more highly by some folks than others.
Personally, functionality is pretty much the only thing I care
about. </p>
<blockquote type="cite"
cite="mid:DM5PR02MB26031EA32745838AF2A56BDBDD459@DM5PR02MB2603.namprd02.prod.outlook.com">
<div class="WordSection1">
<ol style="margin-top:0in" type="1" start="1">
<ol style="margin-top:0in" type="a" start="1">
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level2 lfo1">Finally,
it seems like nowadays it’s easier to create a Phabricator
account than to sign up to the mailing lists…<o:p></o:p></li>
</ol>
</ol>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span
style="font-size:9.0pt;font-family:Consolas">-- </span>
<span style="font-size:9.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:8.0pt;font-family:Consolas">Krzysztof
Parzyszek
<a href="mailto:kparzysz@quicinc.com" moz-do-not-send="true"><span
style="color:#0563C1">kparzysz@quicinc.com</span></a>
AI tools development<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> llvm-dev
<a class="moz-txt-link-rfc2396E" href="mailto:llvm-dev-bounces@lists.llvm.org"><llvm-dev-bounces@lists.llvm.org></a> <b>On Behalf Of
</b>Mehdi AMINI via llvm-dev<br>
<b>Sent:</b> Friday, April 23, 2021 11:01 AM<br>
<b>To:</b> Hubert Tong
<a class="moz-txt-link-rfc2396E" href="mailto:hubert.reinterpretcast@gmail.com"><hubert.reinterpretcast@gmail.com></a><br>
<b>Cc:</b> llvm-dev <a class="moz-txt-link-rfc2396E" href="mailto:llvm-dev@lists.llvm.org"><llvm-dev@lists.llvm.org></a><br>
<b>Subject:</b> [EXT] Re: [llvm-dev] Anyone doing code
reviews via mailing lists?<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Fri, Apr 23, 2021 at 8:57 AM
Hubert Tong via llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC
1.0pt;padding:0in 0in 0in
6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div>
<p class="MsoNormal">On Fri, Apr 23, 2021 at 11:25
AM Christian Kühnel via llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid
#CCCCCC 1.0pt;padding:0in 0in 0in
6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal">So it looks like the
information we have on the mailing list
and in Phabricator is diverging, as
those emails do not get parsed back into
Phabricator.<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I recall noticing that
Phabricator also doesn't emit inline code change
suggestions into the e-mail record.<o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Yes: which is an indication that not
all the content is on the mailing-list either :(<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-- <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Mehdi<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC
1.0pt;padding:0in 0in 0in
6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>