<div dir="ltr"><div>When would you recommend a user should use this flag as proposed? Anytime they moved code from icc? Or after they encounter an exception, should they use this flag to get rid of the exception rather than using tools like ubsan to find the bug in their code? Where would we document recommendations so that users know the tradeoffs and risks?</div><div><br></div><div>Your patch is only doing this for AVX and not SSE because folding loads requires alignment with SSE, but not AVX. So users that need to support non-AVX CPUs have to fix their bugs and can't sweep them away with this flag.</div><div><br></div><div>I'm somewhat ok with unconditionally using unaligned instructions on AVX because then there is no command line option to explain to users. But then there's probably a group of people out there that want the alignment check.</div><div><br></div><div><div dir="ltr" data-smartmail="gmail_signature">~Craig</div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 14, 2021 at 11:58 AM James Y Knight via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This is not a principled change -- it avoids a problem arising from <i>one</i> use of alignment information, but there are other uses of alignment in LLVM, and those will still cause problems, potentially less clearly. So, I think that this will not be a useful option to provide to users, in this form.<div><br></div><div>What I suspect you <i>actually</i> want here is an option to tell Clang not to infer load/store alignments based on object types or alignment attributes -- instead treating everything as being potentially aligned to 1 unless the allocation is seen (e.g. global/local variables). Clang would still need to use the usual alignment computation for variable definitions and structure layout, but not memory operations. If clang emits "load ... align 1" instructions in LLVM IR, the right thing would then happen in the X86 backend automatically.</div><div><br></div><div>My initial inclination is that this feature is also not particularly worthwhile to implement, but I'm open to being convinced that this is indeed valuable enough to be worthwhile. It should actually work reliably, and is somewhat in line with other such "not-quite-C" flags we provide (e.g. -fno-delete-null-pointer-checks). Of course, even with such an implementation, you can still have a problem with user code depending on alignof() returning a reliable answer (e.g., llvm::PointerUnion). Not much can be done about that.</div><div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 14, 2021 at 2:07 PM Liu, Chen3 via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p class="MsoNormal">Hi all.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">We want to make a patch to always emit unaligned vector move instructions on AVX machine with option control. We do this for the following reason:<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<ol style="margin-top:0in" start="1" type="1">
<li style="margin-left:0in;text-align:justify">
With AVX the performance for aligned vector move and unaligned vector move on X86 are the same if the address is aligned. In this case we prefer to use unaligned move because it can avoid some run time exceptions;<u></u><u></u></li><li style="margin-left:0in;text-align:justify">
This fixes an inconsistency in optimization: suppose a load operation was merged into another instruction (e.g., load and add becomes `add [memop]'). If a misaligned pointer is passed to the two-instruction sequence, it will<u></u><u></u></li></ol>
<p style="text-align:justify">
raise an exception. If the same pointer is passed to the memop instruction, it will work. Thus, the behavior of misalignment depends upon what optimization levels and passes are applied, and small source changes could cause<u></u><u></u></p>
<p style="text-align:justify">
issues to appear and disappear. It's better for the user to consistently use unaligned load/store to improve the debug experience;<u></u><u></u></p>
<ol style="margin-top:0in" start="3" type="1">
<li style="margin-top:0in;margin-bottom:0in;text-align:justify;line-height:20.4pt;background:white">
<span style="color:black">Makes good use of HW that is capable of handling misaligned data gracefully. It is not necessarily a bug in users code but a third-part library. For example it would allow using a library built in old ages where stack alignment was
4-byte only.</span><u></u><u></u></li><li style="margin-left:0in;text-align:justify">
Compatible with ICC so that users can easily use llvm;<u></u><u></u></li></ol>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Roman Lebedev is worried that this patch will hide UB. In our opinions, UB doesn't have to mean raise an exception. The example code(<a href="https://godbolt.org/z/43bYPraoa" target="_blank">https://godbolt.org/z/43bYPraoa</a>) does have UB behavior but
it is still valid (and reasonable) to interpret that UB as `go slower',<u></u><u></u></p>
<p class="MsoNormal">instead of `raise exception'. Besides, as default we still emit aligned instructions as before, but we provide an option for users with this need.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">We have two patches discussing this issue, one of which has been abandoned:<u></u><u></u></p>
<p class="MsoNormal"><a href="https://reviews.llvm.org/D88396" target="_blank">https://reviews.llvm.org/D88396</a> (abandoned)<u></u><u></u></p>
<p class="MsoNormal"><a href="https://reviews.llvm.org/D99565" target="_blank">https://reviews.llvm.org/D99565</a> (in review)<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks.<u></u><u></u></p>
<p class="MsoNormal">Chen Liu.<u></u><u></u></p>
</div>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>