<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">It would be nice to see this in 12.x, but not critical. That said, the patch looks straightforward enough to go in without a problem, so it’s up to the code owners/release manager.<o:p></o:p></p>
<p class="MsoNormal">--paulr<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Arthur Eubanks <aeubanks@google.com> <br>
<b>Sent:</b> Wednesday, February 3, 2021 4:15 PM<br>
<b>To:</b> llvm-dev <llvm-dev@lists.llvm.org>; Robinson, Paul <paul.robinson@sony.com>; tstellar@redhat.com<br>
<b>Subject:</b> Re: [llvm-dev] HelloWorldPass ?<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Removed the extra library in <a href="https://urldefense.com/v3/__https:/reviews.llvm.org/D95907__;!!JmoZiZGBv3RvKRSx!uzEZL6NwE-0FvPPfgLcNXU9WEUMH8UbNeY-w_q7jmVJrt3RRzq1IK44fmr5MhTXxgA$">https://reviews.llvm.org/D95907</a>. Should it be
cherry-picked into 12.x?<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Feb 2, 2021 at 3:10 PM <<a href="mailto:Yuanfang.Chen@sony.com">Yuanfang.Chen@sony.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">> In hindsight, perhaps adding it to llvm/lib/Transforms/Scalar would be cleaner and would still properly show how to write an in-tree pass. I can go ahead and do that if you'd like.<br>
<br>
Agreed.<br>
<br>
________________________________________<br>
From: llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>> on behalf of Arthur Eubanks via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
Sent: Tuesday, February 2, 2021 2:41 PM<br>
To: <a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a><br>
Cc: llvm-dev<br>
Subject: Re: [llvm-dev] HelloWorldPass ?<br>
<br>
This was added in <a href="https://urldefense.com/v3/__https:/reviews.llvm.org/D86979__;!!JmoZiZGBv3RvKRSx!uzEZL6NwE-0FvPPfgLcNXU9WEUMH8UbNeY-w_q7jmVJrt3RRzq1IK44fmr71s9D4JA$" target="_blank">
https://reviews.llvm.org/D86979</a><<a href="https://urldefense.com/v3/__https:/reviews.llvm.org/D86979__;!!JmoZiZGBv3RvKRSx!uvevl9WxJWZajB0Ry7OvTsTpBbInzuVMLFel-NpaLf8cgfknTp5mrDkGD7s-BlN6ng$" target="_blank">https://urldefense.com/v3/__https://reviews.llvm.org/D86979__;!!JmoZiZGBv3RvKRSx!uvevl9WxJWZajB0Ry7OvTsTpBbInzuVMLFel-NpaLf8cgfknTp5mrDkGD7s-BlN6ng$</a>>.
My goal was to show how to write an in-tree NPM pass. It didn't really fit into any of the existing directories/libraries, so I created a similar one to the legacy HelloWorld example. Since it's unconditionally added to PassRegistry.def, I followed the CMake
from something like llvm/lib/Transforms/Scalar. TBH I'm not super familiar with the various CMake machinery, so any suggestions are welcome.<br>
<br>
In hindsight, perhaps adding it to llvm/lib/Transforms/Scalar would be cleaner and would still properly show how to write an in-tree pass. I can go ahead and do that if you'd like.<br>
<br>
<br>
On Tue, Feb 2, 2021 at 2:32 PM Tom Stellard via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>> wrote:<br>
On 2/2/21 1:32 PM, via llvm-dev wrote:<br>
> My team is packaging up our next release, and this new pass popped<br>
> up. It has its own library and everything (LLVMHelloWorld.lib),<br>
> but it appears to be mandatory when linking against LLVM in general.<br>
> I can see it's an example pass regarding the new pass manager, but<br>
> I can also see the equivalent example for the legacy pass manager<br>
> wasn't mandatory and we don't have it in our package.<br>
><br>
> It seems like kind of a trivial thing to worry about--it's clearly<br>
> harmless and doesn't take up a lot of space--but it's how the thing<br>
> is packaged differently than the old Hello pass that bothers me.<br>
><br>
> - I see it's listed in lib/Passes/Registry.def; the old one wasn't.<br>
><br>
> - I see its CMakeLists.txt uses add_llvm_component_library where the<br>
> old one uses add_llvm_library.<br>
><br>
<br>
Arthur, was the use of add_llvm_component_library() here intentional?<br>
<br>
-Tom<br>
<br>
> I can't say I understand these things but just being different<br>
> raises my eyebrow. Is there a good reason they're different?<br>
> And just for my own curiosity, what's the simplest way to avoid<br>
> needing it in our package?<br>
><br>
> Thanks,<br>
> --paulr<br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
> <a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!uzEZL6NwE-0FvPPfgLcNXU9WEUMH8UbNeY-w_q7jmVJrt3RRzq1IK44fmr6Ny8ZYwA$" target="_blank">
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!uvevl9WxJWZajB0Ry7OvTsTpBbInzuVMLFel-NpaLf8cgfknTp5mrDkGD7v9MrAJRQ$" target="_blank">https://urldefense.com/v3/__https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!uvevl9WxJWZajB0Ry7OvTsTpBbInzuVMLFel-NpaLf8cgfknTp5mrDkGD7v9MrAJRQ$</a>><br>
><br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!uzEZL6NwE-0FvPPfgLcNXU9WEUMH8UbNeY-w_q7jmVJrt3RRzq1IK44fmr6Ny8ZYwA$" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!uvevl9WxJWZajB0Ry7OvTsTpBbInzuVMLFel-NpaLf8cgfknTp5mrDkGD7v9MrAJRQ$" target="_blank">https://urldefense.com/v3/__https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!uvevl9WxJWZajB0Ry7OvTsTpBbInzuVMLFel-NpaLf8cgfknTp5mrDkGD7v9MrAJRQ$</a>><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>