<html>

  <head>

    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

  </head>

  <body>

    <p>I strongly disagree with this proposal.  As in, please do not

      land patches which implement this proposal.  If anything, we

      should remove the build time config flag entirely.  <br>

    </p>

    <p>The new manager is mature and has been in wide use for a long

      time now.  Moving it to a conditional compilation item is a major

      regression in implied maturity and completely unwarranted.  If

      anything, we should just flip the dang flag and make people using

      the old pass manager support it.  (Most downstream groups I know

      of are running NPM.)</p>

    <p>Philip<br>

    </p>

    <div class="moz-cite-prefix">On 12/1/20 12:34 PM, Arthur Eubanks via

      llvm-dev wrote:<br>

    </div>

    <blockquote type="cite"

cite="mid:CAPW48sqF5SHM7XJ4A1Yc8Geb6e9AOT3Qhzp66qoJeGQctZk7rQ@mail.gmail.com">

      <meta http-equiv="content-type" content="text/html; charset=UTF-8">

      <div dir="ltr">

        <div>The ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER CMake flag

          currently only affects Clang. It should probably also change

          all other uses of pass managers where possible.  <br>

        </div>

        <div><br>

        </div>

        <div>There are a couple of uses inside LLD for LTO which already

          have new/legacy PM flags and should probably look at

          ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER to determine the default.

          <a

href="https://github.com/llvm/llvm-project/blob/1314a4938fba865412598b7227cb4657d59cd8bc/lld/wasm/Driver.cpp#L382"

            moz-do-not-send="true">Some</a> <a

href="https://github.com/llvm/llvm-project/blob/1314a4938fba865412598b7227cb4657d59cd8bc/llvm/include/llvm/LTO/Config.h#L53"

            moz-do-not-send="true">examples</a>.</div>

        <div><br>

        </div>

        <div>Also at some point in the future when check-llvm has been

          fixed to work with opt's -enable-new-pm flag by default, that

          should also be dependent upon

          ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER.</div>

        <div><br>

        </div>

        <div>Any objections?</div>

      </div>

      <br>

      <fieldset class="mimeAttachmentHeader"></fieldset>

      <pre class="moz-quote-pre" wrap="">_______________________________________________

LLVM Developers mailing list

<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>

<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>

</pre>

    </blockquote>

  </body>

</html>