<div dir="ltr">Hi,<div><br></div><div>Thank you all for keeping this going. Indeed I was not aware that the discussion was going on, I am really sorry for this late reply.</div><div><br></div><div>I understand Chris' point about metadata design. Either the metadata becomes stale or removed (if we do not teach transformations to preserve it), or we end up modifying many (if not all) transformations to keep the data intact.</div><div>Currently in the IR, I feel like the default behavior is to ignore/remove the metadata, and only a limited number of transformations know how to maintain and update it, which is a best-effort approach.</div><div>That being said, my initial thought was to adopt this approach to the MIR, so that we can at least have a minimal mechanism to communicate additional information to various transformations, or even dump it to the asm/object file.</div><div>In other words, it is the responsibility of the users who introduce/use the metadata in the MIR to teach the transformations they selected how to preserve their metadata. A common API to abstract this would definitely help, just as combineMetadata() from lib/Transforms/Utils/Local.cpp does.</div><div><br></div><div>As for my use case, it is also security-related. However, I do not consider the metadata to be a compilation "correctness" criteria: metadata, by definition (from the LLVM IR), can be safely removed without affecting the program's correctness.</div><div>If possible, I would like to have more details on Lorenzo's use case in order to see how metadata would interfere with program's correctness.</div><div><br></div><div>As for the RFC, I can definitely try to write one, but this would be my first time doing so. But maybe it is better to start with Lorenzo's proposal, as you have already been working on this? Please tell me if you prefer me to start the RFC though.<br></div><div><br></div><div>Thank you again for keeping this going.</div><div><br></div><div>Sincerely,</div><div><br></div><div>- Son</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 4, 2020 at 6:30 PM Lorenzo Casalino <<a href="mailto:lorenzo.casalino93@gmail.com">lorenzo.casalino93@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Le 04/11/20 à 17:40, David Greene a écrit :<br>
> Sorry about the late reply.<br>
><br>
> Lorenzo Casalino <<a href="mailto:lorenzo.casalino93@gmail.com" target="_blank">lorenzo.casalino93@gmail.com</a>> writes:<br>
><br>
>>>>> - Should not impact compile time excessively (what is "excessive?")<br>
>>>> Probably, such estimation should be performed on<br>
>>> Did something get cut off here?<br>
>> Uops. Yep, I removed a paragraph, but, apparentely I forgot the first<br>
>> period. In any case, we should discuss about how to quantitatively<br>
>> determine an acceptable upper-bound on the overhead on the compilation<br>
>> time and give a motivation for it. For instance, max n% overhead on the<br>
>> compilation time must be guaranteed, because ** list of reasons **.<br>
> I am not sure how we'd arrive at such a number or motivate/defend it.<br>
> Do we have any sense of the impact of the existing metadata<br>
> infrastructure? If not I'm not sure we can do it for something<br>
> completely new. I think we can set a goal but we'd have to revise it as<br>
> we gain experience.<br>
I think it is the best approach to employ :)<br>
>>> Since you initially raised the topic, do you want to take the lead in<br>
>>> writing up a RFC? I can certainly do it too but I want to give you<br>
>>> right of first refusal. :)<br>
>>> -David<br>
>> Uhm...actually, it wasn't me but Son Tuan, so the right of refusal<br>
>> should be granted to him :) And I noticed now that he wasn't included in<br>
>> CC of all our mails; I hope he was able to follow our discussion<br>
>> anyways. I am adding him in this mail and let us wait if he has any<br>
>> critical feature or point to discuss.<br>
> Fair enough! I have recently taken on a lot more work so unfortunately<br>
> I can't devote a lot of time to this at the moment. I've got to clear<br>
> out my pipeline first. I'd be very happy to help review text, etc.<br>
Do not worry, it is ok ;) Meanwhile we wait for any feedback/input from Son,<br>
I'll try to prepare a draft of RFC and publish it here.<br>
<br>
Thank you David, and have a nice day :)<br>
<br>
-- Lorenzo<br>
<br>
> -David<br>
</blockquote></div>