<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Nov 5, 2020 at 7:30 AM Mircea Trofin via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">There are currently 1350 owner-less failures in the <a href="https://docs.google.com/spreadsheets/d/1o6q3XH1n3DDyyccnYZ_kVfhFbTDzC_S09e973_cwYuw/edit#gid=0" target="_blank">spreadsheet</a>. These seem to be the larger areas there.<div><br></div><div>If you see an area you have ownership or expertise in, please sign up for fixing the tests by Monday, Nov. 9. </div><div><br></div><div>Otherwise, I will "blanket-add" --allow-unused-prefixes=true to the remaining failing tests.<br></div></div></blockquote><div><br></div><div>If/when you do that, probably worth adding a comment at each site to clarify that this was added automatically, not vetted/intentionally added by a human. Something like "// FIXME: Verify that unused prefixes are used intentionally" or the like.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <<a href="mailto:mtrofin@google.com" target="_blank">mtrofin@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">An update: as of 871d658c9ceb, the flag is now available, if folks need to use it.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <<a href="mailto:mtrofin@google.com" target="_blank">mtrofin@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hello all,<br></div><div><br></div><div>TL;DR; if you used FileCheck --check-prefixes and you missed (misspelled, for instance) one of the prefixes in your test, FileCheck silently ignores that and the test passes. </div><div><br></div><div>1579 tests have this property. </div><div><br></div><div><b><br></b></div><div><b>The details</b></div><div><b>=========</b></div><div>Please refer to <a href="https://reviews.llvm.org/D90281" target="_blank">https://reviews.llvm.org/D90281</a> and the discussion there for more details (make sure you open "older changes" for full context)</div><div><br></div><div>The problem is covered by the TL;DR;. </div><div><br></div><div>The proposal is to add an explicit flag to FileCheck, --allow-unused-prefixes, to indicate whether the current behavior is intended (for instance, jdoerfert contributed a scenario where that is the case). </div><div><br></div><div>We want the default behavior to be 'strict', i.e. --allow-unused-prefixes=false. Doing that right now would lead to 1500 test failures.</div><div><br></div><div>To get there (thanks, maskray, for suggestion), we propose we:</div><div>* land D90281 where the flag is introduced, but is flipped to match today's behavior</div><div>* employ a 'busy beavers' approach, where test maintainers patch their tests:</div><div> - either leveraging the flag, to explicitly indicate that unused prefixes is intended (i.e. add --allow-unused-patches=true); or</div><div> - fix the test (e.g. maybe there was a misspelling issue/omission/etc).</div><div><br></div><div>A spreadsheet with the failing tests is available <a href="https://docs.google.com/spreadsheets/d/1o6q3XH1n3DDyyccnYZ_kVfhFbTDzC_S09e973_cwYuw/edit?usp=sharing" target="_blank">here</a> [1].</div><div><br></div><div>The request to the community members is to please sign up for their respective area in the spreadsheet, and then mark it completed when that's the case (yes/no in the respective column).</div><div><br></div><div>When all the tests are fixed, we will then flip --allow-unused-prefixes to false by default.</div><div><br></div><div>Meanwhile, please consider leveraging the flag explicitly when you author new tests that use --check-prefixes. That can be then cleaned up easily after we switch to the 'strict' behavior.</div><div><br></div><div>Thanks!</div><div><br></div><div>[1] <a href="https://docs.google.com/spreadsheets/d/1o6q3XH1n3DDyyccnYZ_kVfhFbTDzC_S09e973_cwYuw/edit?usp=sharing" target="_blank">https://docs.google.com/spreadsheets/d/1o6q3XH1n3DDyyccnYZ_kVfhFbTDzC_S09e973_cwYuw/edit?usp=sharing</a></div></div>
</blockquote></div>
</blockquote></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>