<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Fantastic, thank you everyone!<div class=""><br class=""></div><div class="">-Chris<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 31, 2020, at 12:40 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Oct 31, 2020 at 12:32 PM Chris Lattner via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class="">I agree with Eric here. There is clearly controversy w.r.t. this patch and regardless of what the formally written policy is, it seems best to revert this and resolve the outstanding issues. Keeping it in tree will cause more things to be built on top of it, and over constrains the discussion about getting to the best possible design.<div class=""><br class=""></div><div class="">Sean’s point is also excellent: often it is best to pop out of email and into a higher bandwidth communication form (voice, video chat, etc) when hitting controversy like this.</div></div></blockquote><div class=""><br class="">Yep, Nicolai's reverted the patch (see: <a href="http://lists.llvm.org/pipermail/llvm-dev/2020-October/146107.html" class="">http://lists.llvm.org/pipermail/llvm-dev/2020-October/146107.html</a> ) - the conversation's got a bit fragmented between the review thread, new RFC thread, and rename of that thread) and Alina, Nicolai, and myself chatted offline on Thursday - think we came to some pieces of common understanding. Nicolai's going to work up a new RFC ( <a href="https://reviews.llvm.org/D83088#2365320" class="">https://reviews.llvm.org/D83088#2365320</a> , <a href="http://lists.llvm.org/pipermail/llvm-dev/2020-October/146258.html" class="">http://lists.llvm.org/pipermail/llvm-dev/2020-October/146258.html</a> ) we can hopefully get a few eyes on/clarify some things to make progress.<br class=""><br class="">- Dave<br class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""></div><div class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Oct 26, 2020, at 4:26 PM, Sean Silva via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">Also, if this hasn't happened already, I would recommend some 1-on-1 (at least over chat, or if possible video call) between Nicolai and Dave. In the past, I have found this to fairly quickly come to consensus about design direction (though of course please update any relevant threads with the takeaways of such private discussions!).<div class=""><br class=""></div><div class="">-- Sean Silva</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 26, 2020 at 1:05 PM Eric Christopher via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">Hi Nicolai,<div class=""><br class=""></div><div class="">I've been watching this and the associated review that <a class="gmail_plusreply" id="gmail-m_-7227482519126709434gmail-m_2511614691991029439plusReplyChip-0" href="mailto:joker.eph@gmail.com" target="_blank">+Mehdi AMINI</a> brought up as far as the process.</div><div class=""><br class=""></div><div class="">I think you should revert this patch and anything dependent upon it until the review is complete. Dave has many good points in his review and while you pinged there needs to be resolution before applying. In particular, he's probably the most active reviewer in exactly this space right now and is obviously also the right reviewer for this patch.</div><div class=""><br class=""></div><div class="">Please revert immediately and thanks. I'm sorry the patch has gotten contentious, but this is a fairly major overhaul and it does happen sometimes.</div><div class=""><br class=""></div><div class="">Thanks.</div><div class=""><br class=""></div><div class="">-eric</div><div class=""><br class=""></div><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 26, 2020 at 2:46 PM Renato Golin via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class=""><div dir="ltr" class="">On Sat, 24 Oct 2020 at 23:13, Nicolai Hähnle via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Maybe David wants to forbid this use of dynamic polymorphism outright.<br class="">
I think this is unacceptable, so in that case, it seems we have no<br class="">
choice but to start a formal process for resolving contentious<br class="">
decisions.</blockquote><div class=""><br class=""></div><div class="">If this ends up being the case, then you *must* revert the patch until the matter can be solved.</div><div class=""><br class=""></div><div class="">But as I said before, I would have reverted it a long time ago.</div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">(I would still ask people to _please_ be good citizens and allow us to<br class="">
make upstream progress in AMDGPU as we usually do while this is<br class="">
happening -- I explain my reasoning a bit more below -- but I'd accept<br class="">
it based on the rules that are in effect today. Invoking the formal<br class="">
process should give all participants the confidence that the question<br class="">
doesn't just end up dropped on the floor, and that the in-tree status<br class="">
of the code wouldn't implicitly favor either side of the discussion.)<br class=""></blockquote><div class=""><br class=""></div><div class="">The AMD backend doesn't trump a high-level CFG design decision that affects *all* back-ends, front-ends and middle-ends. </div><div class=""><br class=""></div><div class="">If you progress your AMD work on your current assumption and it turns out people decide against it you will have to revert *all* of it, which is a lot more substantial (and a potentially dangerous merge) than just this CFG change.</div><div class=""><br class=""></div><div class="">I'd also strongly advise people reviewing the remaining work from approving the patches until this matter can be resolved. This is not a trivial issue and can have further consequences than just a simple revert.</div><div class=""><br class=""></div><div class="">And please, do not assume what being a good citizens is. We can all be good citizens and still overwhelmingly disagree with each other, as long as we keep it civil.</div><div class=""><br class=""></div><div class="">I see no evidence of lack of civility from either David or Mehdi. On the contrary, they're being extremely kind and patient.</div><div class=""><br class=""></div><div class="">cheers,</div><div class="">--renato</div></div></div>
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div>
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class=""></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></div></body></html>