<div dir="ltr">Oh, right, sorry, was getting things confused/mixed up about "is it part of llvm, is it part of the monorepo, is it in another repo". :/ Dunno what to do about that then.<br><br>Hmm, wait, no - nevermind that. These tests are part of the monorepo:<br><br><a href="https://github.com/llvm/llvm-project">https://github.com/llvm/llvm-project</a><br><a href="https://github.com/llvm/llvm-project/debuginfo-tests">https://github.com/llvm/llvm-project/debuginfo-tests</a><br><a href="https://github.com/llvm/llvm-project/mlir">https://github.com/llvm/llvm-project/mlir</a><br><br>They seem to be on the same level as mlir and flang.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 3:43 PM Mehdi AMINI <<a href="mailto:joker.eph@gmail.com">joker.eph@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 3:37 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 3:32 PM Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 3:23 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 3:22 PM Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>These are all plugged through global Herald rules in general.</div><div>It somehow relies on the monorepo to know how to dispatch (path starting with LLVM -> llvm-commits@).</div><div><br></div><div>I don't know what the rule should be for debuginfo-tests?</div></div></blockquote><div><br></div><div>Same as LLVM I think would be good. (that's where the commits mail is going, pretty sure - so it's where the reviews should go)</div><div></div></div></div></blockquote><div><br></div><div>I mean: I don't know how to detect that a patch is about the debuginfo tests: if it is another repo, there won't be a leading path to tell us like in the monorepo.</div></div></div></blockquote><div><br></div><div>Oh, sorry, I see - any idea how mlir, flang, etc, handle this then?</div></div></div></blockquote><div><br></div><div>Like LLVM: by being in the monorepo they have a leading path discriminator.</div><div><br></div><div><a href="https://reviews.llvm.org/H591" target="_blank">https://reviews.llvm.org/H591</a><br></div><div><a href="https://reviews.llvm.org/H615" target="_blank">https://reviews.llvm.org/H615</a><br></div><div><a href="https://reviews.llvm.org/H607" target="_blank">https://reviews.llvm.org/H607</a><br></div><div><a href="https://reviews.llvm.org/H600" target="_blank">https://reviews.llvm.org/H600</a><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>-- </div><div>Mehdi</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 1:02 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Mehdi - any idea how this is rigged up/if this could be fixed for the debuginfo-tests repo?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 12:38 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">ah, indeed - my mistake!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 21, 2020 at 12:34 PM Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p class="MsoNormal">I’m talking about the “subscribed” field in a Phab review, so that the list sees the posted comments/reviews; you seem to be talking about the “this was committed” email which does come from github.<u></u><u></u></p>
<p class="MsoNormal">--paulr<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> <br>
<b>Sent:</b> Wednesday, October 21, 2020 2:29 PM<br>
<b>To:</b> Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>><br>
<b>Cc:</b> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<b>Subject:</b> Re: [llvm-dev] Phabricator request for debuginfo-tests<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Will follow-up more on the bug, but I don't think the commits mailing list mail is powered by phabricator at all - it's some post-commit hook in the VCS/github itself, I think.<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Oct 21, 2020 at 6:35 AM Robinson, Paul via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi all,<br>
I filed <a href="https://urldefense.com/v3/__https:/bugs.llvm.org/show_bug.cgi?id=47934__;!!JmoZiZGBv3RvKRSx!ql6dBxeOus1GDl0ClfO1BlIfpD2O9XU4NmaiKCCM7MnDTVsiNP5p564p_NB2Q7xesw$" target="_blank">
https://bugs.llvm.org/show_bug.cgi?id=47934</a> asking to have<br>
the debuginfo-tests project added to the list of those that subscribe<br>
llvm-commits automatically. But, it appears that the Phabricator<br>
component doesn't have anyone automatically cc'd, and I suspect that<br>
by failing to put [Phab] in the bug title, whoever knows how to do<br>
this won't notice the bug.<br>
<br>
So, how does that auto-subscription work? Note that historically,<br>
I have always come out the worst when tangling with Phabricator...<br>
so I'll do it myself if necessary, if someone can say what "it" is,<br>
but it would be safer for someone else to do the tweaking.<br>
<br>
Thanks,<br>
--paulr<br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!ql6dBxeOus1GDl0ClfO1BlIfpD2O9XU4NmaiKCCM7MnDTVsiNP5p564p_NBOExc-LQ$" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div></div></div></div></div></div>
</blockquote></div>