<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks for the positive feedback!<div class=""><br class=""></div><div class="">All the patches are up now:</div><div class=""><br class=""></div><div class="">Elevating different constants to arguments: <a href="https://reviews.llvm.org/D87296" class="">[IRSim][IROutliner] Adding support for consolidating functions with different output arguments.</a></div><div class="">Extracting require outputs: <a href="https://reviews.llvm.org/D87296" class="">[IRSim][IROutliner] Adding support for consolidating functions with different output arguments.</a></div><div class="">Merging Output Blocks: <a href="https://reviews.llvm.org/D87298" class="">[IRSim][IROutliner] Merging output blocks for extracted functions with outputs</a></div><div class="">Cost Model: <a href="https://reviews.llvm.org/D87299" class="">[IRSim][IROutliner] Adding a cost model, and debug option to turn the model off.</a></div><div class="">OptRemarks: <a href="https://reviews.llvm.org/D87300" class="">[IRSim][IROutliner] Adding OptRemarks for the IROutliner.</a></div><div class="">Function Attribute Merging: <a href="https://reviews.llvm.org/D87301" class="">[IRSim][IROutliner] Adding consistent function attribute merging</a></div><div class="">DebugInfo Handling: <a href="https://reviews.llvm.org/D87302" class="">[IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.</a></div><div class="">Outlining from linkonceodr: <a href="https://reviews.llvm.org/D87309" class="">[IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions</a></div><div class="">Flexibility for Isomorphic Predicates: <a href="https://reviews.llvm.org/D87310" class="">[IRSim] Adding support for isomorphic predicates</a></div><div class="">Flexibility for Commutative Instructions: <a href="https://reviews.llvm.org/D87311" class="">[IRSim] Adding commutativity matching to structure checking</a></div><div class="">Matching call instructions for similarity identification: <a href="https://reviews.llvm.org/D87312" class="">[IRSim] Letting call instructions be legal for similarity identification.</a></div><div class="">Outlining Calls: <a href="https://reviews.llvm.org/D87314" class="">[IRSim][IROutliner] Allowing call instructions to be outlined.</a></div><div class="">Matching GEP instructions for similarity identification: <a href="https://reviews.llvm.org/D87315" class="">[IRSim] Letting gep instructions be legal for similarity identification.</a></div><div class="">Outlining GEP instructions: <a href="https://reviews.llvm.org/D87317" class="">[IRSim][IROutliner] Allowing GEP instructions to be outlined.</a></div><div class=""><br class=""></div><div class="">Feedback, comments and reviews are welcome!</div><div class=""><br class=""></div><div class="">Andrew<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 2, 2020, at 5:04 AM, Renato Golin <<a href="mailto:rengolin@gmail.com" class="">rengolin@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">Indeed, an awesome project and an excellent report!</div><div class=""><br class=""></div>Code size doesn't really get much attention, so the level of detail and the strong roadmap is refreshing.<br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class=""><p class=""><font size="-1" class="">Hopefully, the project will provide execution times along with
code-size reductions.</font></p></div></blockquote><div class="">I doubt it.</div><div class=""><br class=""></div><div class="">Outlining will (almost?) always make for slower code due to a lot more calls being made. But that's ok for embedded targets, that don't have strong speculative machinery. </div><div class=""><br class=""></div><div class="">Also, if the program fits versus doesn't, then it will run infinitely faster. :D</div><div class=""><br class=""></div><div class="">Kristof, do you know who at Arm would be good to review those patches?</div><div class=""><br class=""></div><div class="">cheers,</div><div class="">--renato</div></div></div>
</div></blockquote></div><br class=""></div></body></html>