<div dir="auto">Hi James,<div dir="auto"><br></div><div dir="auto">Adding Hendrik, who has taken over ownership of the downstream code involved. </div><div dir="auto"><br></div><div dir="auto">I can also add background about the rationale, of that helps? It was added to ignore induction variable update code (scalar code) that is rewritten when we unroll / peel the prolog epilog anyway. </div><div dir="auto"><br></div><div dir="auto">Targets like Hexagon or PPC with dedicated loop control instructions for pipelined loops don't need this, but our target was simple RISC. It was for that reason that I felt the feature would be useful for other targets. </div><div dir="auto"><br></div><div dir="auto">James</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 3 Sep 2020, 17:19 Nagurne, James, <<a href="mailto:j-nagurne@ti.com">j-nagurne@ti.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-2366449629682116770WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ah, I apologize for not seeing the meaning of your first email. I had not considered that he was working on an out-of-tree target that utilizes the ignore capability.
You’ve made things very clear, thank you!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Since he’s on the email thread now:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">James, do you plan on upstreaming any portion of the ignore capability? If not, do you have any pointers for a target that may want to implement it? The one
issue I see that might exist is that the scheduler wants a region begin and end as iterators, meaning contiguous instructions. It doesn’t really support the removal of instructions between those two points, so you’d have to synthesize a region, create a meta-iterator,
or some other intrusive modification.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">JB<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_-2366449629682116770__MailEndCompose" rel="noreferrer"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Jinsong Ji [mailto:<a href="mailto:jji@us.ibm.com" target="_blank" rel="noreferrer">jji@us.ibm.com</a>]
<br>
<b>Sent:</b> Thursday, September 3, 2020 10:03 AM<br>
<b>To:</b> Nagurne, James; <a href="mailto:jmolloy@google.com" target="_blank" rel="noreferrer">jmolloy@google.com</a><br>
<b>Cc:</b> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>; Sander<br>
<b>Subject:</b> [EXTERNAL] RE: [llvm-dev] Machinepipeliner interface. shouldIgnoreForPipelining, actually not ignoring.<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p><span style="font-size:10.0pt">As I mentioned before, </span><br>
<span style="font-size:10.0pt">this API was introduced by James, mostly for his out-of-tree implementations,
</span><br>
<span style="font-size:10.0pt">the in tree implementation NEVER implement it.</span><br>
<br>
<span style="font-size:10.0pt">If it is causing confusion, I think we have two choices:</span><br>
<span style="font-size:10.0pt">1. See whether James would like to upstream part of his code? Or any other target that would like to use this can post a patch to use it.</span><br>
<span style="font-size:10.0pt">2. Remove this confusing API in tree.</span><br>
<br>
<span style="font-size:10.0pt"><br>
Best,<br>
<br>
Jinsong Ji (<span lang="ZH-CN">纪金松</span>), PhD.<br>
<br>
XL/LLVM on Power Compiler Development <br>
E-mail: <a href="mailto:jji@us.ibm.com" target="_blank" rel="noreferrer">jji@us.ibm.com</a></span><br>
<br>
<img width="16" height="16" id="m_-2366449629682116770_x0000_i1025" src="cid:image001.gif@01D681E2.61CD3A00" alt="Inactive hide details for "Nagurne, James" ---09/02/2020 01:43:29 PM---Sorry to bring this thread from 3 months ago back, but I"><span style="font-size:10.0pt;color:#424282">"Nagurne,
James" ---09/02/2020 01:43:29 PM---Sorry to bring this thread from 3 months ago back, but I’m running into this issue too. I do see tha</span><br>
<br>
<span style="font-size:10.0pt;color:#5f5f5f">From: </span><span style="font-size:10.0pt">"Nagurne, James" <<a href="mailto:j-nagurne@ti.com" target="_blank" rel="noreferrer">j-nagurne@ti.com</a>></span><br>
<span style="font-size:10.0pt;color:#5f5f5f">To: </span><span style="font-size:10.0pt">Jinsong Ji <<a href="mailto:jji@us.ibm.com" target="_blank" rel="noreferrer">jji@us.ibm.com</a>>, Sander <<a href="mailto:sanderruben@gmail.com" target="_blank" rel="noreferrer">sanderruben@gmail.com</a>></span><br>
<span style="font-size:10.0pt;color:#5f5f5f">Cc: </span><span style="font-size:10.0pt">"<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>" <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>></span><br>
<span style="font-size:10.0pt;color:#5f5f5f">Date: </span><span style="font-size:10.0pt">09/02/2020 01:43 PM</span><br>
<span style="font-size:10.0pt;color:#5f5f5f">Subject: </span><span style="font-size:10.0pt">RE: [EXTERNAL] Re: [llvm-dev] Machinepipeliner interface. shouldIgnoreForPipelining, actually not ignoring.</span><u></u><u></u></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade style="color:#8091a5" align="left">
</div>
<p class="MsoNormal"><br>
<br>
<br>
<span style="color:#1f497d">Sorry to bring this thread from 3 months ago back, but I’m running into this issue too.</span><br>
<span style="color:#1f497d">I do see that shouldIgnore is not called in the MachinePipeliner, however, James’ comment doesn’t really resolve the issue or make the story any clearer.</span><br>
<br>
<span style="color:#1f497d">My summary of the comment is: “Hexagon and PPC9 do not need to ignore any instructions. However, in the case that you do, such as when the indvar update is explicit, this function is provided to allow the target to strip those instructions
from the pipelined kernel.”</span><br>
<br>
<span style="color:#1f497d">However, the reality is that the implementation seems incomplete and there’s no instructions on how to achieve the desired result. Is it left as an exercise to the reader/implementer? Is there something I’m missing?</span><br>
<br>
<span style="color:#1f497d">J.B. Nagurne</span><br>
<span style="color:#1f497d">Code Generation</span><br>
<span style="color:#1f497d">Texas Instruments</span><br>
<br>
<b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-dev [<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank" rel="noreferrer">mailto:llvm-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Jinsong Ji via llvm-dev<b><br>
Sent:</b> Tuesday, June 2, 2020 2:58 PM<b><br>
To:</b> Sander<b><br>
Cc:</b> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><b><br>
Subject:</b> [EXTERNAL] Re: [llvm-dev] Machinepipeliner interface. shouldIgnoreForPipelining, actually not ignoring.</span><u></u><u></u></p>
<p><span style="font-size:10.0pt">Hi Sander:</span><br>
<span style="font-size:10.0pt"><br>
It may be confusing, but it is not a bug. <br>
And you are right, if you are using the in-tree machinepipeliner, it won't have any effects,<br>
because there is NO In tree reference of this API at all.</span><br>
<span style="font-size:10.0pt"><br>
You can see the comments when </span><span style="font-family:"Helvetica Neue","serif"">James</span><span style="font-size:10.0pt"> introduced this API in
</span><a href="https://reviews.llvm.org/D67167" target="_blank" rel="noreferrer">https://reviews.llvm.org/D67167</a><br>
<br>
<span style="font-size:10.0pt"><br>
<br>
Best,<br>
<br>
Jinsong Ji (<span lang="ZH-CN">纪金松</span>), PhD.<br>
<br>
XL/LLVM on Power Compiler Development <br>
E-mail: <a href="mailto:jji@us.ibm.com" target="_blank" rel="noreferrer">jji@us.ibm.com</a></span><br>
<br>
<img border="0" width="16" height="16" id="m_-2366449629682116770_x0000_i1027" src="cid:image001.gif@01D681E2.61CD3A00" alt="Inactive hide details for Sander via llvm-dev ---06/02/2020 03:47:53 PM---Hi all, I think there is a mistake in the machinepipe"><span style="font-size:10.0pt;color:#424282">Sander
via llvm-dev ---06/02/2020 03:47:53 PM---Hi all, I think there is a mistake in the machinepipeliner interface. In the</span><br>
<span style="font-size:10.0pt;color:#5f5f5f"><br>
From: </span><span style="font-size:10.0pt">Sander via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>><span style="color:#5f5f5f"><br>
To: </span><a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><span style="color:#5f5f5f"><br>
Date: </span>06/02/2020 03:47 PM<span style="color:#5f5f5f"><br>
Subject: </span>[EXTERNAL] [llvm-dev] Machinepipeliner interface. shouldIgnoreForPipelining, actually not ignoring.<span style="color:#5f5f5f"><br>
Sent by: </span>"llvm-dev" <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev-bounces@lists.llvm.org</a>></span><u></u><u></u></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade style="color:#a0a0a0" align="left">
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<br>
<br>
<span style="font-size:10.0pt"><br>
Hi all,<br>
<br>
I think there is a mistake in the machinepipeliner interface. In the <br>
TargetInstrInfo.h in the class PipelinerLoopInfo there is a function <br>
"bool shouldIgnoreForPipelining(const MachineInstr *MI)". The <br>
description says that if this function returns true for a given <br>
MachineInstr it will not be pipelined.<br>
<br>
However in reality it is not ignored and is being considered for <br>
pipelining. I implemented this function in my own backend, and put an <br>
instruction there that I want to be ignored, but still this instruction <br>
end up trying to be pipelined. I implemented the same way as in <br>
PPCInstrInfo.cpp, and I think it has the same bug. Is this a bug, or am <br>
I forgetting something?<br>
<br>
Kind regards,<br>
<br>
Sander Ruben<br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><u><span style="color:blue"><br>
</span></u></span><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank" rel="noreferrer"><span style="font-size:10.0pt">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</span></a><span style="font-size:10.0pt">
<br>
</span><br>
<br>
<br>
<br>
<u></u><u></u></p>
</div>
</div>
</blockquote></div>