<div dir="ltr"><div dir="ltr">On Tue, Sep 1, 2020 at 3:57 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 1, 2020 at 12:42 PM Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Tue, Sep 1, 2020 at 3:32 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Tue, Sep 1, 2020 at 12:07 PM Nico Weber via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<br><div><br></div><div>llvmbb's job is to inform people of build breaks. However, it seems to trigger for a big list of bots, and at least one of them seems to always be broken,</div></div></blockquote><div><br>If a bot is always broken it shouldn't be sending email/notifications - generally they are configured only to send email on green>red and red>green transitions, so if it's already broken you shouldn't be blamed for it. If you are seeing bot spam or emails from a bot that's already red, please email llvm-dev and the bot maintainer and ask the bot to be reconfigured or disabled.<br><br>If a bot is regularly flakey (& thus sending email/notifications that are false-positives/that no one can act on) please also send email asking for the bot to be reconfigured or disabled. (or, if you want to be a bit more punchy - send a patch to the zorg repository to have the bot disabled & explain why you're proposing that)<br></div></div></div></blockquote><div><br></div><div>I agree with this in the abstract, but I get pinged completely reliably at least twice after every single of my commits. This isn't something that sometimes happens, it's something that always happens.</div></div></div></blockquote><div><br>Could you point to specific buildbots/email when that comes up to help improve things both on IRC and email/mailing lists, etc?<br></div></div></div></blockquote><div><br></div><div>Just land a change :) Or look at IRC scrollback. Given how easy it is to find these problems, it doesn't seem like there's a lot of appetite for improving this. Hence me asking about removing llvmbb (...and so far everyone seems to be in favor).</div><div><br></div><div>In this case, from my IRC scrollback (there's more people on the blamelist, spread over several follow-on IRC messages):</div><div><br></div><div>build #13975 of clang-ppc64le-linux-multistage is complete: Failure [failed ninja check 1] Build details are at <a href="http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/13975" target="_blank">http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/13975</a> blamelist: LLVM GN Syncbot <<a href="mailto:llvmgnsyncbot@gmail.com" target="_blank">llvmgnsyncbot@gmail.com</a>>, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>><br></div><div><br></div><div>build #24132 of clang-with-thin-lto-ubuntu is complete: Failure [failed test-stage1-compiler] Build details are at <a href="http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/24132" target="_blank">http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/24132</a> blamelist: Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>>, Matt Arsenault <<a href="mailto:Matthew.Arsenault@amd.com" target="_blank">Matthew.Arsenault@amd.com</a>>, Eric Astor <<a href="mailto:epastor@google.com" target="_blank">epastor@google.com</a>>, Craig Topper <<a href="mailto:craig.topper@intel.com" target="_blank">craig.topper@intel.com</a>>, Alina<br></div><div><br></div><div> build #2255 of lld-x86_64-win is complete: Failure [failed test-check-all] Build details are at <a href="http://lab.llvm.org:8011/builders/lld-x86_64-win/builds/2255" target="_blank">http://lab.llvm.org:8011/builders/lld-x86_64-win/builds/2255</a> blamelist: LLVM GN Syncbot <<a href="mailto:llvmgnsyncbot@gmail.com" target="_blank">llvmgnsyncbot@gmail.com</a>>, Eric Astor <<a href="mailto:epastor@google.com" target="_blank">epastor@google.com</a>>, Craig Topper <<a href="mailto:craig.topper@intel.com" target="_blank">craig.topper@intel.com</a>>, Alina Sbirlea <<a href="mailto:asbirlea@google.com" target="_blank">asbirlea@google.com</a>>, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>>, Amara<br></div><div><br></div><div>I also got email with pointers to:</div><div><a href="http://green.lab.llvm.org/green//job/clang-stage1-RA/14180/consoleFull#-1417328700a1ca8a51-895e-46c6-af87-ce24fa4cd561" target="_blank">http://green.lab.llvm.org/green//job/clang-stage1-RA/14180/consoleFull#-1417328700a1ca8a51-895e-46c6-af87-ce24fa4cd561</a><br></div><div><br></div><div>Chances are that there's something genuinely broken somewhere (maybe compiler-rt?), but asking for concrete bots distracts from the point that there's something broken on every single commit, which makes the bot just let you know that you committed something in the last few hours.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div> and the broken bots tend to have cycle times of several hours. </div></div></blockquote><div><br>Long cycle times are a real problem - that might be best left to another discussion about buildbot maintenance - I would be for a policy that says bot windows shouldn't be longer than, say, an hour or maybe less. (so, eg: if you have a bot that's just going to take 5 hours to run - then you need 5 machines that each pickup work every hour, so the blame lists are smaller) this doesn't solve the problem of being notified 5 hours later about a breakage that was caused by someone else who committed a few minutes before or after you. Solving that problem will require a much greater investment in infrastructure to chain buildbots, possibly use built artefacts from one buildbot to another, etc.<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>So if you're on IRC and you commit something, you get pinged by llvmbb for hours afterwards.</div><div><br></div><div>Does anyone think llvmbb is useful?</div></div></blockquote><div><br></div><div>I sometimes find it useful, but happy to move to llvm-build to get those notifications. Other folks might not know to do that, though.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>The best thing about llvmbb I've heard it's easy to just "/ignore llvmbb", but if that's what everybody does then why not not have it in the first place?<br></div><div><br></div><div>Nico</div></div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div></div>