<div dir="auto">Thank you!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 26, 2020, 9:16 AM Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Committed in 03c8e1cc7efabd122294e1cd670fba6d544f2831. Thanks!<br>
<br>
On Wed, Aug 26, 2020 at 1:22 AM Peter Collingbourne <<a href="mailto:pcc@google.com" target="_blank" rel="noreferrer">pcc@google.com</a>> wrote:<br>
><br>
> SGTM.<br>
><br>
> Peter<br>
><br>
> On Tue, Aug 25, 2020 at 3:55 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" rel="noreferrer">echristo@gmail.com</a>> wrote:<br>
> ><br>
> > "The llgo frontend has been removed for now, but may be resurrected in the future."<br>
> ><br>
> > Thoughts?<br>
> ><br>
> > -eric<br>
> ><br>
> > On Tue, Aug 25, 2020 at 2:18 PM Hans Wennborg via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >><br>
> >> Can someone add a mention about the llgo removal to the release notes?<br>
> >><br>
> >> Thanks,<br>
> >> Hans<br>
> >><br>
> >> On Fri, Feb 14, 2020 at 3:40 PM James Y Knight via llvm-dev<br>
> >> <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> ><br>
> >> > Nope, it wasn't all reverted -- the llgo implementation remains deleted.<br>
> >> ><br>
> >> > There's been some confusion borne out of unfortunate naming -- only the file "llvm/tools/llvm-go/llvm-go.go" was reinstated. Despite its confusing name, this tool is not a go implementation, and has effectively nothing to do with llgo. It's only a tiny utility script used by the llvm build process for running go programs with the desired set of environment variables.<br>
> >> ><br>
> >> > From the comment in the file:<br>
> >> >><br>
> >> >> This tool lets us build LLVM components within the tree by setting up a $GOPATH that resembles a tree fetched in the normal way with "go get".<br>
> >> ><br>
> >> ><br>
> >> > (FWIW, I had the exact same reaction as you, before realizing the above.)<br>
> >> ><br>
> >> > On Fri, Feb 14, 2020 at 2:46 AM Raphael “Teemperor” Isemann via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> >><br>
> >> >> So just to summarise what happened outside the mailing list:<br>
> >> >> * We removed llvm-go<br>
> >> >> * We also removed/fixed several things that referenced llvm-go in the following days.<br>
> >> >> * We reverted all of that (apparently to test LLVM’s Go bindings with llvm-go instead of system Go)<br>
> >> >><br>
> >> >> So from what I understand the only reason llvm-go is in tree is to test the bindings? It’s also not clear to me why we can’t use the normal go compiler for testing them (like we test the ocaml bindings with the system ocamlc).<br>
> >> >><br>
> >> >> On 10. Feb 2020, at 19:12, Eric Christopher via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> >><br>
> >> >> Done thusly:<br>
> >> >><br>
> >> >> echristo@athyra ~/r/llvm-project> git push<br>
> >> >> To github.com:llvm/llvm-project.git<br>
> >> >> 936d1427da1..372bfc65deb master -> master<br>
> >> >><br>
> >> >> On Mon, Feb 10, 2020 at 10:02 AM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" rel="noreferrer">echristo@gmail.com</a>> wrote:<br>
> >> >>><br>
> >> >>> OK. I'll get it.<br>
> >> >>><br>
> >> >>> -eric<br>
> >> >>><br>
> >> >>> On Mon, Feb 10, 2020 at 9:58 AM Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank" rel="noreferrer">peter@pcc.me.uk</a>> wrote:<br>
> >> >>>><br>
> >> >>>> Sure, that's fine with me.<br>
> >> >>>><br>
> >> >>>> Peter<br>
> >> >>>><br>
> >> >>>> On Mon, Feb 10, 2020 at 9:57 AM Eric Christopher via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> >>>>><br>
> >> >>>>> Calling pcc real fast :)<br>
> >> >>>>><br>
> >> >>>>> -eric<br>
> >> >>>>><br>
> >> >>>>> On Mon, Feb 10, 2020 at 9:49 AM David Blaikie via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> >>>>>><br>
> >> >>>>>> Yep - delete it. If someone wants it back they can resurrect it from version control & explain why it's worth adding back in.<br>
> >> >>>>>><br>
> >> >>>>>> On Mon, Feb 10, 2020 at 9:17 AM Jonas Devlieghere via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> >>>>>>><br>
> >> >>>>>>> Thanks for bringing this up! Strong +1 from me for all the reasons<br>
> >> >>>>>>> you've mentioned.<br>
> >> >>>>>>><br>
> >> >>>>>>> On Mon, Feb 10, 2020 at 8:42 AM Raphael Isemann via llvm-dev<br>
> >> >>>>>>> <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >> >>>>>>> ><br>
> >> >>>>>>> > Hi all,<br>
> >> >>>>>>> ><br>
> >> >>>>>>> > the monorepo contains a Go frontend called 'llgo' (in the llgo/ top<br>
> >> >>>>>>> > level folder). It apparently hasn't been active since 2017 and before<br>
> >> >>>>>>> > that it wasn't very active either (there were 13 commits in 2016<br>
> >> >>>>>>> > apparently, most of it minor fixes).<br>
> >> >>>>>>> ><br>
> >> >>>>>>> > I would propose that we remove it from the monorepo for the following reasons:<br>
> >> >>>>>>> ><br>
> >> >>>>>>> > * It is apparently unmaintained.<br>
> >> >>>>>>> > * It only supports a long outdated Go version (1.5 while latest is 1.13 or so).<br>
> >> >>>>>>> > * It doesn't build (at least on my machine) due to runtime errors (the<br>
> >> >>>>>>> > build log is really unhelpful in telling me what actually went wrong).<br>
> >> >>>>>>> > In general the build system is kinda flawed as it seems to just<br>
> >> >>>>>>> > manually run 'make' as a single custom build step (even with a -GNinja<br>
> >> >>>>>>> > build).<br>
> >> >>>>>>> > * It contains a full copy of Mark Twain's novel "The Adventures of Tom<br>
> >> >>>>>>> > Sawyer". It gets really tiring to blacklist this file on my desktop<br>
> >> >>>>>>> > search engine as it otherwise constantly comes up in unrelated<br>
> >> >>>>>>> > searches for words that are by accident in this novel.<br>
> >> >>>>>>> > * The sources of multiple third party libraries are copied into its<br>
> >> >>>>>>> > third party directory. It would be nice not to have random code in the<br>
> >> >>>>>>> > LLVM repo under a different license than LLVM.<br>
> >> >>>>>>> > * It's the only reason why we maintain some Go support in LLVM's CMake<br>
> >> >>>>>>> > (like llvm_add_go_executable ).<br>
> >> >>>>>>> ><br>
> >> >>>>>>> > Thoughts?<br>
> >> >>>>>>> ><br>
> >> >>>>>>> > - Raphael<br>
> >> >>>>>>> > _______________________________________________<br>
> >> >>>>>>> > LLVM Developers mailing list<br>
> >> >>>>>>> > <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> >>>>>>> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> >>>>>>> _______________________________________________<br>
> >> >>>>>>> LLVM Developers mailing list<br>
> >> >>>>>>> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> >>>>>>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> >>>>>><br>
> >> >>>>>> _______________________________________________<br>
> >> >>>>>> LLVM Developers mailing list<br>
> >> >>>>>> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> >>>>>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> >>>>><br>
> >> >>>>> _______________________________________________<br>
> >> >>>>> LLVM Developers mailing list<br>
> >> >>>>> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> >>>>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> >>>><br>
> >> >>>><br>
> >> >>>><br>
> >> >>>> --<br>
> >> >>>> --<br>
> >> >>>> Peter<br>
> >> >><br>
> >> >> _______________________________________________<br>
> >> >> LLVM Developers mailing list<br>
> >> >> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> >> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> >><br>
> >> >><br>
> >> >> _______________________________________________<br>
> >> >> LLVM Developers mailing list<br>
> >> >> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> >> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> ><br>
> >> > _______________________________________________<br>
> >> > LLVM Developers mailing list<br>
> >> > <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >> _______________________________________________<br>
> >> LLVM Developers mailing list<br>
> >> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> >> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>