<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">+1, I like this, too. </div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 7, 2020 at 8:33 AM Jay Foad via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I have just noticed this happening. Thank you, thank you, thank you!<br>
<br>
Jay.<br>
<br>
On Tue, 28 Jul 2020 at 06:25, Mehdi AMINI via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
><br>
><br>
> On Thu, Apr 9, 2020 at 9:45 AM Jon Roelofs <<a href="mailto:jroelofs@gmail.com" target="_blank">jroelofs@gmail.com</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <<a href="mailto:llvmdev@meinersbur.de" target="_blank">llvmdev@meinersbur.de</a>> wrote:<br>
>>><br>
>>> I was always assuming that the suggested commit is assembled in the<br>
>>> PHP code run by arcanist command run locally. If indeed the arc<br>
>>> command requests the commit message from the server,<br>
>><br>
>><br>
>> I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed:<br>
>><br>
>> <a href="https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757" rel="noreferrer" target="_blank">https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757</a><br>
><br>
><br>
><br>
> FYI: I patched our Phab instance and now `arc land` will omit "Subscribers", "Reviewers", and "Tags".<br>
> It'll also print the description without prefixing with "Summary:".<br>
><br>
> --<br>
> Mehdi<br>
><br>
><br>
>><br>
>><br>
>><br>
>>><br>
>>> we could do some<br>
>>> additional things:<br>
>>><br>
>>>  * Remove "Summary:" in front of message<br>
>>>  * Line break after 72 columns<br>
>>>  * Convert summary markdown formatting to plain texts (e.g. remove<br>
>>> backticks; I don't know any git client that renders as markdown)<br>
>>>  * Add/check existence of [component] tag<br>
>>><br>
>>> Alternatively, we could make an upstream feature request<br>
>><br>
>><br>
>> From what I can tell, upstream doesn't seem /that/ interested in it being any more than a one-off thing:<br>
>><br>
>> <a href="https://secure.phabricator.com/Q268" rel="noreferrer" target="_blank">https://secure.phabricator.com/Q268</a><br>
>> <a href="https://secure.phabricator.com/T12276" rel="noreferrer" target="_blank">https://secure.phabricator.com/T12276</a><br>
>> <a href="https://secure.phabricator.com/T11864" rel="noreferrer" target="_blank">https://secure.phabricator.com/T11864</a><br>
>><br>
>> Jon<br>
>><br>
>>><br>
>>> Michael<br>
>>><br>
>>> Am Do., 9. Apr. 2020 um 11:16 Uhr schrieb Jon Roelofs via llvm-dev<br>
>>> <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>:<br>
>>> ><br>
>>> > Can we fix this in <a href="http://reviews.llvm.org" rel="noreferrer" target="_blank">reviews.llvm.org</a>'s fork of phab?<br>
>>> ><br>
>>> > <a href="https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php" rel="noreferrer" target="_blank">https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php</a><br>
>>> ><br>
>>> > Seems straightforward(-ish) to drop the relevant fields there, that way `arc land` automatically DTRT.<br>
>>> ><br>
>>> > Jon<br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>