<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 21, 2020, at 11:50 AM, Jonathan Roelofs via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">A question of preference came up in <a href="https://reviews.llvm.org/D83588" class="">https://reviews.llvm.org/D83588</a> as to whether we ought to prefer emitting TableGen error messages with all of the information in a single diagnostic, or whether it makes sense to split things in an error+note style as seen in many clang diagnostics. TableGen doesn’t use a DiagnosticsEngine, so the concept of a fatal note following an error is a bit new/foreign there, but perhaps something that makes sense adding.<div class=""><br class=""></div><div class="">Is there any precedence here for other internal llvm tooling (outside of clang)? What’s the general consensus here?</div></div></div></blockquote><br class=""></div><div>I think it makes a lot of sense to add this to TableGen. It is a widely used tool and the QoI for its error messages could use a lot of improvement!</div><div><br class=""></div><div>-Chris</div><br class=""></body></html>