<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><font face="Hack Nerd Font Mono">No strong opinion on the
tablegen implementation choice but very much in</font></p>
<p><font face="Hack Nerd Font Mono">favor of "default attributes"
for intrinsics.</font></p>
<p><font face="Hack Nerd Font Mono"><br>
</font></p>
<p><font face="Hack Nerd Font Mono">There is a valid correctness
concern but I would argue the attributes show up in the
intrinisc test when you add them. <br>
</font></p>
<p><font face="Hack Nerd Font Mono">If they seem off, you need to
opt-out.<br>
</font></p>
<p><font face="Hack Nerd Font Mono"><br>
</font></p>
<p><font face="Hack Nerd Font Mono"></font><br>
</p>
<div class="moz-cite-prefix">On 6/24/20 11:28 AM, Stefan Stipanovic
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CANPMpzBX8xdqt0UiPw+1VD1LFsivBuBPrXxSe3DE8hwjwm3BkQ@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">Hi all,
A while back we started annotating intrinsics with new attributes (
<a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D65377">https://reviews.llvm.org/D65377</a>)
After some discussion it was decided it would be good to have an `opt-out`
attribute list for intrinsics. Some attributes that can be added to the
list could be: nosync, nofree, nounwind, willreturn
For now, there are 2 approaches:
1. Filtering opt-out attributes in tablegen source (
<a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D70365">https://reviews.llvm.org/D70365</a>)
2. Having tablegen handle opt-out list (
<a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D70365?id=229732">https://reviews.llvm.org/D70365?id=229732</a>)
How do people feel about these approaches? Is any of the two better than
the other? Maybe I should consider something else?
Thanks,
Stefan
</pre>
</blockquote>
</body>
</html>