<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 6/18/20 11:34 AM, Chris Tetreault
via llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:BYAPR02MB45516C900280F120342C1E28DA9B0@BYAPR02MB4551.namprd02.prod.outlook.com">
<pre class="moz-quote-pre" wrap="">For anybody viewing these failures through some sort of CI system, showing the error first then the input file is more useful for the same reasons you mentioned. Personally, I rarely run filecheck by hand from the command prompt, so your change would make my life worse. Granted, I'm just one person.
</pre>
</blockquote>
<p>I think a lot of people run filecheck by hand, at least everyone
that does not have a proper* CI system set up.<br>
</p>
<p>
<br>
</p>
<blockquote type="cite"
cite="mid:BYAPR02MB45516C900280F120342C1E28DA9B0@BYAPR02MB4551.namprd02.prod.outlook.com">
<pre class="moz-quote-pre" wrap="">The point I'm trying to make is that I don't think it's clear-cut which order is better, so maybe we shouldn't change it. I think it might be fine to add an option to swap the order, but I'd be very sad if it started dumping to some random file by default.
</pre>
</blockquote>
<p>The order can be chosen with a flag and environment variable. We
could even check if the output is a file or not to select a
sensible default.</p>
<p>That said, I think the default should make sense for people that
just download LLVM(, modify something,) and run the tests. If you
set up your CI</p>
<p>you can add proper configuration to change this.</p>
<p><br>
</p>
<p>Cheers,</p>
<p> Johannes<br>
</p>
<p><br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:BYAPR02MB45516C900280F120342C1E28DA9B0@BYAPR02MB4551.namprd02.prod.outlook.com">
<pre class="moz-quote-pre" wrap="">
Thanks,
Christopher Tetreault
From: llvm-dev <a class="moz-txt-link-rfc2396E" href="mailto:llvm-dev-bounces@lists.llvm.org"><llvm-dev-bounces@lists.llvm.org></a> On Behalf Of Sjoerd Meijer via llvm-dev
Sent: Thursday, June 18, 2020 9:16 AM
To: <a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
Subject: [EXT] [llvm-dev] FileCheck
Hello,
I am not sold on FileCheck's new behaviour. For failing tests in verbose mode, it first dump the actual error messages, followed by the annotated input file to FileCheck. The result is I can't immediately see error messages if the input is more than just a few lines long, so I have to scroll all the way up to see the errors, then down again, etc.
I do see some advantages of dumping the input to FileCheck, but an improvement for me would be:
* to dump the input first, then followed by the error message, so that I can the errors first, and then decide to scroll up if I am interested to do so.
* dump it to a separate file (controlled with an option).
I am interested in changing the behaviour, because I think I find setting environment varibale "FILECHECK_OPTS="--dump-input never"" inconvenient.
My 2 pennies.
Sjoerd.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>