<div dir="ltr">Mikhail<div><br></div><div>Firstly let me say that I love the pre-merge checks...but I recently saw something a little odd<div><br></div><div>A recent change I made to clang-format failed the pre-merge checks<div><br></div><div><a href="https://results.llvm-merge-guard.org/BETA_amd64_debian_testing_clang8-1980/summary.html">https://results.llvm-merge-guard.org/BETA_amd64_debian_testing_clang8-1980/summary.html</a> </div><div><br></div><div>This was because as part of the revision I clang-formatted one of the files with a build of clang-format that contained the fix I was making.</div><div><br></div><div><a href="https://reviews.llvm.org/D80950">https://reviews.llvm.org/D80950</a> </div><div><br></div><div>i.e. I was making a change to not just break between "XXX" << "XXX" just because it was 2 strings either side of "<<" and included as way of a demonstration the one other file in lib/Format that violated that rule (because we keep lib/Format 100% clang-format clean)</div><div><br></div><div>The failure from the pre-merge check was: (clang-format.patch)</div><div><br></div><div>diff --git clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.cpp<br>index 9c25e107d44..b8da2c23b55 100644<br>--- clang/lib/Format/UnwrappedLineParser.cpp<br>+++ clang/lib/Format/UnwrappedLineParser.cpp<br>@@ -2744 +2744,2 @@ LLVM_ATTRIBUTE_UNUSED static void printDebugInfo(const UnwrappedLine &Line,<br>- llvm::dbgs() << I->Tok->Tok.getName() << "[" << "T=" << I->Tok->getType()<br>+ llvm::dbgs() << I->Tok->Tok.getName() << "["<br>+ << "T=" << I->Tok->getType()<br></div><div><br></div><div> Reading the documentation for the pre-merge checks it says this...</div><div><p style="box-sizing:border-box;margin-top:16px;margin-bottom:16px;color:rgb(36,41,46);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">Linux</p><ol style="box-sizing:border-box;padding-left:2em;margin-top:0px;margin-bottom:0px;list-style-type:lower-roman;color:rgb(36,41,46);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px"><li style="box-sizing:border-box">Checkout of the branch (from apply patch)</li><li style="box-sizing:border-box;margin-top:0.25em">Guess which projects were modified, run Cmake for those.</li><li style="box-sizing:border-box;margin-top:0.25em">Build the binaries -- <code style="box-sizing:border-box;font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,monospace;font-size:13.6px;padding:0.2em 0.4em;margin:0px;background-color:rgba(27,31,35,0.05);border-radius:3px">ninja all</code></li><li style="box-sizing:border-box;margin-top:0.25em">Run the test suite -- <code style="box-sizing:border-box;font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,monospace;font-size:13.6px;padding:0.2em 0.4em;margin:0px;background-color:rgba(27,31,35,0.05);border-radius:3px">ninja check-all</code></li><li style="box-sizing:border-box;margin-top:0.25em">Run clang-format and clang-tidy on the diff.</li><li style="box-sizing:border-box;margin-top:0.25em">Upload build results to Phabricator</li></ol></div><div><br></div><div>However could you clarify: if step v.</div><div><br></div><div>> Run clang-format and clang-tidy on the diff. <br></div><div><br></div><div>Uses the clang-format/clang-tidy binaries either</div><div><br></div><div>a) built at step iii. or </div><div>b) if you use a pre-existing version? </div><div><br></div></div><div>If b) which version do you use?</div><div><br></div><div>a) last successful built</div><div>b) tip of existing committed master</div><div>c) last released version.</div><div><br></div><div>Many thank in advance</div><div><br></div><div>MyDeveloperDay.</div><div><br></div><div><br></div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 3, 2020 at 1:40 PM Mikhail Goncharov via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hello friends,</div><div><br></div><div>We are switching the pre-merge test build system from Jenkins to Buildkite.</div><div>That will give authors and reviewers more transparency on what's going on during the build process. For now only members of "pre-merge beta testing" [0] group are affected.</div><div><br></div><div>As usual, please tell us if something is off.</div><div><br></div><div>[0] <a href="https://reviews.llvm.org/project/view/78/" target="_blank">https://reviews.llvm.org/project/view/78/</a></div> <br clear="all"><div><div dir="ltr"><div dir="ltr">Kind regards,<div>Mikhail</div></div></div></div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>