<div dir="ltr"><div dir="ltr">On Tue, May 12, 2020 at 1:50 PM Johannes Doerfert via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p><font face="Hack Nerd Font Mono">@Zola, Eric, <br>
</font></p>
<p><font face="Hack Nerd Font Mono"><br>
</font></p>
<p><font face="Hack Nerd Font Mono">I really feel the communication
and reasoning here is problematic.</font></p>
<p><font face="Hack Nerd Font Mono">From my perspective, you removed
stuff "we don't need", ignoring whether it is used, and then let
people figure out how to deal with the result.</font></p>
<p><font face="Hack Nerd Font Mono">What I most dislike about the
process most is how questions and concerns are then ignored or
played down.<br></font></p></div></blockquote><div>Honestly, I think Zola did more than I'd have expected to be done for this - sending out the proposal (to llvm-dev, not just llvm-commits, even) & waiting a week for feedback.<br><br>Suggesting that LLVM developers (the, apparently rather small (based on feedback from before/after this change) number of them) migrate to the standard git functionality for contributing to git projects seems like it's in line with discussions I recall seeing before and after the git migration - that the git-llvm scripts were migration tools (there was some discussion about whether they might be used for more post-migration, to enforce certain constraints, etc - but those ideas were not accepted/moved forward with).<br><br>I have some concern about adding these scripts back in as they may lead to greater divergence in developer experience and/or become less relevant over time and a weird thing for newcomers to stumble over, perhaps. But I don't feel /that/ strongly, if other folks particularly prefer using them, they seem mostly harmless.<br><br>- Dave</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><p><font face="Hack Nerd Font Mono">
</font></p>
<p><font face="Hack Nerd Font Mono"><br>
</font></p>
<p><font face="Hack Nerd Font Mono">Thanks,</font></p>
<p><font face="Hack Nerd Font Mono"> Johannes</font></p>
<p><font face="Hack Nerd Font Mono"><br>
</font></p>
<p><font face="Hack Nerd Font Mono"></font><br>
</p>
<div>On 5/12/20 2:10 PM, Keane, Erich via
llvm-dev wrote:<br>
</div>
<blockquote type="cite">
<pre>FWIW, if you do your development in git-branches, it is a little more than that. IT ends up being:
git push origin HEAD:master.
Which is somewhat easy to mess up. For example, I inverted the HEAD/master at one point and ended up creating a branch named “HEAD” at one point.
From: llvm-dev <a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank"><llvm-dev-bounces@lists.llvm.org></a> On Behalf Of Eric Christopher via llvm-dev
Sent: Tuesday, May 12, 2020 11:59 AM
To: Hiroshi Yamauchi <a href="mailto:yamauchi@google.com" target="_blank"><yamauchi@google.com></a>
Cc: llvm-dev <a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><llvm-dev@lists.llvm.org></a>
Subject: Re: [llvm-dev] RFC: Deleting git-svn folder (git-llvm, git-svnrevert, git-svnup)
Just push :)
On Tue, May 12, 2020, 8:46 AM Hiroshi Yamauchi <<a href="mailto:yamauchi@google.com" target="_blank">yamauchi@google.com</a><a href="mailto:yamauchi@google.com" target="_blank"><mailto:yamauchi@google.com></a>> wrote:
I was also using "git llvm push" to commit, sort of out of habit. What's a recommended, alternative way to push?
On Mon, May 11, 2020 at 11:57 AM Johannes Doerfert via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><mailto:llvm-dev@lists.llvm.org></a>> wrote:
I was actually using `git llvm` in my daily workflow.
Could you explain why we want people to move away from that script?
In addition to the convenience, it prevented me from accidentally creating a new branch (which I did before with push once).
Cheers,
Johannes
On 5/11/20 11:43 AM, Zola Bridges via llvm-dev wrote:
Deleted this morning. Thanks!
Zola Bridges
On Mon, May 4, 2020 at 2:35 PM Eric Christopher <a href="mailto:echristo@gmail.com" target="_blank"><echristo@gmail.com></a><a href="mailto:echristo@gmail.com" target="_blank"><mailto:echristo@gmail.com></a> wrote:
Giving at least one explicit:
Sounds good to me.
On Mon, May 4, 2020 at 12:01 PM Zola Bridges via llvm-dev <
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><mailto:llvm-dev@lists.llvm.org></a>> wrote:
Here is a link to the patch: <a href="https://reviews.llvm.org/D79348" target="_blank">https://reviews.llvm.org/D79348</a>
Zola Bridges
On Mon, May 4, 2020 at 11:50 AM Zola Bridges <a href="mailto:zbrid@google.com" target="_blank"><zbrid@google.com></a><a href="mailto:zbrid@google.com" target="_blank"><mailto:zbrid@google.com></a> wrote:
Hi everyone,
I would like to delete this folder of svn to git migration tools.
<a href="https://github.com/llvm/llvm-project/tree/master/llvm/utils/git-svn" target="_blank">https://github.com/llvm/llvm-project/tree/master/llvm/utils/git-svn</a>
My understanding of these tools is that they were useful for when we
were migrating between Git and SVN, but now, since the migration is
complete, they can be deleted as they are either unnecessary or there are
other more common workflow options (ie git llvm push --> git push).
- Is there any reason these scripts should continue to exist that
I'm not aware of?
- I'd like to delete these next Monday. Is that timeline
unacceptable to anyone?
Thanks,
Zola Bridges
_______________________________________________
LLVM Developers mailing list
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><mailto:llvm-dev@lists.llvm.org></a>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
_______________________________________________
LLVM Developers mailing list
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><mailto:llvm-dev@lists.llvm.org></a>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
_______________________________________________
LLVM Developers mailing list
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><mailto:llvm-dev@lists.llvm.org></a>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
LLVM Developers mailing list
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>