<div><div dir="auto">Now that D77144 has landed; any thoughts regarding what I suggested? Using UseDefLists.h?</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 15 Apr 2020 at 15:32 Ehud Katz <<a href="mailto:ehudkatz@gmail.com">ehudkatz@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Maybe we can utilize the implementation in <a href="https://github.com/llvm/llvm-project/blob/master/mlir/include/mlir/IR/UseDefLists.h" target="_blank">mlir/IR/UseDefLists.h</a> in here (clearly it is superior to `llvm::Use`) ?<div>By that we will have the same code base (instead of duplicate implementations of Use-Lists).<br><div><a href="https://reviews.llvm.org/D77144" style="font-family:Calibri,sans-serif;font-size:14.6667px" target="_blank">D77144</a> should definitely go in, first, though.<br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 14, 2020 at 8:32 PM Eric Christopher via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">Yes please. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 14, 2020, 5:02 AM <a href="mailto:Tyker1@outlook.com" target="_blank">Tyker1@outlook.com</a> via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
a bit of time has passed and there to my knowledge still no strong arguments against removing it.</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
is everyone OK to proceed with the removal ?</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
Gauthier<br>
</div>
<div id="m_3867379360421830398gmail-m_-6128509314208388409m_-1145504123343452178appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="m_3867379360421830398gmail-m_-6128509314208388409m_-1145504123343452178divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Chris Lattner <<a href="mailto:clattner@nondot.org" rel="noreferrer" target="_blank">clattner@nondot.org</a>><br>
<b>Sent:</b> Saturday, April 4, 2020 7:40 PM<br>
<b>To:</b> Johannes Doerfert <<a href="mailto:johannesdoerfert@gmail.com" rel="noreferrer" target="_blank">johannesdoerfert@gmail.com</a>><br>
<b>Cc:</b> Ehud Katz <<a href="mailto:ehudkatz@gmail.com" rel="noreferrer" target="_blank">ehudkatz@gmail.com</a>>; <a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a> <<a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a>>; <a href="mailto:Tyker1@outlook.com" rel="noreferrer" target="_blank">Tyker1@outlook.com</a> <<a href="mailto:Tyker1@outlook.com" rel="noreferrer" target="_blank">Tyker1@outlook.com</a>><br>
<b>Subject:</b> Re: [llvm-dev] [RFC] Removing Waymarking from Use.</font>
<div> </div>
</div>
<div><br>
<div><br>
<blockquote type="cite">
<div>On Apr 3, 2020, at 11:06 AM, Johannes Doerfert <<a href="mailto:johannesdoerfert@gmail.com" rel="noreferrer" target="_blank">johannesdoerfert@gmail.com</a>> wrote:</div>
<br>
<div>
<div>
<blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">
<pre><br>
Is it worth it? I think it is. But I am not sure I see the whole picture -
are there low-memory systems that need to run LLVM on?
I am not sure what needs to be done to approve such a fundamental change;
especially when we can't prove the Waymarking was needed at all.</pre>
</blockquote>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">
I guess if no-one brings forth arguments (= results) for keeping it and</p>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">
people continue to support replacing it, we will replace it. There should</p>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">
be a grace period in which people have the chance to do their benchmarking</p>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">
(basically what is happening), but I don't recall a problem being reported yet.</p>
</div>
</div>
</blockquote>
<div><br>
</div>
I agree. I’m not hearing strong arguments to retain it, so let's remove it. Worst case, we can always reinstate it if there is a good reason discovered down the line. Thank you!</div>
<div><br>
</div>
<div>-Chris</div>
</div>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
</blockquote></div></div>