<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <<a href="mailto:llvmdev@meinersbur.de">llvmdev@meinersbur.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I was always assuming that the suggested commit is assembled in the<br>
PHP code run by arcanist command run locally. If indeed the arc<br>
command requests the commit message from the server,</blockquote><div><br></div><div>I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed:</div><div><br></div><div><a href="https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757">https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> we could do some<br>
additional things:<br>
<br>
 * Remove "Summary:" in front of message<br>
 * Line break after 72 columns<br>
 * Convert summary markdown formatting to plain texts (e.g. remove<br>
backticks; I don't know any git client that renders as markdown)<br>
 * Add/check existence of [component] tag<br>
<br>
Alternatively, we could make an upstream feature request<br></blockquote><div><br></div><div>From what I can tell, upstream doesn't seem /that/ interested in it being any more than a one-off thing:</div><div><br></div><div><a href="https://secure.phabricator.com/Q268">https://secure.phabricator.com/Q268</a><br></div><div><a href="https://secure.phabricator.com/T12276">https://secure.phabricator.com/T12276</a><br></div><div><a href="https://secure.phabricator.com/T11864">https://secure.phabricator.com/T11864</a></div><div><br></div><div>Jon</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Michael<br>
<br>
Am Do., 9. Apr. 2020 um 11:16 Uhr schrieb Jon Roelofs via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>:<br>
><br>
> Can we fix this in <a href="http://reviews.llvm.org" rel="noreferrer" target="_blank">reviews.llvm.org</a>'s fork of phab?<br>
><br>
> <a href="https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php" rel="noreferrer" target="_blank">https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php</a><br>
><br>
> Seems straightforward(-ish) to drop the relevant fields there, that way `arc land` automatically DTRT.<br>
><br>
> Jon<br>
</blockquote></div></div>