<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">On Apr 1, 2020, at 5:51 AM, <a href="mailto:Tyker1@outlook.com" class="">Tyker1@outlook.com</a> via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""><div><blockquote type="cite" class=""><br class="Apple-interchange-newline"><div class=""><div style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; background-color: rgb(255, 255, 255);" class=""><p style="margin: 0in 0in 8pt; font-size: 12pt; font-family: "Times New Roman", serif; line-height: 16.959999084472656px;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi llvm-dev,</span></p><p style="margin: 0in 0in 8pt; font-size: 12pt; font-family: "Times New Roman", serif; line-height: 16.959999084472656px;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">I have a patch open for review that removes waymarking<span class="Apple-converted-space"> </span><a href="https://reviews.llvm.org/D77144" class="">https://reviews.llvm.org/D77144</a>.</span></p><p style="margin: 0in 0in 8pt; font-size: 12pt; font-family: "Times New Roman", serif; line-height: 16.959999084472656px;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">This patch removes waymarking and replaces it with storing a pointer to the User in the Use.<br class=""> when compiling the CTMark tests of the test suite, this give an average of +1.8% max memory use and -1.1% compile time.</span></p><p style="margin: 0in 0in 8pt; font-size: 12pt; font-family: "Times New Roman", serif; line-height: 16.959999084472656px;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Removing Waymarking also simplifies the code of Use and User.</span></p></div></div></blockquote><br class=""></div><div>Waymarking is very complicated, and I’d be generally +1 on removing it if it is not paying for itself. It is also nice to see compiler speedups!</div><div><br class=""></div><div>I’m curious about kimwitu++ though - when waymarking initially landed, it was a significant memory size win for that. Do you have any idea why you’re not seeing the same difference? Is it possible that different things were being measured back then?</div><div><br class=""></div><div>-Chris</div></body></html>