<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 24, 2020, at 08:50, Thomas Faingnaert <<a href="mailto:thomas.faingnaert@hotmail.com" class="">thomas.faingnaert@hotmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Helvetica, sans-serif; font-size: 12pt;" class=""><span class="">It appears that this behaviour of InstCombine is at least somewhat intended, as there are several tests that fail after the change mentioned before:<span class="Apple-converted-space"> </span></span><span style="font-family: Consolas, Courier, monospace;" class="">cast.ll</span><span class="">,</span><span style="font-family: Consolas, Courier, monospace;" class="">gep-addrspace.ll</span><span class=""><span class="Apple-converted-space"> </span>and<span class="Apple-converted-space"> </span></span><span style="font-family: Consolas, Courier, monospace;" class="">getelementptr.ll</span><span class=""><span class="Apple-converted-space"> </span>in<span class="Apple-converted-space"> </span></span><span style="font-family: Consolas, Courier, monospace;" class="">test/Transforms/InstCombine</span><span class="">.<br class=""></span><div class="">I feel a little uncomfortable applying the patch after knowing this, and removing those tests doesn't seem like a great solution.<br class=""></div><div class="">What are your thoughts?<br class=""></div></div></div></blockquote><div><br class=""></div>These are checking for the current behavior, it’s only natural tests would need updating for this change. You should just update them to show the new result<br class=""></div><div><br class=""></div><div>-Matt</div></body></html>