<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2020, at 18:48, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'm one of those people ;)</div></div></blockquote><div><br class=""></div><div>That's not something to be proud of if you expect a maintainer to commit on your behalf. If you commit yourself, then whatever.</div><div><br class=""></div><div>Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 3, 2020 at 2:20 PM Louis Dionne via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br class="">
<br class="">
> On Mar 3, 2020, at 17:16, Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank" class="">smeenai@fb.com</a>> wrote:<br class="">
> <br class="">
> `arc patch` should preserve the author information in the original commit, if there was any. At least it has in my experience.<br class="">
<br class="">
Yes, but I think people can upload raw patches to Phabricator without using `arc diff`. I know I ran into one of these just last week where I used Johannes' script (thanks!) and ended up still having to find the committer's email by other means.<br class="">
<br class="">
Louis<br class="">
<br class="">
> <br class="">
> On 3/3/20, 1:44 PM, "llvm-dev on behalf of Louis Dionne via llvm-dev" <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank" class="">llvm-dev-bounces@lists.llvm.org</a> on behalf of <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class="">
> <br class="">
> <br class="">
> <br class="">
>> On Feb 20, 2020, at 14:25, Johannes Doerfert <<a href="mailto:johannesdoerfert@gmail.com" target="_blank" class="">johannesdoerfert@gmail.com</a>> wrote:<br class="">
>> <br class="">
>> On 02/20, Louis Dionne via llvm-dev wrote:<br class="">
>>> I know there has been significant discussion about "moving" from<br class="">
>>> Phabricator to GitHub reviews and pull requests, etc. I'm not<br class="">
>>> suggesting that we do anything in terms of global LLVM policy.<br class="">
>>> However, as a maintainer of libc++, I commit __a lot__ of other<br class="">
>>> people's code for them. It would be a huge time saver for me if I<br class="">
>>> could nicely suggest to contributors (not force them) to use PRs<br class="">
>>> instead of Phabricator for their contributions. It would also handle<br class="">
>>> commit attribution properly, which is a pain right now.<br class="">
>> <br class="">
>> Don't take this as me telling you it is "actually simple". I am<br class="">
>> interested what about the contribution is problematic? If the libc++<br class="">
>> system doesn't have more requirements than the rest of LLVM there might<br class="">
>> be ways to make it less painful. FWIW, here is what I do, and I know not<br class="">
>> everyone wants to use `arc`. Ina script this could potentially reduce<br class="">
>> the pain. Again, this is not meant to tell you it is simple or your<br class="">
>> problems are not real.<br class="">
>> <br class="">
>> arc patch DXXXX<br class="">
>> git pull --rebase origin master<br class="">
>> arc amend<br class="">
>> arcfilter // see below<br class="">
>> git llvm push master<br class="">
>> <br class="">
>> <br class="">
>> arcfilter () { git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:/' | git commit --amend -F - }<br class="">
> <br class="">
> Thanks, this indeed solves some of my problems, however not entirely. When people submit contributions without an email address, I still have to do some digging to find out how to attribute the change. This shouldn't be something I even have to think about.<br class="">
> <br class="">
> Louis<br class="">
> <br class="">
>> <br class="">
>>> Would it be possible to allow GitHub PRs to be submitted on the<br class="">
>>> monorepo so as to let individual sub-projects deal with it however<br class="">
>>> they please? I've spoken to numerous people involved in libc++<br class="">
>>> development and they would like to start submitting PRs (and for the<br class="">
>>> others, we'll still accept Phabricator reviews). Perhaps it is<br class="">
>>> possible to setup some kind of filter such that PRs touching only<br class="">
>>> libcxx/ and libcxxabi/ can be submitted, but otherwise they're closed<br class="">
>>> by the bot?<br class="">
>> <br class="">
>> TBH, I feel this is yet another way of splitting the community and in<br class="">
>> the end complicating things even more. I mean, since recently if you<br class="">
>> want to ask a question there were the *-dev lists and the IRC. Now we<br class="">
>> have discourse, discord on top of that with some people monitoring only<br class="">
>> one of these and others required to monitor both. Duplicating the way we<br class="">
>> do reviews is similarly going to require people that want to be informed<br class="">
>> to duplicate their lookups.<br class="">
>> <br class="">
>> Cheers,<br class="">
>> Johannes<br class="">
>> <br class="">
> <br class="">
> _______________________________________________<br class="">
> LLVM Developers mailing list<br class="">
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=hELRqZwTPoZ26mqt3iDgkwh-f8LXjZ8HNkBIKKEysGI&s=RURnqL7Gh1L4cfsZvmuLOkD0YL9PNMBiJLJ1w0ii9Yw&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=hELRqZwTPoZ26mqt3iDgkwh-f8LXjZ8HNkBIKKEysGI&s=RURnqL7Gh1L4cfsZvmuLOkD0YL9PNMBiJLJ1w0ii9Yw&e=</a> <br class="">
> <br class="">
> <br class="">
<br class="">
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>