<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-7">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi, Stefanos,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Documentation updates should also be reviewed. In this case, I think that it makes the most sense to reference our new code-review documentation that should be committed soon (<a href="https://reviews.llvm.org/D71916" id="LPlnk584538">https://reviews.llvm.org/D71916</a>).
It might actually be best to remove some of that developer-policy text and simply reference the new code-review documentation in order to prevent confusion.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hal</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div class="BodyFragment"><font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hal Finkel<br>
Lead, Compiler Technology and Programming Languages<br>
Leadership Computing Facility<br>
Argonne National Laboratory</div>
</span></font></div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> llvm-dev <llvm-dev-bounces@lists.llvm.org> on behalf of Stefanos Baziotis via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Sent:</b> Sunday, March 1, 2020 9:58 AM<br>
<b>To:</b> Florian Hahn <florian_hahn@apple.com><br>
<b>Cc:</b> llvm-dev@lists.llvm.org <llvm-dev@lists.llvm.org><br>
<b>Subject:</b> Re: [llvm-dev] Commits as new contributor</font>
<div> </div>
</div>
<div>
<div dir="ltr">Thanks to both! I'll update the docs.<br>
<br>
Best,<br>
Stefanos<br>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">Στις Κυρ, 1 Μαρ 2020 στις 5:24 μ.μ., ο/η Florian Hahn <<a href="mailto:florian_hahn@apple.com">florian_hahn@apple.com</a>> έγραψε:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="auto">
<div dir="ltr">Hi,</div>
<div dir="ltr"><br>
</div>
<div dir="ltr"><br>
<blockquote type="cite">On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
</blockquote>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr"><br>
I recently was granted commit access, but I'm not really sure what is the process.<br>
The developer policy states:<br>
"<span style="text-align:left; color:rgb(0,0,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-family:"Lucida Grande","Lucida Sans Unicode",Geneva,Verdana,sans-serif; font-size:14px; font-style:normal; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; display:inline; white-space:normal; float:none; background-color:rgb(255,255,255)">You
are granted </span><em style="text-align:left; color:rgb(0,0,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-size:14px; font-style:italic; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; white-space:normal">commit-after-approval</em><span style="text-align:left; color:rgb(0,0,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-family:"Lucida Grande","Lucida Sans Unicode",Geneva,Verdana,sans-serif; font-size:14px; font-style:normal; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; display:inline; white-space:normal; float:none; background-color:rgb(255,255,255)">
to all parts of LLVM. To get approval, submit a </span><a href="https://llvm.org/docs/DeveloperPolicy.html#patch" target="_blank" style="text-align:left; color:rgb(202,121,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-size:14px; font-style:normal; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; white-space:normal">patch</a><span style="text-align:left; color:rgb(0,0,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-family:"Lucida Grande","Lucida Sans Unicode",Geneva,Verdana,sans-serif; font-size:14px; font-style:normal; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; display:inline; white-space:normal; float:none; background-color:rgb(255,255,255)">
to </span><a href="http://lists.llvm.org/mailman/listinfo/llvm-commits" target="_blank" style="text-align:left; color:rgb(202,121,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-size:14px; font-style:normal; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; white-space:normal">llvm-commits</a><span style="text-align:left; color:rgb(0,0,0); text-transform:none; text-indent:0px; letter-spacing:normal; font-family:"Lucida Grande","Lucida Sans Unicode",Geneva,Verdana,sans-serif; font-size:14px; font-style:normal; font-variant:normal; font-weight:400; text-decoration:none; word-spacing:0px; display:inline; white-space:normal; float:none; background-color:rgb(255,255,255)">.
When approved, you may commit it yourself."<br>
<br>
Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator) ?<br>
<br>
</span></div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div><br>
</div>
Approval via Phabricator is fine. LLVM-commits (or the relevant sub project list) should always be a subscriber of reviews in Phabricator, so the approval is recorded there too.
<div><br>
</div>
<div>It may be worth updating the wording in the docs to explicitly mention Phabricator.</div>
<div><br>
</div>
<div>Cheers</div>
<div>Florian </div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</body>
</html>