<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">So just to summarise what happened outside the mailing list:<div class="">* We removed llvm-go</div><div class="">* We also removed/fixed several things that referenced llvm-go in the following days.</div><div class="">* We reverted all of that (apparently to test LLVM’s Go bindings with llvm-go instead of system Go)</div><div class=""><br class=""></div><div class="">So from what I understand the only reason llvm-go is in tree is to test the bindings? It’s also not clear to me why we can’t use the normal go compiler for testing them (like we test the ocaml bindings with the system ocamlc).</div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 10. Feb 2020, at 19:12, Eric Christopher via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Done thusly:</div><div class=""><br class=""></div>echristo@athyra ~/r/llvm-project> git push<br class="">To <a href="http://github.com" class="">github.com</a>:llvm/llvm-project.git<br class=""> 936d1427da1..372bfc65deb master -> master<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 10, 2020 at 10:02 AM Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">OK. I'll get it.<div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 10, 2020 at 9:58 AM Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank" class="">peter@pcc.me.uk</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">Sure, that's fine with me.<div class=""><br class=""></div><div class="">Peter</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 10, 2020 at 9:57 AM Eric Christopher via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">Calling pcc real fast :)<div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 10, 2020 at 9:49 AM David Blaikie via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">Yep - delete it. If someone wants it back they can resurrect it from version control & explain why it's worth adding back in.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 10, 2020 at 9:17 AM Jonas Devlieghere via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thanks for bringing this up! Strong +1 from me for all the reasons<br class="">
you've mentioned.<br class="">
<br class="">
On Mon, Feb 10, 2020 at 8:42 AM Raphael Isemann via llvm-dev<br class="">
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Hi all,<br class="">
><br class="">
> the monorepo contains a Go frontend called 'llgo' (in the llgo/ top<br class="">
> level folder). It apparently hasn't been active since 2017 and before<br class="">
> that it wasn't very active either (there were 13 commits in 2016<br class="">
> apparently, most of it minor fixes).<br class="">
><br class="">
> I would propose that we remove it from the monorepo for the following reasons:<br class="">
><br class="">
> * It is apparently unmaintained.<br class="">
> * It only supports a long outdated Go version (1.5 while latest is 1.13 or so).<br class="">
> * It doesn't build (at least on my machine) due to runtime errors (the<br class="">
> build log is really unhelpful in telling me what actually went wrong).<br class="">
> In general the build system is kinda flawed as it seems to just<br class="">
> manually run 'make' as a single custom build step (even with a -GNinja<br class="">
> build).<br class="">
> * It contains a full copy of Mark Twain's novel "The Adventures of Tom<br class="">
> Sawyer". It gets really tiring to blacklist this file on my desktop<br class="">
> search engine as it otherwise constantly comes up in unrelated<br class="">
> searches for words that are by accident in this novel.<br class="">
> * The sources of multiple third party libraries are copied into its<br class="">
> third party directory. It would be nice not to have random code in the<br class="">
> LLVM repo under a different license than LLVM.<br class="">
> * It's the only reason why we maintain some Go support in LLVM's CMake<br class="">
> (like llvm_add_go_executable ).<br class="">
><br class="">
> Thoughts?<br class="">
><br class="">
> - Raphael<br class="">
> _______________________________________________<br class="">
> LLVM Developers mailing list<br class="">
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div>
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div>
_______________________________________________<br class="">
LLVM Developers mailing list<br class="">
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="">
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class=""><div dir="ltr" class="">-- <div class="">Peter</div></div></div>
</blockquote></div>
</blockquote></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></div></body></html>