<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Thanks for clarifying. I had skimmed the commits and had the
exact same (wrong) impression. :)</p>
<p>Philip<br>
</p>
<div class="moz-cite-prefix">On 2/14/20 6:39 AM, James Y Knight via
llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAA2zVHo9g=LcxPFoFFDP9rBp3DMnQtossuW3ocqr5-x22p+Wiw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Nope, it wasn't all reverted -- the llgo
implementation remains deleted.
<div><br>
</div>
<div>There's been some confusion borne out of unfortunate naming
-- only the file "llvm/tools/llvm-go/llvm-go.go" was
reinstated. Despite its confusing name, this tool is <i>not</i> a
go implementation, and has effectively nothing to do with
llgo. It's only a tiny utility script used by the llvm build
process for running go programs with the desired set of
environment variables.
<div><br>
</div>
<div>From the comment in the file: </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">This tool lets us build
LLVM components within the tree by setting up a $GOPATH that
resembles a tree fetched in the normal way with "go get".</blockquote>
<div><br>
</div>
<div>(FWIW, I had the exact same reaction as you, before
realizing the above.)</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Feb 14, 2020 at 2:46
AM Raphael “Teemperor” Isemann via llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org" moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div style="overflow-wrap: break-word;">So just to summarise
what happened outside the mailing list:
<div>* We removed llvm-go</div>
<div>* We also removed/fixed several things that referenced
llvm-go in the following days.</div>
<div>* We reverted all of that (apparently to test LLVM’s Go
bindings with llvm-go instead of system Go)</div>
<div><br>
</div>
<div>So from what I understand the only reason llvm-go is in
tree is to test the bindings? It’s also not clear to me
why we can’t use the normal go compiler for testing them
(like we test the ocaml bindings with the system ocamlc).</div>
<div>
<div><br>
<blockquote type="cite">
<div>On 10. Feb 2020, at 19:12, Eric Christopher via
llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:</div>
<br>
<div>
<div dir="ltr">
<div>Done thusly:</div>
<div><br>
</div>
echristo@athyra ~/r/llvm-project> git push<br>
To <a href="http://github.com" target="_blank"
moz-do-not-send="true">github.com</a>:llvm/llvm-project.git<br>
936d1427da1..372bfc65deb master -> master<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Feb 10,
2020 at 10:02 AM Eric Christopher <<a
href="mailto:echristo@gmail.com"
target="_blank" moz-do-not-send="true">echristo@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">OK. I'll get it.
<div><br>
</div>
<div>-eric</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Feb
10, 2020 at 9:58 AM Peter Collingbourne <<a
href="mailto:peter@pcc.me.uk"
target="_blank" moz-do-not-send="true">peter@pcc.me.uk</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Sure, that's fine with me.
<div><br>
</div>
<div>Peter</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon,
Feb 10, 2020 at 9:57 AM Eric Christopher
via llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Calling pcc real fast :)
<div><br>
</div>
<div>-eric</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On
Mon, Feb 10, 2020 at 9:49 AM David
Blaikie via llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Yep - delete it. If
someone wants it back they can
resurrect it from version control
& explain why it's worth
adding back in.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On
Mon, Feb 10, 2020 at 9:17 AM
Jonas Devlieghere via llvm-dev
<<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Thanks
for bringing this up! Strong +1
from me for all the reasons<br>
you've mentioned.<br>
<br>
On Mon, Feb 10, 2020 at 8:42 AM
Raphael Isemann via llvm-dev<br>
<<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<br>
><br>
> Hi all,<br>
><br>
> the monorepo contains a Go
frontend called 'llgo' (in the
llgo/ top<br>
> level folder). It
apparently hasn't been active
since 2017 and before<br>
> that it wasn't very active
either (there were 13 commits in
2016<br>
> apparently, most of it
minor fixes).<br>
><br>
> I would propose that we
remove it from the monorepo for
the following reasons:<br>
><br>
> * It is apparently
unmaintained.<br>
> * It only supports a long
outdated Go version (1.5 while
latest is 1.13 or so).<br>
> * It doesn't build (at
least on my machine) due to
runtime errors (the<br>
> build log is really
unhelpful in telling me what
actually went wrong).<br>
> In general the build system
is kinda flawed as it seems to
just<br>
> manually run 'make' as a
single custom build step (even
with a -GNinja<br>
> build).<br>
> * It contains a full copy
of Mark Twain's novel "The
Adventures of Tom<br>
> Sawyer". It gets really
tiring to blacklist this file on
my desktop<br>
> search engine as it
otherwise constantly comes up in
unrelated<br>
> searches for words that are
by accident in this novel.<br>
> * The sources of multiple
third party libraries are copied
into its<br>
> third party directory. It
would be nice not to have random
code in the<br>
> LLVM repo under a different
license than LLVM.<br>
> * It's the only reason why
we maintain some Go support in
LLVM's CMake<br>
> (like
llvm_add_go_executable ).<br>
><br>
> Thoughts?<br>
><br>
> - Raphael<br>
>
_______________________________________________<br>
> LLVM Developers mailing
list<br>
> <a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
> <a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer"
target="_blank"
moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer"
target="_blank"
moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a
href="mailto:llvm-dev@lists.llvm.org"
target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr">--
<div>Peter</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
target="_blank" moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>