<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 12, 2020, at 08:45, James Henderson via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Hi all,</div><div class=""><br class=""></div><div class="">I recently, on behalf of a new LLVM contributor, pushed commit
<a href="https://reviews.llvm.org/rG740bc366d44ccd41161739bc1d4b447cd49aba65" class="gmail-phui-handle">740bc366d44c</a>, which broke an in-tree test for the AVR backend (see <a href="http://45.33.8.238/mac/7865/step_11.txt" class="">http://45.33.8.238/mac/7865/step_11.txt</a>). On the review <a href="https://reviews.llvm.org/D72992" class="">https://reviews.llvm.org/D72992</a>, a request was made to fix the test or revert the change. This test didn't fail locally or on any of the build bots, because the AVR backend is experimental and does not run even for build that has all normal targets enabled).</div><div class=""><br class=""></div><div class="">The fix in this case is simple, and I don't have any real issue in making it, but there's a wider principle here: if an in-tree test fails but only when experimental items are enabled, whose responsibility is it to fix the issue? I'm inclined to think that it's the responsibility of whoever maintains the experimental target and/or the bot maintainer where the experimental target is enabled, and NOT the regular developer.</div><div class=""><br class=""></div><div class="">Thoughts?</div><div class=""><br class=""></div><div class=""><br class=""></div></div></div></blockquote><br class=""></div><div>This is why I have never liked the experimental target approach. Having experimental targets only increases the burden for other developers. Many times I’ve changed some target API, and broken the build for the experimental targets. It creates strictly more work for me, since now I have to see the build bot failed, and then go back to do a new build with the targets enabled to fix it. It would be easier to just always build all targets by default.</div><div><br class=""></div><div>-Matt</div></body></html>