<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 2/10/20 2:35 PM, Alina Sbirlea
wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAHk2dbrfQbuqYb17JEfrCj-DxtiLrj9V+u7dvVZ3Wo2fyWH3tw@mail.gmail.com">
<div dir="ltr">Hi,
<div><br>
</div>
<div>Here's a tentative patch of the changes for this: <a href="https://reviews.llvm.org/D74353" moz-do-not-send="true">D74353</a>.</div>
</div>
</blockquote>
<p><br>
</p>
<p>I suppose that, as expected, it's invalidated less often this
way. Given that it's generally stateless, does this really
represent a cost savings?</p>
<p> -Hal<br>
</p>
<p><br>
</p>
<blockquote type="cite" cite="mid:CAHk2dbrfQbuqYb17JEfrCj-DxtiLrj9V+u7dvVZ3Wo2fyWH3tw@mail.gmail.com">
<div dir="ltr">
<div><br>
</div>
<div>Thank you,</div>
<div>Alina</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Feb 10, 2020 at 11:34
AM Alina Sbirlea <<a href="mailto:alina.sbirlea@gmail.com" moz-do-not-send="true">alina.sbirlea@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Hi,<br>
</div>
<div><br>
</div>
<div>I'd like to understand if it makes sense to keep
BasicAA as a not CFG-only pass, or if it can be updated to
CFG-only. The change was made in <a href="https://reviews.llvm.org/D44564" target="_blank" moz-do-not-send="true">D44564</a>.</div>
<div><br>
</div>
<div>From what I gathered the motivation was <span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px">PhiValuesAnalysis
not being properly updated, and BasicAA having an
instance of it. </span></div>
<div><span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px">PhiValuesAnalysis
now uses callback values to invalidate deleted values (</span><a href="https://reviews.llvm.org/rL340613" target="_blank" moz-do-not-send="true">r340613</a>),<span style="font-size:13px;color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif"> </span><span style="font-size:13px;color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif">PhiValuesAnalysis
is also being updated in MemDepAnalysis (</span><a href="https://reviews.llvm.org/D48489" target="_blank" moz-do-not-send="true">D48489</a>) <span style="font-size:13px;color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif">and BasicAA is
invalidated if </span><span style="font-size:13px;color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif">PhiValuesAnalysis
gets invalidated.</span></div>
<div><span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px"><br>
</span></div>
<div><span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px">I
may not have the full context here, so I'd like some
feedback: does it make sense to make BasicAA a CFG-only
pass again?</span></div>
<div><span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px"><br>
</span></div>
<div><span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px">Thank
you,</span></div>
<div><span style="color:rgb(0,0,0);font-family:"Segoe
UI","Segoe UI Emoji","Segoe UI
Symbol",Lato,"Helvetica
Neue",Helvetica,Arial,sans-serif;font-size:13px">Alina</span></div>
</div>
</blockquote>
</div>
</blockquote>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>