<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 31, 2020, at 14:46, Petr Hosek via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">When committing changes on behalf of other contributors, I've started setting the author in Git to be the change author. I think that's better for attribution than just including "Patch By: username" in the message which is default for arc, especially now that we're finally using Git.</div></div></blockquote><div><br class=""></div>We changed the policy to use the Committer and Author fields correctly a little while back. <a href="https://llvm.org/docs/DeveloperPolicy.html#commit-messages" class="">https://llvm.org/docs/DeveloperPolicy.html#commit-messages</a> (it's the second bullet point).<br class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">However, I've noticed that when the change breaks bots, emails are sent only to the author, not the committer. I think that's counterintuitive because the author in these cases doesn't even have permission to revert the change (otherwise they would have pushed the change themselves).</div><div class=""><br class=""></div><div class="">Can we modify bot notifications to either send the email to committer or (preferably) both?</div></div></div></blockquote><div><br class=""></div><div>+1.</div><div><br class=""></div><div>It looks like we might need a fairly big update to buildbot though (unless we do it ourselves). We're on 0.85 and (based on a quick look) it seems some of the groundwork went into buildbot last year: <a href="https://github.com/buildbot/buildbot/pull/4841" class="">https://github.com/buildbot/buildbot/pull/4841</a> (Add committer field to changes). Based on the date, we probably need buildbot 2.4.0</div><br class=""><blockquote type="cite" class=""><div class="">
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></body></html>