<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.emailquote, li.emailquote, div.emailquote
{mso-style-name:emailquote;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:1.0pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">+cc list<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Eric Schweitz (PGI) <eric.schweitz@pgroup.com>
<br>
<b>Sent:</b> 10 January, 2020 16:08<br>
<b>To:</b> Richard Barton <Richard.Barton@arm.com>; Renato Golin <rengolin@gmail.com>; Hans Wennborg <hans@chromium.org><br>
<b>Cc:</b> Mike Edwards <medwards@llvm.org><br>
<b>Subject:</b> RE: [llvm-dev] Flang landing in the monorepo - next Monday!<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi Richard,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Re: 7.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I posted a couple revisions to Phabricator to synch up the monorepo side of this equation.
<a href="https://reviews.llvm.org/D72416" target="_blank"><span style="font-size:11.5pt;font-family:"Arial",sans-serif;background:white">https://reviews.llvm.org/D72416</span></a></span><span lang="EN-US" style="font-size:11.5pt;font-family:"Arial",sans-serif;color:#1D1C1D;background:white">
and </span><span lang="EN-US"><a href="https://reviews.llvm.org/D72418" target="_blank"><span style="font-size:11.5pt;font-family:"Arial",sans-serif;background:white">https://reviews.llvm.org/D72418</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">The f18 project bits to make it work like an LLVM CMake project are rolled up with the PR to merge the middle part of the compiler.
<a href="https://github.com/flang-compiler/f18/pull/920">https://github.com/flang-compiler/f18/pull/920</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">--<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Eric<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org">llvm-dev-bounces@lists.llvm.org</a>>
<b>On Behalf Of </b>Richard Barton via llvm-dev<br>
<b>Sent:</b> Thursday, January 9, 2020 6:44 AM<br>
<b>To:</b> Richard Barton <<a href="mailto:Richard.Barton@arm.com">Richard.Barton@arm.com</a>>; Renato Golin <<a href="mailto:rengolin@gmail.com">rengolin@gmail.com</a>>; Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>>;
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<b>Cc:</b> Mike Edwards <<a href="mailto:medwards@llvm.org">medwards@llvm.org</a>><br>
<b>Subject:</b> Re: [llvm-dev] Flang landing in the monorepo - next Monday!<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US">Hi all<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Apologies, I somehow combined two points in my list while copying from my editor to my email client! Below is the list as I intended, with changes in bold.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Ta<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Rich<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US" style="font-family:"Times New Roman",serif"> </span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">I think all these have been addressed (please correct me if you think otherwise)<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">1. Audit trail/visibility of code review [Addressed by Peter - code has been reviewed [a] to F18 coding guidelines [b].<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">2. Long-term viability of Flang community and overlap with existing LLVM community [Hopefully Hal and Johannes replies and Greg's and Pat's and my reply demonstrate long-term commitment to Flang after upstreaming]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">3. Compatibility of license [Addressed by Steve, a recent update has made the licenses compatible [c]]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">4. No use of LLVM APIs and so no connection to the project [Addressed by Hal and me - it is the natural next step in development as Flang starts to generate MLIR. Nvidia are working on this now.]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">I think these are acknowledged right now and we are actively working on fixes:<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">5. No use of lit in the regression tests [Arm is working on this]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">6. Need to refactor parts of clang driver that can be shared with flang into a separate library [Arm is working on this, but plans to implement a simple driver first before refactoring to better understand the opportunities
to do so. See Peter's RFC [d] ]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><b><span lang="EN-US">7. No integration into the LLVM build system/Cmake</span></b><span lang="EN-US"> [I think Pat and Eric have patches ready to go for this?]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">I think these are only acknowledged, with the intention to remediate post merge, but no concrete plan or owner at this point:<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><b><span lang="EN-US">8. No use of LLVM utilities or standard data structures
</span></b><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">9. Simple deviations from the LLVM coding style<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> a. Separating public headers into include/flang<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> b. Syntactical things like braces on single line statements, comments on end of namespaces, etc.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> c. .cc file extensions rather than .cpp<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">10. Bigger deviations from the LLVM coding style that are harder to fix<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> a. Early exits and not using else after return, etc.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">11. Flang not supporting all the same C++ compilers as the rest of the project (even taking into account C++17 requirement)<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US" style="font-family:"Times New Roman",serif"> </span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span lang="EN-US">
<hr size="1" width="100%" align="center">
</span></div>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of the original message.
<o:p></o:p></span></p>
</div>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span lang="EN-US">
<hr size="1" width="100%" align="center">
</span></div>
</div>
</div>
</div>
</body>
</html>