<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<font face="Calibri" size="2"><span style="font-size:11pt;">
<div>Hi all</div>
<div> </div>
<div>Apologies, I somehow combined two points in my list while copying from my editor to my email client! Below is the list as I intended, with changes in bold.</div>
<div> </div>
<div>Ta</div>
<div>Rich</div>
<div><font face="Times New Roman"> </font></div>
<div>I think all these have been addressed (please correct me if you think otherwise)</div>
<div>1. Audit trail/visibility of code review [Addressed by Peter - code has been reviewed [a] to F18 coding guidelines [b].</div>
<div>2. Long-term viability of Flang community and overlap with existing LLVM community [Hopefully Hal and Johannes replies and Greg's and Pat's and my reply demonstrate long-term commitment to Flang after upstreaming]</div>
<div>3. Compatibility of license [Addressed by Steve, a recent update has made the licenses compatible [c]]</div>
<div>4. No use of LLVM APIs and so no connection to the project [Addressed by Hal and me - it is the natural next step in development as Flang starts to generate MLIR. Nvidia are working on this now.]</div>
<div> </div>
<div>I think these are acknowledged right now and we are actively working on fixes:</div>
<div>5. No use of lit in the regression tests [Arm is working on this]</div>
<div>6. Need to refactor parts of clang driver that can be shared with flang into a separate library [Arm is working on this, but plans to implement a simple driver first before refactoring to better understand the opportunities to do so. See Peter's RFC [d]
]</div>
<div><b>7. No integration into the LLVM build system/Cmake</b> [I think Pat and Eric have patches ready to go for this?]</div>
<div> </div>
<div>I think these are only acknowledged, with the intention to remediate post merge, but no concrete plan or owner at this point:</div>
<div><b>8. No use of LLVM utilities or standard data structures </b></div>
<div>9. Simple deviations from the LLVM coding style</div>
<div> a. Separating public headers into include/flang</div>
<div> b. Syntactical things like braces on single line statements, comments on end of namespaces, etc.</div>
<div> c. .cc file extensions rather than .cpp</div>
<div>10. Bigger deviations from the LLVM coding style that are harder to fix</div>
<div> a. Early exits and not using else after return, etc.</div>
<div>11. Flang not supporting all the same C++ compilers as the rest of the project (even taking into account C++17 requirement)</div>
<div><font face="Times New Roman"> </font></div>
</span></font>
</body>
</html>