<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 12/17/19 10:33 AM, Nico Weber via
llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAMGbLiG9_1gxBaU466hh5iiy-ie+MSCj1WdN6XX+aJ8-QjYUAA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">On Tue, Dec 17, 2019 at 1:15 PM James Y Knight
<<a href="mailto:jyknight@google.com"
moz-do-not-send="true">jyknight@google.com</a>> wrote:<br>
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Dec 17, 2019
at 12:55 PM Nico Weber <<a
href="mailto:thakis@chromium.org" target="_blank"
moz-do-not-send="true">thakis@chromium.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div dir="ltr">On Tue, Dec 17, 2019 at 12:41 PM
James Y Knight <<a
href="mailto:jyknight@google.com"
target="_blank" moz-do-not-send="true">jyknight@google.com</a>>
wrote:<br>
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>It sounds like you ran into a bug in the
test infrastructure's code to determine if
python3 is supported. Fixing that might be
harder, but it only needs to be fixed once
no matter how much more python3 development
there will be.</div>
</div>
</blockquote>
<div><br>
</div>
<div>No, it was in some local.lit.cfg.</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>I see that now. Sure, in that case I suggest to fix
whatever the issue is <i>and move</i> it to common
code, so that the "python3" feature is correctly
detected and available to any test.</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Right now, most of our scripts were
originally written for python 2, so
certainly it's easy for them to support
python 2. But, it was a lot of work by
various people to port them all to
additionally work in python 3. And, in the
future (or maybe even now), people will be
generally be writing python3 scripts by
default rather than python2. Certainly they
ought to. <br>
</div>
<div><br>
</div>
<div>I just don't think it's worthwhile to
require all new such scripts to continue to
be written bilingually, unless doing that
extra work helps to serve users.</div>
<div><br>
</div>
<div>I'm not at all worried about a
hypothetical case where we want to ship a
script that was written for python3 only.
Firstly, because that usually doesn't
happen. But if it does, we can port it then,
or else we might just decide it's fine for
it to be python3 only.</div>
</div>
</blockquote>
<div><br>
</div>
<div>You don't see any advantage to having a
consistent language level across the project?
(See also the flang vs c++17 discussion.)</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>In this particular situatoin, correct. For these
auxilliary scripts which are not released or used to
build/test released components, I see no advantage to
requiring these to support python2, anymore.<br>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Well, I disagree :)</div>
<div><br>
I'm curious what others think.</div>
</div>
</div>
</blockquote>
<p>Don't really care, but I have a mild preference for accepting
patches to keep python2 working. I wouldn't *require* scripts to
work with python2, but I see no reason not to land patches if
someone wants to put in the work.</p>
<p>Philip</p>
</body>
</html>