<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Perhaps you need to add something to LLVM_TEST_DEPENDS? <a href="https://github.com/llvm/llvm-project/blob/44c167ace998b41b7f8cbe6acd283c8ba9b0b5a3/llvm/test/CMakeLists.txt#L39">
https://github.com/llvm/llvm-project/blob/44c167ace998b41b7f8cbe6acd283c8ba9b0b5a3/llvm/test/CMakeLists.txt#L39</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">llvm-dev <llvm-dev-bounces@lists.llvm.org> on behalf of Hiroshi Yamauchi via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Reply-To: </b>Hiroshi Yamauchi <yamauchi@google.com><br>
<b>Date: </b>Tuesday, December 10, 2019 at 3:17 PM<br>
<b>To: </b>"Doerfert, Johannes" <jdoerfert@anl.gov><br>
<b>Cc: </b>LLVM Developers Mailing List <llvm-dev@lists.llvm.org>, Johannes Doerfert <johannes@jdoerfert.de><br>
<b>Subject: </b>Re: [llvm-dev] [PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-family:"Arial",sans-serif">This seems to be happening to me, too. I think this happens for me on "ninja check-llvm" in a clean build. Let me know if you need more info.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Dec 10, 2019 at 2:22 PM Doerfert, Johannes via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi Jay,<br>
<br>
I am not sure why this happens.<br>
Can you give me some information so I can reproduce it:<br>
Is this happens for a clean build?<br>
Is Clang build as well?<br>
<br>
I think the SYSTEM_LIBS macro doesn't contain the new<br>
libLLVMFrontendOpenMP but I don't know why.<br>
<br>
Thanks,<br>
Johannes<br>
<br>
<br>
On 12/10, Jay Foad wrote:<br>
> Johannes,<br>
> <br>
> This patch seems to be causing test failures when I just do "ninja<br>
> check", without running "ninja" or "ninja all" first.<br>
> <br>
> $ CC=clang CXX=clang++ cmake -G Ninja ~/git/llvm-project/llvm<br>
> -DLLVM_USE_LINKER=lld -DLLVM_PARALLEL_LINK_JOBS=4<br>
> -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 && ninja check<br>
> [...]<br>
> FAIL: LLVM :: tools/llvm-config/system-libs.test (32608 of 34640)<br>
> ******************** TEST 'LLVM :: tools/llvm-config/system-libs.test'<br>
> FAILED ********************<br>
> Script:<br>
> --<br>
> : 'RUN: at line 1'; /home/jayfoad2/tmp/bin/llvm-config --link-static<br>
> --system-libs 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/system-libs.test<br>
> --<br>
> Exit Code: 1<br>
> <br>
> Command Output (stderr):<br>
> --<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/system-libs.test:4:8:<br>
> error: CHECK: expected string not found in input<br>
> CHECK: -l<br>
> ^<br>
> <stdin>:1:1: note: scanning from here<br>
> llvm-config: error: missing: /home/jayfoad2/tmp/lib/libLLVMFrontendOpenMP.a<br>
> ^<br>
> <br>
> --<br>
> <br>
> ********************<br>
> FAIL: LLVM :: tools/llvm-config/booleans.test (32612 of 34640)<br>
> ******************** TEST 'LLVM :: tools/llvm-config/booleans.test'<br>
> FAILED ********************<br>
> Script:<br>
> --<br>
> : 'RUN: at line 2'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --assertion-mode 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-ONOFF<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 3'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --has-global-isel 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-ONOFF<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 9'; /home/jayfoad2/tmp/bin/llvm-config --has-rtti<br>
> 2>&1 | /home/jayfoad2/tmp/bin/FileCheck --check-prefix=CHECK-YESNO<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 15'; /home/jayfoad2/tmp/bin/llvm-config --build-mode<br>
> 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-BUILD-MODE<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 20'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --build-system 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-BUILD-SYSTEM<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 25'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --shared-mode 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-SHARED-MODE<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> --<br>
> Exit Code: 1<br>
> <br>
> Command Output (stderr):<br>
> --<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test:27:24:<br>
> error: CHECK-SHARED-MODE-NOT: excluded string found in input<br>
> CHECK-SHARED-MODE-NOT: error:<br>
> ^<br>
> <stdin>:3:14: note: found here<br>
> llvm-config: error: missing: /home/jayfoad2/tmp/lib/libLLVMFrontendOpenMP.a<br>
> ^~~~~~<br>
> <br>
> --<br>
> <br>
> ********************<br>
> <br>
> Testing Time: 69.42s<br>
> ********************<br>
> Failing Tests (2):<br>
> LLVM :: tools/llvm-config/booleans.test<br>
> LLVM :: tools/llvm-config/system-libs.test<br>
> <br>
> Expected Passes : 19544<br>
> Expected Failures : 49<br>
> Unsupported Tests : 15045<br>
> Unexpected Failures: 2<br>
> FAILED: test/CMakeFiles/check-llvm<br>
> cd /home/jayfoad2/tmp/test && /usr/bin/python<br>
> /home/jayfoad2/tmp/./bin/llvm-lit -sv /home/jayfoad2/tmp/test<br>
> ninja: build stopped: subcommand failed.<br>
> <br>
> <br>
> <br>
> $ ninja && ninja check<br>
> [41/41] Linking CXX executable bin/llvm-stress<br>
> [0/1] Running the LLVM regression tests<br>
> <br>
> Testing Time: 69.02s<br>
> Expected Passes : 19547<br>
> Expected Failures : 49<br>
> Unsupported Tests : 15044<br>
> <br>
> <br>
> <br>
> Could you take a look please?<br>
> <br>
> Thanks,<br>
> Jay.<br>
> <br>
> On Tue, 10 Dec 2019 at 06:19, Johannes Doerfert via Phabricator via<br>
> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> ><br>
> > This revision was automatically updated to reflect the committed changes.<br>
> > Closed by commit rGeb3e81f43f01: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h (authored by jdoerfert).<br>
> ><br>
> > Changed prior to commit:<br>
> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D69853-3Fvs-3D232987-26id-3D233003-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=-CNtHX7zd5q93-Xbp74C8td4iKgW4CSWMTHHZO3aoPI&s=m7qFWkb5IV-NLoWnh25Id3VXfGP2d8H47IUvDq21hnQ&e=" target="_blank">https://reviews.llvm.org/D69853?vs=232987&id=233003#toc</a><br>
> ><br>
> > Repository:<br>
> > rG LLVM Github Monorepo<br>
> ><br>
> > CHANGES SINCE LAST ACTION<br>
> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D69853_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=-CNtHX7zd5q93-Xbp74C8td4iKgW4CSWMTHHZO3aoPI&s=7Eu8dNBTL2KOYyK-eF9rsFSQ6rOw12C8cUaWEF6CmCQ&e=" target="_blank">https://reviews.llvm.org/D69853/new/</a><br>
> ><br>
> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D69853&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=-CNtHX7zd5q93-Xbp74C8td4iKgW4CSWMTHHZO3aoPI&s=I6uCL2n5X3UhSbPOzAROsy8414NQYm7YW7LDojlA6SE&e=" target="_blank">
https://reviews.llvm.org/D69853</a><br>
> ><br>
> > Files:<br>
> > clang/include/clang/AST/OpenMPClause.h<br>
> > clang/include/clang/AST/StmtOpenMP.h<br>
> > clang/include/clang/Basic/OpenMPKinds.def<br>
> > clang/include/clang/Basic/OpenMPKinds.h<br>
> > clang/lib/AST/CMakeLists.txt<br>
> > clang/lib/AST/OpenMPClause.cpp<br>
> > clang/lib/AST/StmtOpenMP.cpp<br>
> > clang/lib/Basic/OpenMPKinds.cpp<br>
> > clang/lib/CodeGen/CGOpenMPRuntime.cpp<br>
> > clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp<br>
> > clang/lib/CodeGen/CGStmtOpenMP.cpp<br>
> > clang/lib/CodeGen/CodeGenFunction.h<br>
> > clang/lib/Parse/CMakeLists.txt<br>
> > clang/lib/Parse/ParseOpenMP.cpp<br>
> > clang/lib/Sema/CMakeLists.txt<br>
> > clang/lib/Sema/SemaOpenMP.cpp<br>
> > clang/lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
> > clang/lib/Sema/TreeTransform.h<br>
> > clang/lib/Serialization/ASTWriter.cpp<br>
> > clang/lib/Serialization/ASTWriterStmt.cpp<br>
> > llvm/include/llvm/Frontend/OpenMP/OMPConstants.h<br>
> > llvm/include/llvm/Frontend/OpenMP/OMPKinds.def<br>
> > llvm/lib/CMakeLists.txt<br>
> > llvm/lib/Frontend/CMakeLists.txt<br>
> > llvm/lib/Frontend/LLVMBuild.txt<br>
> > llvm/lib/Frontend/OpenMP/CMakeLists.txt<br>
> > llvm/lib/Frontend/OpenMP/LLVMBuild.txt<br>
> > llvm/lib/Frontend/OpenMP/OMPConstants.cpp<br>
> > llvm/lib/LLVMBuild.txt<br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=-CNtHX7zd5q93-Xbp74C8td4iKgW4CSWMTHHZO3aoPI&s=0a_IdaoiHCXPSGuLM4TYzd5PE8JFLGH0rNEAA3RF0bE&e=" target="_blank">
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
-- <br>
<br>
Johannes Doerfert<br>
Researcher<br>
<br>
Argonne National Laboratory<br>
Lemont, IL 60439, USA<br>
<br>
<a href="mailto:jdoerfert@anl.gov" target="_blank">jdoerfert@anl.gov</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=-CNtHX7zd5q93-Xbp74C8td4iKgW4CSWMTHHZO3aoPI&s=3N-F-mxvoV0Cx5gkBrNUFeWzgEAErDipSzBHYO8cXmc&e=" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>