<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">This seems to be happening to me, too. I think this happens for me on "ninja check-llvm" in a clean build. Let me know if you need more info.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 10, 2019 at 2:22 PM Doerfert, Johannes via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Jay,<br>
<br>
I am not sure why this happens.<br>
Can you give me some information so I can reproduce it:<br>
Is this happens for a clean build?<br>
Is Clang build as well?<br>
<br>
I think the SYSTEM_LIBS macro doesn't contain the new<br>
libLLVMFrontendOpenMP but I don't know why.<br>
<br>
Thanks,<br>
Johannes<br>
<br>
<br>
On 12/10, Jay Foad wrote:<br>
> Johannes,<br>
> <br>
> This patch seems to be causing test failures when I just do "ninja<br>
> check", without running "ninja" or "ninja all" first.<br>
> <br>
> $ CC=clang CXX=clang++ cmake -G Ninja ~/git/llvm-project/llvm<br>
> -DLLVM_USE_LINKER=lld -DLLVM_PARALLEL_LINK_JOBS=4<br>
> -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 && ninja check<br>
> [...]<br>
> FAIL: LLVM :: tools/llvm-config/system-libs.test (32608 of 34640)<br>
> ******************** TEST 'LLVM :: tools/llvm-config/system-libs.test'<br>
> FAILED ********************<br>
> Script:<br>
> --<br>
> : 'RUN: at line 1'; /home/jayfoad2/tmp/bin/llvm-config --link-static<br>
> --system-libs 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/system-libs.test<br>
> --<br>
> Exit Code: 1<br>
> <br>
> Command Output (stderr):<br>
> --<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/system-libs.test:4:8:<br>
> error: CHECK: expected string not found in input<br>
> CHECK: -l<br>
> ^<br>
> <stdin>:1:1: note: scanning from here<br>
> llvm-config: error: missing: /home/jayfoad2/tmp/lib/libLLVMFrontendOpenMP.a<br>
> ^<br>
> <br>
> --<br>
> <br>
> ********************<br>
> FAIL: LLVM :: tools/llvm-config/booleans.test (32612 of 34640)<br>
> ******************** TEST 'LLVM :: tools/llvm-config/booleans.test'<br>
> FAILED ********************<br>
> Script:<br>
> --<br>
> : 'RUN: at line 2'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --assertion-mode 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-ONOFF<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 3'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --has-global-isel 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-ONOFF<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 9'; /home/jayfoad2/tmp/bin/llvm-config --has-rtti<br>
> 2>&1 | /home/jayfoad2/tmp/bin/FileCheck --check-prefix=CHECK-YESNO<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 15'; /home/jayfoad2/tmp/bin/llvm-config --build-mode<br>
> 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-BUILD-MODE<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 20'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --build-system 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-BUILD-SYSTEM<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> : 'RUN: at line 25'; /home/jayfoad2/tmp/bin/llvm-config<br>
> --shared-mode 2>&1 | /home/jayfoad2/tmp/bin/FileCheck<br>
> --check-prefix=CHECK-SHARED-MODE<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test<br>
> --<br>
> Exit Code: 1<br>
> <br>
> Command Output (stderr):<br>
> --<br>
> /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test:27:24:<br>
> error: CHECK-SHARED-MODE-NOT: excluded string found in input<br>
> CHECK-SHARED-MODE-NOT: error:<br>
> ^<br>
> <stdin>:3:14: note: found here<br>
> llvm-config: error: missing: /home/jayfoad2/tmp/lib/libLLVMFrontendOpenMP.a<br>
> ^~~~~~<br>
> <br>
> --<br>
> <br>
> ********************<br>
> <br>
> Testing Time: 69.42s<br>
> ********************<br>
> Failing Tests (2):<br>
> LLVM :: tools/llvm-config/booleans.test<br>
> LLVM :: tools/llvm-config/system-libs.test<br>
> <br>
> Expected Passes : 19544<br>
> Expected Failures : 49<br>
> Unsupported Tests : 15045<br>
> Unexpected Failures: 2<br>
> FAILED: test/CMakeFiles/check-llvm<br>
> cd /home/jayfoad2/tmp/test && /usr/bin/python<br>
> /home/jayfoad2/tmp/./bin/llvm-lit -sv /home/jayfoad2/tmp/test<br>
> ninja: build stopped: subcommand failed.<br>
> <br>
> <br>
> <br>
> $ ninja && ninja check<br>
> [41/41] Linking CXX executable bin/llvm-stress<br>
> [0/1] Running the LLVM regression tests<br>
> <br>
> Testing Time: 69.02s<br>
> Expected Passes : 19547<br>
> Expected Failures : 49<br>
> Unsupported Tests : 15044<br>
> <br>
> <br>
> <br>
> Could you take a look please?<br>
> <br>
> Thanks,<br>
> Jay.<br>
> <br>
> On Tue, 10 Dec 2019 at 06:19, Johannes Doerfert via Phabricator via<br>
> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> ><br>
> > This revision was automatically updated to reflect the committed changes.<br>
> > Closed by commit rGeb3e81f43f01: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h (authored by jdoerfert).<br>
> ><br>
> > Changed prior to commit:<br>
> > <a href="https://reviews.llvm.org/D69853?vs=232987&id=233003#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D69853?vs=232987&id=233003#toc</a><br>
> ><br>
> > Repository:<br>
> > rG LLVM Github Monorepo<br>
> ><br>
> > CHANGES SINCE LAST ACTION<br>
> > <a href="https://reviews.llvm.org/D69853/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D69853/new/</a><br>
> ><br>
> > <a href="https://reviews.llvm.org/D69853" rel="noreferrer" target="_blank">https://reviews.llvm.org/D69853</a><br>
> ><br>
> > Files:<br>
> > clang/include/clang/AST/OpenMPClause.h<br>
> > clang/include/clang/AST/StmtOpenMP.h<br>
> > clang/include/clang/Basic/OpenMPKinds.def<br>
> > clang/include/clang/Basic/OpenMPKinds.h<br>
> > clang/lib/AST/CMakeLists.txt<br>
> > clang/lib/AST/OpenMPClause.cpp<br>
> > clang/lib/AST/StmtOpenMP.cpp<br>
> > clang/lib/Basic/OpenMPKinds.cpp<br>
> > clang/lib/CodeGen/CGOpenMPRuntime.cpp<br>
> > clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp<br>
> > clang/lib/CodeGen/CGStmtOpenMP.cpp<br>
> > clang/lib/CodeGen/CodeGenFunction.h<br>
> > clang/lib/Parse/CMakeLists.txt<br>
> > clang/lib/Parse/ParseOpenMP.cpp<br>
> > clang/lib/Sema/CMakeLists.txt<br>
> > clang/lib/Sema/SemaOpenMP.cpp<br>
> > clang/lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
> > clang/lib/Sema/TreeTransform.h<br>
> > clang/lib/Serialization/ASTWriter.cpp<br>
> > clang/lib/Serialization/ASTWriterStmt.cpp<br>
> > llvm/include/llvm/Frontend/OpenMP/OMPConstants.h<br>
> > llvm/include/llvm/Frontend/OpenMP/OMPKinds.def<br>
> > llvm/lib/CMakeLists.txt<br>
> > llvm/lib/Frontend/CMakeLists.txt<br>
> > llvm/lib/Frontend/LLVMBuild.txt<br>
> > llvm/lib/Frontend/OpenMP/CMakeLists.txt<br>
> > llvm/lib/Frontend/OpenMP/LLVMBuild.txt<br>
> > llvm/lib/Frontend/OpenMP/OMPConstants.cpp<br>
> > llvm/lib/LLVMBuild.txt<br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
-- <br>
<br>
Johannes Doerfert<br>
Researcher<br>
<br>
Argonne National Laboratory<br>
Lemont, IL 60439, USA<br>
<br>
<a href="mailto:jdoerfert@anl.gov" target="_blank">jdoerfert@anl.gov</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>