<div dir="ltr">Sure I will create a PR for this.<div>regards,</div><div>Venkat.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 3 Dec 2019 at 15:02, Neil Henning <<a href="mailto:neil.henning@unity3d.com">neil.henning@unity3d.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I can reproduce your results - its not forwarding the load from the previous store. I'm not sure why but none of the alias analysis passes are detecting that the two GEPs do not alias (they always come out as MayAlias) and I think its abandoning doing the store forwarding as a result.</div><div><br></div><div>You might want to file a bug for this?</div><div><br></div><div>Cheers,</div><div>-Neil.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Dec 2, 2019 at 3:41 PM Venkataramanan Kumar via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Can someone clarify on this please?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 28 Nov 2019 at 21:58, Venkataramanan Kumar <<a href="mailto:venkataramanan.kumar.llvm@gmail.com" target="_blank">venkataramanan.kumar.llvm@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">TBAA Question. <br><br>Please consider the following test case.<br><br>---Snip--<br>struct B {<br> int b1;<br> int b2;<br>};<br><br>struct C {<br> int b1;<br>};<br><br>struct A {<br> int a1;<br> struct C SC;<br> int a2;<br>};<br><br>int foo1(struct A * Aptr, struct B* Bptr)<br>{<br> int *a = &Aptr->SC.b1;<br> *a=10;<br> Bptr->b1 = 11;<br> return *a;<br>}<br><br>int foo2(struct A * Aptr, struct B* Bptr)<br>{<br> Aptr->SC.b1=10;<br> Bptr->b1 = 11;<br> return Aptr->SC.b1;<br>}<br>---Snip--<br><br>The structure pointers "Aptr" and "Bptr" will not alias each other in both the functions.<br>TBAA is able to figure that out in the case of "foo2". Hence it could propagate the value "10" directly for return in "foo2".<br><br>--IR snippet ---<br><br>; Function Attrs: nounwind uwtable<br>define dso_local i32 @foo1(%struct.A* %Aptr, %struct.B* %Bptr) local_unnamed_addr #0 {<br>entry:<br> %b1 = getelementptr inbounds %struct.A, %struct.A* %Aptr, i64 0, i32 1, i32 0<br> store i32 10, i32* %b1, align 4, !tbaa !2<br> %b11 = getelementptr inbounds %struct.B, %struct.B* %Bptr, i64 0, i32 0<br> store i32 11, i32* %b11, align 4, !tbaa !6<br> %0 = load i32, i32* %b1, align 4, !tbaa !2 <== reloads from memory.<br> ret i32 %0<br>}<br><br>; Function Attrs: nounwind uwtable<br>define dso_local i32 @foo2(%struct.A* %Aptr, %struct.B* %Bptr) local_unnamed_addr #0 {<br>entry:<br> %b1 = getelementptr inbounds %struct.A, %struct.A* %Aptr, i64 0, i32 1, i32 0<br> store i32 10, i32* %b1, align 4, !tbaa !8<br> %b11 = getelementptr inbounds %struct.B, %struct.B* %Bptr, i64 0, i32 0<br> store i32 11, i32* %b11, align 4, !tbaa !6<br> ret i32 10 <== returns 10 <br>}<br>---IR snippet ---<br><br>I assume for both cases there is no possibility of memory aliasing. is my assumption wrong?<br>Why we are not optimizing the return for function "foo1"? is that because TBAA is not formed in that case?<br><br>Please clarify.<br><br>regards,<br>Venkat.<br></div>
</blockquote></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><table style="border-collapse:collapse;border-spacing:0px;color:rgb(90,90,91);font-size:13px;margin:0px 0px 20px;padding:0px" width="100%" cellspacing="0" cellpadding="0" border="0"><tbody style="margin:0px;padding:0px"><tr style="margin:0px;padding:0px"><td style="border-collapse:collapse;font-size:0px;line-height:1.5em;padding:0px 0px 20px;vertical-align:top" align="left"><table style="border-collapse:collapse;border-spacing:0px;margin:0px;padding:0px" cellspacing="0" cellpadding="0" border="0" align="left"><tbody style="margin:0px;padding:0px"><tr style="margin:0px;padding:0px"><td style="border-collapse:collapse;font-size:1.12em;line-height:1.5em;padding:0px;vertical-align:top;width:64px"><img style="border: medium none; border-radius: 0px; display: block; font-size: 13px; height: auto; line-height: 100%; margin: 0px; max-width: 100%; outline-style: none; outline-width: medium; padding: 20px 0px 0px; width: 100%;" alt="" src="https://unity3d.com/profiles/unity3d/themes/unity/images/ui/other/unity-logo-dark-email.png" width="64" height="auto"></td></tr></tbody></table></td></tr><tr style="margin:0px;padding:0px"><td style="border-collapse:collapse;font-size:0px;line-height:1.5em;padding:0px;vertical-align:top" align="left"><div style="color:rgb(0,0,0);font-family:Roboto,Arial;font-size:14px;font-weight:600;line-height:15px;margin:0px;padding:0px">Neil Henning</div></td></tr><tr style="margin:0px;padding:0px"><td style="border-collapse:collapse;font-size:0px;line-height:1.5em;padding:0px;vertical-align:top" align="left"><div style="color:rgb(0,0,0);font-family:Roboto,Arial;font-size:14px;line-height:15px;margin:0px;padding:0px 0px 10px">Senior Software Engineer Compiler</div></td></tr><tr style="margin:0px;padding:0px"><td style="border-collapse:collapse;font-size:0px;line-height:1.5em;padding:0px;vertical-align:top" align="left"><div style="color:rgb(0,0,0);font-family:Roboto,Arial;font-size:12px;line-height:15px;margin:0px;padding:0px"><a href="http://unity.com" target="_blank">unity.com</a></div></td></tr></tbody></table></div></div>
</blockquote></div>