<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Unless things have changed lately and I missed something, you can just push the change and the bots will pick it up automatically. They will send you emails if it seems like anything is broken.<div class=""><br class=""></div><div class="">That being said, before pushing you should do some local tests (e.g. run the lit tests) as an initial sanity check.<div class=""><div class=""><br class=""></div><div class="">If it breaks anything, the standard process is</div><div class=""><br class=""></div><div class="">1) Revert it with an explanation of why in the commit message. (E.g. “This broke this bot” with a link to the build log or a simple example.)</div><div class="">2) Fix the breakage</div><div class="">3) Recommit</div><div class=""><br class=""></div><div class="">- Jessica<br class=""><div class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 21, 2019, at 12:23 AM, Ehud Katz via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi everyone,<div class=""><br class=""></div><div class="">In the reviewing system, after a patch is approved, what should be the following step?</div><div class=""><br class=""></div><div class="">I assume I'll have to make sure the patch hasn't broken anything, before pushing it, so I'll wan't to run a full build+tests, probably in a remote sterile environment (like a jenkins server).</div><div class=""><br class=""></div><div class="">Do we have an integration system like this? Or should I just trust the build+tests on my machine?</div><div class=""><br class=""></div><div class="">Regardless, I have seen in many reviews (in Phabricator) that <b class="">Builds </b>are triggered for them, in particular: "<b class="">arc lint + arc unit</b>" and "<b class="">pre-merge checks</b>" (which sounds like what I am searching for). What is their use and how do I trigger them?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Ehud.</div></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></div></div></div></div></div></body></html>