<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Yes. Thanks!<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 3, 2019, at 8:09 PM, Chris Bieneman <<a href="mailto:chris.bieneman@me.com" class="">chris.bieneman@me.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Dave,<div class=""><br class=""></div><div class="">We would keep the ability to specify source paths for things that live outside the mono-repo, just not for things inside the repository. This would have the impact of supporting `LLVM_EXTERNAL_*_SOURCE_DIR` for projects specified in `LLVM_EXTERNAL_PROJECTS` but not projects specified with `LLVM_ENABLE_PROJECTS`.</div><div class=""><br class=""></div><div class="">Does that address your concerns?</div><div class=""><br class=""></div><div class="">-Chris</div><div class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Oct 30, 2019, at 6:37 AM, David Zarzycki via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Oct 29, 2019, at 7:09 PM, Chris Bieneman via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">There was also agreement that in the monorepo it no longer makes sense to have an option to specify the source locations of sub-projects. That means we can remove the `LLVM_EXTERNAL_*_SOURCE_DIR` variables.</div><br class="Apple-interchange-newline"></div></blockquote></div><br class=""><div class="">Hi Chris,</div><div class=""><br class=""></div><div class="">What about genuine external projects? For example, I build Swift “unified” as a part of LLVM but I can’t keep the Swift source inside of the llvm-project directory due to how Git submodules work. In other words:</div><div class=""><br class=""></div><div class=""><font face="Courier" class=""><span style="font-style: normal;" class="">$ cd my_project</span></font></div><div class=""><font face="Courier" class=""><span style="font-style: normal;" class="">$ ls toolchain</span></font></div><div class=""><font face="Courier" class=""><span style="font-style: normal;" class="">cmark</span></font></div><div class=""><font face="Courier" class=""><span style="font-style: normal;" class="">llvm-project</span></font></div><div class=""><font face="Courier" class=""><span style="font-style: normal;" class="">swift</span></font></div><div class=""><font face="Courier" class=""><span style="font-style: normal;" class="">$ git submodule status</span></font></div><font face="Courier" class=""><span style="font-style: normal;" class=""> bfa95d55b535fa178f75484b5e8f82ae3d8517af toolchain/cmark<br class=""> ea51a1ab2980d055c68820888ce255242f387c91 toolchain/llvm-project<br class="">+cec05255029d0ce354825e5530a47a5affb03975 toolchain/swift </span></font><div class=""><br class=""></div><div class="">Dave</div></div>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class=""></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></body></html>