<div dir="ltr">Heads up that this landed in <a href="https://github.com/llvm/llvm-project/commit/9f0ff0b2634bab6a5be8dace005c9eb24d386dd1">this revision</a>. Updated release notes <a href="https://github.com/llvm/llvm-project/commit/bbb43df0111ef29717b57bad7712d7f4c61655ac">here</a>.<div><br></div><div>Best,</div><div>Alina</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 11:01 AM Alina Sbirlea <<a href="mailto:alina.sbirlea@gmail.com">alina.sbirlea@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I sent out a patch (<a href="https://reviews.llvm.org/D69121" target="_blank">D69121</a>)  removing the BasicBlockPass, BasicBlockManager and all their dependencies following the patch that cleaned up the instantiations of the BasicBlockPass <span style="background-color:transparent;font-variant-numeric:normal;font-variant-east-asian:normal;font-size:11pt;font-family:Arial;color:rgb(0,0,0);vertical-align:baseline;white-space:pre-wrap">(</span><a href="https://reviews.llvm.org/rL373254" target="_blank">rL373254</a><span style="font-variant-numeric:normal;font-variant-east-asian:normal;font-size:10pt;font-family:Arial;color:rgb(70,76,92);background-color:rgb(243,245,247);font-weight:700;vertical-align:baseline;white-space:pre-wrap">)</span>.</div><div><br></div><div>The motivation was that the BasicBlockManager was generally unused, untested, was potentially broken (<a href="https://bugs.llvm.org/show_bug.cgi?id=42264" target="_blank">PR42264</a>, <a href="https://bugs.llvm.org/show_bug.cgi?id=43429" target="_blank">PR43429</a>, <a href="https://bugs.llvm.org/show_bug.cgi?id=43336" target="_blank">PR43336</a>, <a href="https://bugs.llvm.org/show_bug.cgi?id=42246" target="_blank">PR42246</a>), and any BasicBlockPass could be updated to be a FunctionPass looping over all BBs.</div><div><br></div><div>If you have comments or concerns about this cleanup please let me know.</div><div><br></div><div>Best,</div><div>Alina</div></div>
</blockquote></div>