<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 16, 2019 at 12:26 PM Robinson, Paul <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
<br>
> -----Original Message-----<br>
> From: Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>><br>
> Sent: Wednesday, October 16, 2019 3:14 PM<br>
> To: Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com" target="_blank">lebedev.ri@gmail.com</a>><br>
> Cc: Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>>; Shoaib Meenai<br>
> <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>>; Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>>; llvm-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>; cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>>; openmp-dev (openmp-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>) <<a href="mailto:openmp-dev@lists.llvm.org" target="_blank">openmp-dev@lists.llvm.org</a>>; LLDB Dev <lldb-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>><br>
> Subject: Re: [llvm-dev] [cfe-dev] Mailing list changes this week<br>
> <br>
> On 10/16/2019 12:02 PM, Roman Lebedev wrote:<br>
> > On Wed, Oct 16, 2019 at 9:55 PM Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>><br>
> wrote:<br>
> >><br>
> >> On 10/16/2019 07:31 AM, Roman Lebedev wrote:<br>
> >>> +1, please.<br>
> >>><br>
> >>> Also, putting a tag on the *first* commit in the repo,<br>
> >>> and doing `git describe --match FIRST_COMMIT_TAG` will be *great*!<br>
> >>><br>
> >><br>
> >> Do we need to add a tag or is `git rev-list --count HEAD`<br>
> >> good enough?<br>
> > Ah, interesting, that works too, better than nothing.<br>
> > But to be noted that number is different from the `llvm-svn: <>` for<br>
> > the current commit.<br>
> ><br>
> <br>
> This is expected. There were a few commits that were filtered<br>
> out in the SVN to git conversion:<br>
> <br>
> <a href="https://github.com/jyknight/llvm-git-migration/blob/master/llvm-svn2git-" rel="noreferrer" target="_blank">https://github.com/jyknight/llvm-git-migration/blob/master/llvm-svn2git-</a><br>
> monorepo.rules<br>
<br>
Does the same tactic work for the release branches? Or are we going to <br>
see some duplicate count numbers on master and the branches? That might<br>
be confusing. (FYI at Sony, for release we count revs since the branch,<br>
so the monotonic numbers on branches are generally small.)<br>
--paulr<br></blockquote><div><br></div><div>If we always display the revisions as a tuple number+branch (r1234-master vs r1234-release9) is it good enough?</div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
> <br>
> -Tom<br>
> <br>
> >> -Tom<br>
> > Roman<br>
> ><br>
> >>> Roman.<br>
> >>><br>
> >>> On Wed, Oct 16, 2019 at 5:23 PM Robinson, Paul via llvm-dev<br>
> >>> <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
> >>>><br>
> >>>> +1. And put it in the email (subject?). While it’s possible to<br>
> derive a count from a hash manually, better to have it in the email in the<br>
> first place. You can’t rely on order-of-email-delivery to reflect order-<br>
> of-commit.<br>
> >>>><br>
> >>>> --paulr<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> From: llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>> On Behalf Of Shoaib<br>
> Meenai via llvm-dev<br>
> >>>> Sent: Wednesday, October 16, 2019 1:42 AM<br>
> >>>> To: <a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>; Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>><br>
> >>>> Cc: llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>; cfe-dev <cfe-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>>; openmp-dev (<a href="mailto:openmp-dev@lists.llvm.org" target="_blank">openmp-dev@lists.llvm.org</a>) <openmp-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>>; LLDB Dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>><br>
> >>>> Subject: Re: [llvm-dev] [cfe-dev] Mailing list changes this week<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> I thought we were just going to count commits on a particular branch<br>
> and use the (branch name, commit count) tuple as our monotonic<br>
> incrementing identifier?<br>
> <a href="https://llvm.org/docs/Proposals/GitHubMove.html#on-managing-revision-" rel="noreferrer" target="_blank">https://llvm.org/docs/Proposals/GitHubMove.html#on-managing-revision-</a><br>
> numbers-with-git<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> From: cfe-dev <<a href="mailto:cfe-dev-bounces@lists.llvm.org" target="_blank">cfe-dev-bounces@lists.llvm.org</a>> on behalf of cfe-dev<br>
> <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>><br>
> >>>> Organization: Red Hat<br>
> >>>> Reply-To: "<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>" <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>><br>
> >>>> Date: Tuesday, October 15, 2019 at 10:13 PM<br>
> >>>> To: Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>><br>
> >>>> Cc: llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>, cfe-dev <cfe-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>>, "openmp-dev (<a href="mailto:openmp-dev@lists.llvm.org" target="_blank">openmp-dev@lists.llvm.org</a>)" <openmp-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a>>, LLDB Dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>><br>
> >>>> Subject: Re: [cfe-dev] Mailing list changes this week<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> On 10/15/2019 09:44 PM, Mehdi AMINI wrote:<br>
> >>>><br>
> >>>> On Tue, Oct 15, 2019 at 9:33 PM Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a><br>
> <mailto:<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>>> wrote:<br>
> >>>><br>
> >>>> On 10/15/2019 09:24 PM, Mehdi AMINI wrote:<br>
> >>>><br>
> >>>> > Hi Tom.<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > One issue with this is that we don't have a clear "ordering"<br>
> from linear revision numbers from these emails. Have we looked into<br>
> continuing to generate our own emails per commits instead so that we<br>
> control the format?<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> This actually what we are doing, we are listening for github<br>
> commit events and<br>
> >>>><br>
> >>>> then generating our own emails based on the data in the event.<br>
> We can format<br>
> >>>><br>
> >>>> the emails how ever we want, and we tried to match the current<br>
> SVN format exactly.<br>
> >>>><br>
> >>>> Ah great!<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> Is the some other information you would like to have in the<br>
> emails to show the<br>
> >>>><br>
> >>>> ordering?<br>
> >>>><br>
> >>>> The only thing I was looking to get was to continue to have a<br>
> monotonic incrementing integer for the revision instead of the git hash<br>
> alone: I don't know if `git llvm` has this feature yet but this was<br>
> discussed a while ago (I don't remember if we just mentioned counting the<br>
> commits in the repo from the beginning or using an invocation of `git<br>
> describe` or something derived).<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> We talked about using `git describe` for this, but this would require<br>
> that we<br>
> >>>><br>
> >>>> add tags to the master branch each time the version number was<br>
> bumped. We<br>
> >>>><br>
> >>>> discussed this[1] last year, but deferred the decision, since we<br>
> couldn't get<br>
> >>>><br>
> >>>> consensus on the tag name.<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> -Tom<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> [1] <a href="https://urldefense.proofpoint.com/v2/url?u=http-" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-</a><br>
> 3A__lists.llvm.org_pipermail_llvm-2Ddev_2018-<br>
> 2DDecember_128484.html&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQX<br>
> KeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=p_75z-<br>
> WV3dFcBRoqs2YeTexKxeCf8oyS-atIo6wG6Fg&e=<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> --<br>
> >>>><br>
> >>>> Mehdi<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> -Tom<br>
> >>>><br>
> >>>> > Thanks,<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > --<br>
> >>>><br>
> >>>> > Mehdi<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > On Tue, Oct 15, 2019 at 9:07 PM Tom Stellard via cfe-dev <cfe-<br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a> <mailto:<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> <mailto:<a href="mailto:cfe-" target="_blank">cfe-</a><br>
> <a href="mailto:dev@lists.llvm.org" target="_blank">dev@lists.llvm.org</a> <mailto:<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>>>> wrote:<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > Hi,<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > We are going to start to switching from SVN commit emails<br>
> to GitHub commit<br>
> >>>><br>
> >>>> > emails this week. The only real change you should notice<br>
> is that<br>
> >>>><br>
> >>>> > the revision number in the subject will be replaced with a<br>
> git hash and<br>
> >>>><br>
> >>>> > the diff links in the email will point to GitHub.<br>
> Otherwise the<br>
> >>>><br>
> >>>> > content and format of the email should be the same.<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > We are going to start by rolling this out for the openmp-<br>
> commits list<br>
> >>>><br>
> >>>> > and then once that's working begin migrating the rest of<br>
> the lists. If you<br>
> >>>><br>
> >>>> > notice any issues with the new emails, please file a bug<br>
> and mark it<br>
> >>>><br>
> >>>> > as a blocker of the github meta-bug (<a href="http://llvm.org/PR39393" rel="noreferrer" target="_blank">llvm.org/PR39393</a><br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=http-" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-</a><br>
> 3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKe<br>
> TWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj<br>
> 4VzteOcs9k7RANSWPgiiQ2Q&e= ><br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=http-" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-</a><br>
> 3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKe<br>
> TWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj<br>
> 4VzteOcs9k7RANSWPgiiQ2Q&e= >).<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>> > Thanks,<br>
> >>>><br>
> >>>> > Tom<br>
> >>>><br>
> >>>> > _______________________________________________<br>
> >>>><br>
> >>>> > cfe-dev mailing list<br>
> >>>><br>
> >>>> > <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a> <mailto:<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>><br>
> <mailto:<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a> <mailto:<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>>><br>
> >>>><br>
> >>>> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-</a><br>
> 3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-<br>
> 2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqS<br>
> zuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b<br>
> -TAvUcnc&e=<br>
> >>>><br>
> >>>> ><br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> _______________________________________________<br>
> >>>><br>
> >>>> cfe-dev mailing list<br>
> >>>><br>
> >>>> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
> >>>><br>
> >>>> <a href="https://urldefense.proofpoint.com/v2/url?u=https-" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-</a><br>
> 3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-<br>
> 2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqS<br>
> zuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b<br>
> -TAvUcnc&e=<br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> _______________________________________________<br>
> >>>> LLVM Developers mailing list<br>
> >>>> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> >>>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
> >><br>
<br>
</blockquote></div></div>