<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">> <span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">I see. So LSR could theoretically
counteract undesirable Ind Var transformations but it’s not implemented at the moment?</span><br style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
</p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">I believe that's correct.</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">> </span>I think I’ve managed
to come up with a small reproducer that can also exhibit similar problem on x86, here it is: <a href="https://godbolt.org/z/_wxzut" id="LPlnk127315" class="OWAAutoLink" previewremoved="true">https://godbolt.org/z/_wxzut</a><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"></p>
<div><br>
</div>
</span>
<p></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">Thanks. Can you please file
a bug on <a href="https://bugs.llvm.org/" class="OWAAutoLink" id="LPlnk282596" previewremoved="true">https://bugs.llvm.org/</a>? (if you can't, let us know, and one of us can do it).</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"> -Hal</span></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature">
<div class="BodyFragment"><font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hal Finkel<br>
Lead, Compiler Technology and Programming Languages<br>
Leadership Computing Facility<br>
Argonne National Laboratory</div>
</span></font></div>
</div>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Danila Malyutin <Danila.Malyutin@synopsys.com><br>
<b>Sent:</b> Friday, August 9, 2019 10:27 AM<br>
<b>To:</b> Finkel, Hal J. <hfinkel@anl.gov><br>
<b>Cc:</b> llvm-dev@lists.llvm.org <llvm-dev@lists.llvm.org>; Michael Kruse <llvmdev@meinersbur.de><br>
<b>Subject:</b> RE: [llvm-dev] How to best deal with undesirable Induction Variable Simplification?</font>
<div> </div>
</div>
<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="x_WordSection1">
<p class="x_MsoNormal">Hi Hal,</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">I see. So LSR could theoretically counteract undesirable Ind Var transformations but it’s not implemented at the moment?<br>
<br>
I think I’ve managed to come up with a small reproducer that can also exhibit similar problem on x86, here it is:
<a href="https://godbolt.org/z/_wxzut" id="LPlnk127315" class="OWAAutoLink" previewremoved="true">
https://godbolt.org/z/_wxzut</a></p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">As you can see, when rewriteLoopExitValues is not disabled Clang generates worse code due to additional spills, because Ind Vars rewrites all exit values of ‘a’ to recompute it’s value instead of reusing the value from the loop body.
This requires extra registers for the new “a after the loop” value (since it’s not simply reused) and also to store the new “offset”, which leads to the extra spills since they all live across big loop body. When exit values are not rewritten ‘a’ stays in
it’s `r15d` register with no extra costs.</p>
<p class="x_MsoNormal"> </p>
<div>
<p class="x_MsoNormal">--</p>
<p class="x_MsoNormal">Danila</p>
</div>
<p class="x_MsoNormal"> </p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="x_MsoNormal"><b>From:</b> Finkel, Hal J. [mailto:hfinkel@anl.gov] <br>
<b>Sent:</b> Thursday, August 8, 2019 21:24<br>
<b>To:</b> Danila Malyutin <Danila.Malyutin@synopsys.com><br>
<b>Subject:</b> Re: [llvm-dev] How to best deal with undesirable Induction Variable Simplification?</p>
</div>
</div>
<p class="x_MsoNormal"> </p>
<div id="x_divtagdefaultwrapper">
<p><span style="font-size:12.0pt; color:black">Hi, Danila,</span></p>
<p><span style="font-size:12.0pt; color:black"> </span></p>
<p><span style="font-size:12.0pt; color:black">Regarding the first case, this is certainly a problem that has come up before. As I recall, and I believe this is still true, LoopStrengthReduce, where we reason about induction variables while accounting for register
pressure, won't currently add new PHIs. People have talked about extending LSR to consider adding new PHIs in the past.</span></p>
<p><span style="font-size:12.0pt; color:black"> </span></p>
<p><span style="font-size:12.0pt; color:black">Regarding the second case, could you post a more-detailed description? I don't quite understand the issue.</span></p>
<p><span style="font-size:12.0pt; color:black"> </span></p>
<p><span style="font-size:12.0pt; color:black"> -Hal</span></p>
<p><span style="font-size:12.0pt; color:black"> </span></p>
<div id="x_Signature">
<div>
<div>
<p class="x_MsoNormal"><span style="font-size:10.0pt; color:black">Hal Finkel<br>
Lead, Compiler Technology and Programming Languages<br>
Leadership Computing Facility<br>
Argonne National Laboratory</span></p>
</div>
</div>
</div>
<p class="x_MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:12.0pt; color:black"> </span></p>
<div>
<div class="x_MsoNormal" align="center" style="text-align:center"><span style="font-size:12.0pt; color:black">
<hr size="2" width="98%" align="center">
</span></div>
<div id="x_divRplyFwdMsg">
<p class="x_MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" id="LPlnk983280" class="OWAAutoLink" previewremoved="true">llvm-dev-bounces@lists.llvm.org</a>> on behalf
of Danila Malyutin via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" id="LPlnk266327" class="OWAAutoLink" previewremoved="true">llvm-dev@lists.llvm.org</a>><br>
<b>Sent:</b> Thursday, August 8, 2019 12:36 PM<br>
<b>To:</b> <a href="mailto:llvm-dev@lists.llvm.org" id="LPlnk577741" class="OWAAutoLink" previewremoved="true">
llvm-dev@lists.llvm.org</a> <<a href="mailto:llvm-dev@lists.llvm.org" id="LPlnk963956" class="OWAAutoLink" previewremoved="true">llvm-dev@lists.llvm.org</a>><br>
<b>Subject:</b> [llvm-dev] How to best deal with undesirable Induction Variable Simplification?</span><span style="font-size:12.0pt; color:black">
</span></p>
<div>
<p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
</div>
<div>
<div>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">Hello,<br>
Recently I’ve come across two instances where Induction Variable Simplification lead to noticable performance regressions.</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">In one case, the removal of extra IV lead to the inability to reschedule instructions in a tight loop to reduce stalls. In that case, there were enough registers to spare, so using extra register
for extra induction variable was preferable since it reduced dependencies in the loop.<br>
In the second case, there was a big nested loop made even bigger after unswitching. However, the inner loop body was rather simple, of the form:</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">loop {</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black"> p+=n;</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">…</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black"> p+=n;</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">…</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">}<br>
use p.</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black"> </span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">Due to unswitching there were several such loops each with the different number of p+=n ops, so when the IndVars pass rewrote all exit values, it added a lot of slightly different offsets to
the main loop header that couldn’t fit in the available registers which lead to unnecessary spills/reloads.<br>
<br>
I am wondering what is the usual strategy for dealing with such “pessimizations”? Is it possible to somehow modify the IndVarSimplify pass to take those issues into account (for example, tell it that adding offset computation + gep is potentially more expensive
than simply reusing last var from the loop) or should it be recovered in some later pass? If so, is there an easy way to revert IV elimination? Have anyone dealt with similar issues before?</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black"> </span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">--</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black">Danila</span></p>
<p class="x_xmsonormal"><span style="font-size:12.0pt; color:black"> </span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>