<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> *Clang* can assign whatever meaning to an AS it wishes, and their properties are configurable via data layout configuration. </blockquote><div> </div><div>I think Clang checks that its data layout matches the LLVM target data layout, so I'm not sure how to go about implementing the address spaces as a change in Clang.</div><div>Thoughts?<br></div><div><br></div><div>The other issue I was running into is how to do the address space casts in clang - my current thought was to lower the address space casts in LLVM to the sign extension / zero extension / truncation.</div><div><br></div><div>Thanks,</div><div>Amy</div><div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 22, 2019 at 5:06 PM Philip Reames via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>Please don't bake in knowledge *in LLVM* of a address space
unless there's a strong need. *Clang* can assign whatever meaning
to an AS it wishes, and their properties are configurable via data
layout configuration. <br>
</p>
<p>The standards of review are much lower for a Clang only change as
it can be revised arbitrarily without breaking other uses of
LLVM. Building in first class knowledge to LLVM itself is a
breaking change (potentially) for other frontends.<br>
</p>
<p>Philip<br>
</p>
<div class="gmail-m_1265553166433552702gmail-m_4196452928243478694gmail-m_-4287307996858829487gmail-m_3219875258344683104gmail-m_-2715504585380507938gmail-m_-9148559015807187850gmail-m_-645827780070964453moz-cite-prefix">On 7/22/19 1:19 PM, Reid Kleckner via
llvm-dev wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Yes, the address spaces are intended to be generally useful
for other applications. Glad to hear that you would find it
useful. :)</div>
<div><br>
</div>
<div>For now we were only going to add them for x86, but it
should be easy to add such address spaces to other targets.<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Jul 22, 2019 at 1:13
PM John Reagan via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Amy,
when you say "implement MSVC's extensions", is that MSVC/LLVM
or<br>
are you going to add these to clang? OpenVMS has dual-sized
pointers as<br>
well and want to see them in clang. One of my engineers
noticed that<br>
address space 4 was a 32-bit pointer address space (or at
least it used<br>
to be). I haven't seen any formal discussion of that over in
the cfe<br>
dev list. I'm happy to help out where we can.<br>
<br>
John<br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote>
</div>
<br>
<fieldset class="gmail-m_1265553166433552702gmail-m_4196452928243478694gmail-m_-4287307996858829487gmail-m_3219875258344683104gmail-m_-2715504585380507938gmail-m_-9148559015807187850gmail-m_-645827780070964453mimeAttachmentHeader"></fieldset>
<pre class="gmail-m_1265553166433552702gmail-m_4196452928243478694gmail-m_-4287307996858829487gmail-m_3219875258344683104gmail-m_-2715504585380507938gmail-m_-9148559015807187850gmail-m_-645827780070964453moz-quote-pre">_______________________________________________
LLVM Developers mailing list
<a class="gmail-m_1265553166433552702gmail-m_4196452928243478694gmail-m_-4287307996858829487gmail-m_3219875258344683104gmail-m_-2715504585380507938gmail-m_-9148559015807187850gmail-m_-645827780070964453moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>
<a class="gmail-m_1265553166433552702gmail-m_4196452928243478694gmail-m_-4287307996858829487gmail-m_3219875258344683104gmail-m_-2715504585380507938gmail-m_-9148559015807187850gmail-m_-645827780070964453moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>