<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>+1</p>
<p>With one important note which is that the documentation should
not that authors are expected to watch llvm-commit for responses,
since not all of them make it to phabricator. And definitely
emphasize the need to add llvm-commits explicitly to the review!<br>
</p>
<p>Philip<br>
</p>
<div class="moz-cite-prefix">On 6/19/19 10:57 AM, Finkel, Hal J. via
llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c47abb2d-e382-d116-e4fd-9b1069afdb28@anl.gov">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">On 6/19/19 12:50 PM, Reid Kleckner
via llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CACs=tyJdwo1podS4DRBTkbPHoqOFPGQP0_p7SPugSmaZo_uopw@mail.gmail.com">
<div dir="ltr">I believe the history is that when Phab was
initially introduced, we wrote the documentation this way to
make things easy for reviewers who didn't want to change their
workflow. But, I agree with your observations. The majority of
code review seems to happen on Phabricator, and the best way
to get traction on a new patch is to upload it to Phab and add
a few reviewers by name. Regardless of what workflow reviewers
would prefer, I think the documentation should recommend
Phabricator over email to first time contributors, since, in
my experience, it gets better results.</div>
</blockquote>
<p><br>
</p>
<p>+1</p>
<p> -Hal<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CACs=tyJdwo1podS4DRBTkbPHoqOFPGQP0_p7SPugSmaZo_uopw@mail.gmail.com"><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Jun 19, 2019 at 7:30
AM Roman Lebedev via llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
The current documentation talks about both the Phabricator
review, and review<br>
as mail replies on -commits lists. It also talks about
submitting<br>
patches to lists,<br>
with the subtext that it may be friendlier for outsiders.<br>
<br>
It is true that Phabricator has some entry threshold, larger
than<br>
github, or maillists,<br>
so the attempt is not unwarranted. But from what i can tell,
99.9% patches go<br>
via Phabricator. There is a large chance that such a
mail-only patch<br>
will simply be<br>
overlooked, ignored, or the very first reply will be "Please
post the patch to<br>
Phabricator".<br>
<br>
Both of these cases i would call counter-welcoming.<br>
I don't think that is what we want?<br>
<br>
I propose to fix the docs to specify that all new patches
should go<br>
via Phabricator, not lists:<br>
<a href="https://reviews.llvm.org/D63488" rel="noreferrer"
target="_blank" moz-do-not-send="true">https://reviews.llvm.org/D63488</a><br>
<br>
Roman.<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org" moz-do-not-send="true">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>