<div dir="ltr"><div dir="ltr"><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019 at 11:16 AM Jordan Rupprecht <<a href="mailto:rupprecht@google.com">rupprecht@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>(+cc gribozavr, maintainer of gribozavr3 buildslave)</div><div><br></div>I played around with this yesterday and today (I had to head out before I could reply on D63211).<div><br></div><div>The recommonmark version is what matters most, but the Sphinx version isn't completely irrelevant. For instance, the current way we install the recommonmark module is deprecated in >1.8 and removed in 3.0 (trunk, seems to be unreleased): <a href="http://www.sphinx-doc.org/en/master/usage/markdown.html" class="gmail-m_1949436834844841527m_-7735710739018891335cremed gmail-m_1949436834844841527cremed cremed" target="_blank">http://www.sphinx-doc.org/en/master/usage/markdown.html</a>. However, when I change registration that way, I get errors that "extension 'recommonmark' has no setup() function".</div></div></blockquote><div>To be clear: this error is w/ Sphinx 1.7.5 + recommonmark 0.5.0. There is no error here w/ Sphinx >= 1.8.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>(This is tangential to the original problem, but I note it because if you pull Sphinx from trunk and try to build llvm docs, it will not work because of this. If possible, we should try to deal with it now so we only have to reconfigure buildbots once)</div><div><br></div><div>My suggested approach (no buildbot breakages):</div><div>- Change broken links between md<->rst files to plain html links (annoying, but temporary)</div></div></blockquote><div>Mailed <a href="https://reviews.llvm.org/D63292" class="cremed">https://reviews.llvm.org/D63292</a></div><div>(btw, sphinx also logs some unrelated warnings, fixed w/ <a href="https://reviews.llvm.org/rL363294" class="cremed">https://reviews.llvm.org/rL363294</a>)</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>- Updated recommonmark on buildbots to 0.5.0 (presumably it's at <= 0.4.0 on build bots, but I can't find a way to verify this)</div><div>- Change html links back to normal markdown syntax</div><div>- Update Sphinx to >1.8 (and < 3.0) (possibly waiting until it hits whatever stable repo the buildbot installs from)</div><div>- Switch the registration method of recommonmark in conf.py to the non-deprecated way</div><div>- Upgrading to Sphinx >= 3.0 will not be a problem now</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019 at 6:18 AM James Henderson <<a href="mailto:jh7370.2008@my.bristol.ac.uk" target="_blank" class="cremed">jh7370.2008@my.bristol.ac.uk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div><div>TL;DR - We should update the bot(s) responsible for building the LLVM documentation so that they use recommonmark 0.5.0, and apply <a href="https://reviews.llvm.org/D63211" target="_blank" class="cremed">https://reviews.llvm.org/D63211</a>.</div><div><br></div><div>Full context:<br></div><div><br></div><div>I recently started trying to build the sphinx docs. However, a change by Jordan (r363100) resulted in me no longer being able to build them, even though the build bots were green and he could build them himself. After some digging, it looks like it's an issue with the latest version of the recommonmark python module. I verified that I don't see the issue with v0.4.0, but do with v0.5.0. The sphinx version doesn't seem to make any difference.</div><div><br></div><div>I could
downgrade
my module version
(and have temporarily done so). However, that leads to another issue: the links to llvm-symbolizer's page in <a href="https://llvm.org/docs/CommandGuide/llvm-addr2line.html" target="_blank" class="cremed">https://llvm.org/docs/CommandGuide/llvm-addr2line.html</a> are broken when building with 0.4.0. This can be fixed by changing the markdown doc to explicitly specify ".html" in the link, but this precise change is what breaks 0.5.0 (which otherwise produces working links in the llvm-addr2line doc). I think we should update the build bots version of recommonmark. Since this would cause the build to break, we should simultaneously (or more exactly slightly before) apply the patch in
<a href="https://reviews.llvm.org/D63211" target="_blank" class="cremed">https://reviews.llvm.org/D63211</a>, which fixes the warning that I am seeing with 0.5.0.</div><div><br></div><div>I've included a couple of people I know to be involved with either the website or the build bots. Sorry if it's misdirected!</div><div><br></div><div>Thoughts?<br></div><div><br></div><div>James<br></div></div>
</blockquote></div>
</blockquote></div></div>