<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jun 7, 2019, at 6:47 AM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div dir="ltr" class="">On Thu, Jun 6, 2019 at 12:56 PM Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div dir="ltr" class="">On Wed, Jun 5, 2019 at 1:33 PM <<a href="mailto:vsk@apple.com" target="_blank" class="">vsk@apple.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jun 4, 2019, at 4:41 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank" class="">thakis@chromium.org</a>> wrote:</div><br class="gmail-m_-1942308880445312611gmail-m_6528325519568439786Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">On Mon, Jun 3, 2019 at 2:06 PM <<a href="mailto:vsk@apple.com" target="_blank" class="">vsk@apple.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class="">Hi Nico,<div class=""><br class=""></div><div class="">Sorry for the delay, I've been OOO. The llvm-cov bot should produce reports for llvm-undname starting today.</div></div></blockquote><div class=""><br class=""></div><div class="">Thanks! It looks like <a href="http://lab.llvm.org:8080/coverage/coverage-reports/index.html" target="_blank" class="">http://lab.llvm.org:8080/coverage/coverage-reports/index.html</a><span class="Apple-converted-space"> </span>now has an "llvm-undname" entry, but <a href="http://lab.llvm.org:8080/coverage/coverage-reports/llvm/index.html" target="_blank" class="">http://lab.llvm.org:8080/coverage/coverage-reports/llvm/index.html</a><span class="Apple-converted-space"> </span>still doesn't have an entry for llvm/lib/MicrosoftDemangle.cpp (and neither does <a href="http://lab.llvm.org:8080/coverage/coverage-reports/llvm-undname/index.html" target="_blank" class="">http://lab.llvm.org:8080/coverage/coverage-reports/llvm-undname/index.html</a>).</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">For now, coverage for MicrosoftDemangle.cpp should show up under the <a href="http://lab.llvm.org:8080/coverage/coverage-reports/all/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Demangle/MicrosoftDemangle.cpp.html" target="_blank" class="">"all" entry</a>.</div><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class="">What I'd ideally want is that the llvm report (<a href="http://lab.llvm.org:8080/coverage/coverage-reports/llvm/index.html" target="_blank" class="">http://lab.llvm.org:8080/coverage/coverage-reports/llvm/index.html</a>) just shows coverage data for llvm/lib/MicrosoftDemangle.cpp llvm/lib/MicrosoftDemangleNodes.cpp llvm/include/llvm/Demangle/MicrosoftDemangle.h llvm/include/llvm/Demangle/MicrosoftDemangleNodes.h in addition to the other files that are there (and there's no separate report for llvm-undname).</div></div></div></div></blockquote><div class=""><br class=""></div>This should be fixed on the next successful run.</div></div></blockquote><div class=""><br class=""></div><div class="">Thanks much! I know see the file on <a href="http://lab.llvm.org:8080/coverage/coverage-reports/llvm/index.html" target="_blank" class="">http://lab.llvm.org:8080/coverage/coverage-reports/llvm/index.html</a><span class="Apple-converted-space"> </span>, that's great!</div><div class=""><br class=""></div><div class="">Is there a way to see which revision the report was built at?  That page shows 75.13% (1607/2139) line coverage for MicrosoftDemangle.cpp. I added lots of converage ~2 days ago (<a href="https://github.com/llvm/llvm-project/commits/master/llvm/test/Demangle" target="_blank" class="">https://github.com/llvm/llvm-project/commits/master/llvm/test/Demangle</a>) and locally coverage for that file after running just `out/gn/bin/llvm-lit llvm/test/Demangle/` shows line coverage of 83.50% (1801/2157). Is that just due to the coverage report lagging trunk by a few days, or is something else up?</div></div></div></blockquote><div class=""><br class=""></div><div class="">Even more mysteriously, in the "all" report (<a href="http://lab.llvm.org:8080/coverage/coverage-reports/all/index.html" class="">http://lab.llvm.org:8080/coverage/coverage-reports/all/index.html</a>), MicrosoftDemangle.cpp's line coverage is just  45.21% (967/2139).</div></div></div></div></blockquote><div><br class=""></div>That's strange. You might have hit a race condition while the bot was busy uploading new reports? Currently, under the "all" and "llvm" reports, MicrosoftDemangle.cpp's line coverage is 74%.</div><div><br class=""></div><div><blockquote type="cite" class=""><div class=""><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="gmail_quote"><div class=""><br class=""></div><div class="">I assumed that "llvm" is the result of `check-llvm` and "all" is `check-all`. Both of those should run the tests in llvm/test/Demangle, but it feels like that doesn't happen in either case. Can you think of a reason for why the bot wouldn't run the tests in llvm/test/Demangle?</div></div></div></div></blockquote><div><br class=""></div><div>There's just one set of tests which run once, and I can't think of any reason why tests in llvm/test/Demangle wouldn't run.e</div><div><br class=""></div><div>vedant</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><div class=""><br class=""></div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class="">I figured what the bot does is run `check-llvm` and then pass all binaries that run as part of `llvm-check` to the report generation script, and I had assumed llvm-undname was just missing on that list of all binaries. But maybe that's not how that coverage list is computed?</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">The bot runs check-llvm, but passes a predefined list of binaries to llvm-cov to save time. llvm-undname was missing in the list of binaries to group under the 'all' and 'llvm' entries.</div><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><div class="">As for +x permissions on llvm/utils/prepare-code-coverage-artifact.py, it's an oversight that they are missing. I wasn't able to land a permissions change via the new monorepo (I get: "Committed c3b9398d101 to svn", but the commit does not appear). Perhaps you'll have better luck?<br class=""></div></div></blockquote><div class=""><br class=""></div><div class="">I couldn't figure out how to do it via git-svn / `git-llvm push` either, but I added the +x bit in r362561 using an old svn checkout I had lying around.</div></div></div></blockquote><div class=""><br class=""></div>Thanks!</div><div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><div class=""></div><div class=""><br class=""></div><div class="">best,</div><div class="">vedant<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On May 31, 2019, at 8:01 PM, Chris Matthews <<a href="mailto:chris.matthews@apple.com" target="_blank" class="">chris.matthews@apple.com</a>> wrote:</div><br class="gmail-m_-1942308880445312611gmail-m_6528325519568439786gmail-m_-6203657135107623817Apple-interchange-newline"><div class=""><div dir="auto" class="">Probably this job:<div class=""><br class=""></div><div class=""><a href="http://lab.llvm.org:8080/green/job/clang-stage2-coverage-R/" target="_blank" class="">lab.llvm.org:8080/green/job/clang-stage2-coverage-R/</a><br class=""><br class=""><div dir="ltr" class="">💬 from ðŸ“±</div><div dir="ltr" class=""><br class="">On May 31, 2019, at 3:35 PM, Duncan Exon Smith <<a href="mailto:dexonsmith@apple.com" target="_blank" class="">dexonsmith@apple.com</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div dir="ltr" class="">+Chris Matthews, do you know where the configs are stored for this?<div class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On 2019 May  31, at 12:39, Chris Bieneman <<a href="mailto:beanz@apple.com" target="_blank" class="">beanz@apple.com</a>> wrote:</div><br class="gmail-m_-1942308880445312611gmail-m_6528325519568439786gmail-m_-6203657135107623817Apple-interchange-newline"><div class=""><div class="">Hey Nico,<div class=""><br class=""></div><div class="">I'm actually not sure where the configurations for that bot are stored. I suspect Duncan may have a better idea.</div><div class=""><br class=""></div><div class="">I'm reasonably certain that the missing +x is just an oversight.</div><div class=""><br class=""></div><div class="">-Chris<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On May 30, 2019, at 6:24 PM, Nico Weber via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="gmail-m_-1942308880445312611gmail-m_6528325519568439786gmail-m_-6203657135107623817Apple-interchange-newline"><div class=""><div dir="ltr" class="">Vedant or Chris: Ping :)</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 29, 2019 at 7:56 AM Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank" class="">thakis@chromium.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class="">Hi Vedant and Chris,<br class=""><br class="">is the config for<span class="Apple-converted-space"> </span><a href="http://lab.llvm.org:8080/coverage/coverage-reports/index.html" target="_blank" class="">http://lab.llvm.org:8080/coverage/coverage-reports/index.html</a><span class="Apple-converted-space"> </span>public somewhere? If so, where? (I looked in zorg but didn't find it.)<br class=""><br class="">If not, could you add "llvm-undname" to the list of binaries passed to llvm/utils/prepare-code-coverage-artifact.py so that llvm/lib/Demangle/MicrosoftDemangle.cpp (and friends) show up? (If the config is public, I can send you a patch.)<br class=""><br class="">Also, is there a reason llvm/utils/prepare-code-coverage-artifact.py doesn't have +x set, or is that just an oversight?<br class=""><br class="">Thanks,<br class="">Nico<br class=""></div></blockquote></div>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" target="_blank" class="">llvm-dev@lists.llvm.org</a><br class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a></div></blockquote></div></div></div></div></blockquote></div></div></div></blockquote></div></div></div></blockquote></div></div></div></blockquote></div></div></div></blockquote></div></div></blockquote></div></div></blockquote></div></div></div></blockquote></div><br class=""></body></html>